From fea4fd2d5ef0b49bd705acd1b8b6a8b215ac1385 Mon Sep 17 00:00:00 2001 From: "Mark A. Hershberger" Date: Tue, 7 Dec 2010 21:53:50 +0000 Subject: [PATCH] Filenames with quotes fail here. --- maintenance/tests/phpunit/includes/api/RandomImageGenerator.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/maintenance/tests/phpunit/includes/api/RandomImageGenerator.php b/maintenance/tests/phpunit/includes/api/RandomImageGenerator.php index 05861f93e8..6bb9d00fee 100644 --- a/maintenance/tests/phpunit/includes/api/RandomImageGenerator.php +++ b/maintenance/tests/phpunit/includes/api/RandomImageGenerator.php @@ -200,7 +200,7 @@ class RandomImageGenerator { $drawCommand = "fill $fill circle $originX,$originY $perimeterX,$perimeterY"; $args[] = '-draw ' . wfEscapeShellArg( $drawCommand ); } - $args[] = $filename; + $args[] = wfEscapeShellArg( $filename ); $command = wfEscapeShellArg( $wgImageMagickConvertCommand ) . " " . implode( " ", $args ); $retval = null; -- 2.20.1