From e849ffb43085968169f0b0dcb65e54c90b4b2403 Mon Sep 17 00:00:00 2001 From: Derick Alangi Date: Mon, 3 Jun 2019 15:16:38 +0100 Subject: [PATCH] HTMLForm: Remove deprecated unused getErrors() method Was deprecated in 1.28 and no longer used, see usage below; Usage ===== https://codesearch.wmflabs.org/search/?q=%5CbgetErrors%5C(%20(.*%3F)%20%5C)&i=nope&files=&repos= Bug: T220656 Change-Id: I542df4f1f7f4180d42282eaf2e069ab0bc9e8614 --- RELEASE-NOTES-1.34 | 4 +++- includes/htmlform/HTMLForm.php | 14 -------------- 2 files changed, 3 insertions(+), 15 deletions(-) diff --git a/RELEASE-NOTES-1.34 b/RELEASE-NOTES-1.34 index d372db8ec2..8c230bf243 100644 --- a/RELEASE-NOTES-1.34 +++ b/RELEASE-NOTES-1.34 @@ -189,8 +189,10 @@ because of Phabricator reports. Use the mediawiki.String module instead. * mw.language.specialCharacters, deprecated in 1.33, has been removed. Use require( 'mediawiki.language.specialCharacters' ) instead. -* EditPage::submit(), deprecated in 1.29, has been removed. Used $this->edit() +* EditPage::submit(), deprecated in 1.29, has been removed. Use $this->edit() directly. +* HTMLForm::getErrors(), deprecated in 1.28, has been removed. Use + getErrorsOrWarnings() instead. * … === Deprecations in 1.34 === diff --git a/includes/htmlform/HTMLForm.php b/includes/htmlform/HTMLForm.php index 504202845a..acf64db346 100644 --- a/includes/htmlform/HTMLForm.php +++ b/includes/htmlform/HTMLForm.php @@ -1277,20 +1277,6 @@ class HTMLForm extends ContextSource { return $this->displaySection( $this->mFieldTree, $this->mTableId ); } - /** - * Format and display an error message stack. - * - * @param string|array|Status $errors - * - * @deprecated since 1.28, use getErrorsOrWarnings() instead - * - * @return string - */ - public function getErrors( $errors ) { - wfDeprecated( __METHOD__, '1.28' ); - return $this->getErrorsOrWarnings( $errors, 'error' ); - } - /** * Returns a formatted list of errors or warnings from the given elements. * -- 2.20.1