From 91921b8dd4ded1c107f95e26af0fa6d583ecd208 Mon Sep 17 00:00:00 2001 From: Sam Reed Date: Sat, 23 Jan 2010 22:43:21 +0000 Subject: [PATCH] Followup to r61436 -rakkaus:#mediawiki-i18n- [23-Jan-2010 22:40:23] PHP Notice: Undefined property: ApiQueryAllpages::$params in /www/w/includes/api/ApiQueryAllpages.php on line 62 --- includes/api/ApiQueryAllpages.php | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/includes/api/ApiQueryAllpages.php b/includes/api/ApiQueryAllpages.php index e2da777eb8..0f29b3a2ea 100644 --- a/includes/api/ApiQueryAllpages.php +++ b/includes/api/ApiQueryAllpages.php @@ -59,9 +59,9 @@ class ApiQueryAllpages extends ApiQueryGeneratorBase { // Page filters $this->addTables( 'page' ); - if ( $this->params['filterredir'] == 'redirects' ) + if ( $this->params['filterredir'] === 'redirects' ) $this->addWhereFld( 'page_is_redirect', 1 ); - else if ( $this->params['filterredir'] == 'nonredirects' ) + else if ( $this->params['filterredir'] === 'nonredirects' ) $this->addWhereFld( 'page_is_redirect', 0 ); $this->addWhereFld( 'page_namespace', $params['namespace'] ); @@ -81,6 +81,7 @@ class ApiQueryAllpages extends ApiQueryGeneratorBase { } else { $selectFields = $resultPageSet->getPageTableFields(); } + $this->addFields( $selectFields ); $forceNameTitleIndex = true; if ( isset ( $params['minsize'] ) ) { @@ -134,6 +135,7 @@ class ApiQueryAllpages extends ApiQueryGeneratorBase { $this->addOption( 'GROUP BY', implode( ', ', $selectFields ) ); $forceNameTitleIndex = false; } + if ( $forceNameTitleIndex ) $this->addOption( 'USE INDEX', 'name_title' ); -- 2.20.1