From 73fb6d901f666740850a7ea8e853c190d20fcc2a Mon Sep 17 00:00:00 2001
From: Thiemo Kreuz <thiemo.kreuz@wikimedia.de>
Date: Thu, 20 Dec 2018 17:58:15 +0100
Subject: [PATCH] Mark private properties in ContribsPager as "private"

There should not be any code accessing these. The way to set these
properties is via the constructor.

Change-Id: I8f2a8e88b8dfad53d0b16bc3f73974b894a031fb
---
 includes/specials/pagers/ContribsPager.php | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/includes/specials/pagers/ContribsPager.php b/includes/specials/pagers/ContribsPager.php
index 16a5e9111a..59f26a213a 100644
--- a/includes/specials/pagers/ContribsPager.php
+++ b/includes/specials/pagers/ContribsPager.php
@@ -33,12 +33,12 @@ class ContribsPager extends RangeChronologicalPager {
 	/**
 	 * @var string[] Local cache for escaped messages
 	 */
-	public $messages;
+	private $messages;
 
 	/**
 	 * @var string User name, or a string describing an IP address range
 	 */
-	public $target;
+	private $target;
 
 	/**
 	 * @var string Set to "newbie" to list contributions from the most recent 1% registered users.
@@ -49,7 +49,7 @@ class ContribsPager extends RangeChronologicalPager {
 	/**
 	 * @var string|int A single namespace number, or an empty string for all namespaces
 	 */
-	public $namespace = '';
+	private $namespace = '';
 
 	/**
 	 * @var string|false Name of tag to filter, or false to ignore tags
@@ -87,22 +87,22 @@ class ContribsPager extends RangeChronologicalPager {
 	 */
 	private $hideMinor;
 
-	public $preventClickjacking = false;
+	private $preventClickjacking = false;
 
 	/** @var IDatabase */
-	public $mDbSecondary;
+	private $mDbSecondary;
 
 	/**
 	 * @var array
 	 */
-	protected $mParentLens;
+	private $mParentLens;
 
 	/**
 	 * @var TemplateParser
 	 */
-	protected $templateParser;
+	private $templateParser;
 
-	function __construct( IContextSource $context, array $options ) {
+	public function __construct( IContextSource $context, array $options ) {
 		parent::__construct( $context );
 
 		$msgs = [
-- 
2.20.1