From 703c57716d9892df4612475a5a2596017ece732f Mon Sep 17 00:00:00 2001
From: Rob Church <robchurch@users.mediawiki.org>
Date: Sat, 24 Jun 2006 19:42:32 +0000
Subject: [PATCH] (bug 6428) Incorrect form action URL on Special:Newimages
 with hidebots = 0 set

---
 RELEASE-NOTES                 | 1 +
 includes/SpecialNewimages.php | 5 +----
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index 848ca3e798..f5a7a1c8a6 100644
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -553,6 +553,7 @@ Some default configuration options have changed:
   but could be added in the future.
 * (bug 6423) Don't update newtalk flag if page content didn't change (null edits
   were causing the newtalk flag to trigger inappropriately)
+* (bug 6428) Incorrect form action URL on Special:Newimages with hidebots = 0 set
 
 == Compatibility ==
 
diff --git a/includes/SpecialNewimages.php b/includes/SpecialNewimages.php
index 8d7d814479..c20f23bb6c 100644
--- a/includes/SpecialNewimages.php
+++ b/includes/SpecialNewimages.php
@@ -151,10 +151,7 @@ function wfSpecialNewimages( $par, $specialPage ) {
 
 	$sub = wfMsg( 'ilsubmit' );
 	$titleObj = Title::makeTitle( NS_SPECIAL, 'Newimages' );
-	$action = $titleObj->escapeLocalURL();
-	if(!$hidebots) {
-		$action.='&hidebots=0';
-	}
+	$action = $titleObj->escapeLocalURL( $hidebots ? '' : 'hidebots=0' );
 	if ($shownav) {
 		$wgOut->addHTML( "<form id=\"imagesearch\" method=\"post\" action=\"" .
 		  "{$action}\">" .
-- 
2.20.1