From 3c7435421a0235653a5c4547b5c48d78833c7053 Mon Sep 17 00:00:00 2001 From: Robert Leverington Date: Sun, 11 May 2008 17:31:38 +0000 Subject: [PATCH] Avoid possible register_globals issue. --- includes/SpecialUpload.php | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/includes/SpecialUpload.php b/includes/SpecialUpload.php index 1df6dac5ac..61c3ef5157 100644 --- a/includes/SpecialUpload.php +++ b/includes/SpecialUpload.php @@ -900,6 +900,11 @@ class UploadForm { $useAjaxDestCheck = $wgUseAjax && $wgAjaxUploadDestCheck; $useAjaxLicensePreview = $wgUseAjax && $wgAjaxLicensePreview; + // Initilaize $extensionList here in case it is not set later on + // (which would cause a E_NOTICE) and it must not be set only if it + // isn't set to avoid a possible register_globals issue. + $extensionList = ''; + $adc = wfBoolToStr( $useAjaxDestCheck ); $alp = wfBoolToStr( $useAjaxLicensePreview ); $autofill = wfBoolToStr( $this->mDesiredDestName == '' ); @@ -1059,10 +1064,6 @@ wgUploadAutoFill = {$autofill}; $encComment = htmlspecialchars( $this->mComment ); - if( !isset( $extensionsList ) ) { - $extensionsList = ''; - } - $wgOut->addHTML( Xml::openElement( 'form', array( 'method' => 'post', 'action' => $titleObj->getLocalURL(), 'enctype' => 'multipart/form-data', 'id' => 'mw-upload-form' ) ) . -- 2.20.1