From 3bcb264f899c93f4866a45358c80c64088609f9c Mon Sep 17 00:00:00 2001
From: Brion Vibber <brion@users.mediawiki.org>
Date: Tue, 30 Dec 2008 18:43:35 +0000
Subject: [PATCH] Cleanup to r44993 -- avoid using '$x = foo()' in an if()
 condition on general principle. :)

---
 includes/ChangesList.php | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/includes/ChangesList.php b/includes/ChangesList.php
index 4d95b33f74..a8f5fff01e 100644
--- a/includes/ChangesList.php
+++ b/includes/ChangesList.php
@@ -362,8 +362,11 @@ class OldChangesList extends ChangesList {
 		# Edit/log timestamp
 		$this->insertTimestamp( $s, $rc );
 		# Bytes added or removed
-		if( $wgRCShowChangedSize && ($cd = $rc->getCharacterDifference()) ) {
-			$s .= "$cd  . . ";
+		if( $wgRCShowChangedSize ) {
+			$cd = $rc->getCharacterDifference();
+			if( $cd != '' ) {
+				$s .= "$cd  . . ";
+			}
 		}
 		# User tool links
 		$this->insertUserRelatedLinks($s,$rc);
-- 
2.20.1