From 03cc82d698acb1eef86c95592e9fc1d1a5deecde Mon Sep 17 00:00:00 2001
From: Alexandre Emsenhuber <ialex.wiki@gmail.com>
Date: Sat, 30 Jun 2012 21:27:41 +0200
Subject: [PATCH] Make PatrolLog::record() use RecentChange::getTitle(); no
 need to create a new object itself.

Change-Id: I5b8f58cf03669768132c64aafa3a968e198a7f73
---
 includes/logging/PatrolLog.php | 28 ++++++++++++----------------
 1 file changed, 12 insertions(+), 16 deletions(-)

diff --git a/includes/logging/PatrolLog.php b/includes/logging/PatrolLog.php
index 339688d3c7..4fc7637857 100644
--- a/includes/logging/PatrolLog.php
+++ b/includes/logging/PatrolLog.php
@@ -45,24 +45,20 @@ class PatrolLog {
 			}
 		}
 
-		$title = Title::makeTitleSafe( $rc->getAttribute( 'rc_namespace' ), $rc->getAttribute( 'rc_title' ) );
-		if( $title ) {
-			if ( !$user ) {
-				global $wgUser;
-				$user = $wgUser;
-			}
+		if ( !$user ) {
+			global $wgUser;
+			$user = $wgUser;
+		}
 
-			$entry = new ManualLogEntry( 'patrol', 'patrol' );
-			$entry->setTarget( $title );
-			$entry->setParameters( self::buildParams( $rc, $auto ) );
-			$entry->setPerformer( $user );
-			$logid = $entry->insert();
-			if ( !$auto ) {
-				$entry->publish( $logid, 'udp' );
-			}
-			return true;
+		$entry = new ManualLogEntry( 'patrol', 'patrol' );
+		$entry->setTarget( $rc->getTitle() );
+		$entry->setParameters( self::buildParams( $rc, $auto ) );
+		$entry->setPerformer( $user );
+		$logid = $entry->insert();
+		if ( !$auto ) {
+			$entry->publish( $logid, 'udp' );
 		}
-		return false;
+		return true;
 	}
 
 	/**
-- 
2.20.1