jenkins-bot [Thu, 20 Nov 2014 09:39:41 +0000 (09:39 +0000)]
Merge "Made $timeout in BagOStuff::lock() actually work"
Aaron Schulz [Thu, 20 Nov 2014 09:25:38 +0000 (01:25 -0800)]
Unbreak lock()/unlock() for MemcachedPhpBagOStuff
Change-Id: I49ce96b65fe6a6e2cba86a990962fe4efc43bbb8
Aaron Schulz [Thu, 20 Nov 2014 09:04:53 +0000 (01:04 -0800)]
Fixed BloomCache handling of network partitions
* As documented, it should return true on error, so that DB is
checked if the filter is down.
Change-Id: I883fafc9f5f3a84f85207de6e916f1630c78d1a4
Aaron Schulz [Thu, 20 Nov 2014 08:22:42 +0000 (00:22 -0800)]
Fixed regression that made log queries happen in spite of the bloom filter
Change-Id: I50f280a1db30cb1f9901a55a8a9558ebb2a9dffd
Prateek Saxena [Tue, 11 Nov 2014 10:41:13 +0000 (16:11 +0530)]
mediawiki.ui: checkbox: Fix states according to spec
* Color changes
* Introduces hover state
* Separates focus and active state
* Removes need for inset border
* Adds white icon for disabled & checked state
Design specification on Trello-
https://trello.com/c/JETLmm7F/7-check-boxes
Change-Id: I891f05c8edd010b81bd5f35eeae5d5dd22169933
Aaron Schulz [Thu, 20 Nov 2014 08:26:44 +0000 (00:26 -0800)]
Made $timeout in BagOStuff::lock() actually work
* Also added a separate $expiry option for things that take a long time
Change-Id: Ie5f81dea031f3c3f3ca8d61ad4cb322a5b876f61
Prateek Saxena [Wed, 5 Nov 2014 12:02:52 +0000 (17:32 +0530)]
mediawiki.ui: checkbox: Remove unnecessary nesting and group variables
Change-Id: I4caeaf52d5c38391d88f4e6218d9f3ee26346981
Prateek Saxena [Thu, 20 Nov 2014 03:56:09 +0000 (09:26 +0530)]
mediawiki.ui: Fix label text for inputs in KSS
Change-Id: I9d49bce9b197646409b115632895088909bb9458
jenkins-bot [Thu, 20 Nov 2014 01:02:15 +0000 (01:02 +0000)]
Merge "resourceloader: Update cssjanus to v1.1.1"
James D. Forrester [Thu, 20 Nov 2014 00:05:52 +0000 (16:05 -0800)]
Update OOjs UI to v0.1.0-pre (
1fa4eb7a73)
New changes:
549ff9a [BREAKING CHANGE] Rename *Menu and *MenuItem widgets
Change-Id: Ifded7f9e17923dbb56a722b7424ccd2854194c21
Timo Tijhof [Wed, 19 Nov 2014 23:39:09 +0000 (23:39 +0000)]
resourceloader: Update cssjanus to v1.1.1
Bug: 61440
Change-Id: Id0221e9f68786758e10b2f222f5e9170898e320d
Roan Kattouw [Wed, 19 Nov 2014 23:19:01 +0000 (15:19 -0800)]
Update OOjs UI to v0.1.0-pre (
7922a50558)
New changes:
491d279 Change document order of tools and actions to fix floating
25840d5 Add lang and dir attributes to the accelerator element
8a87ddf build: Update various devDependencies to latest
b0de093 Fixed RuboCop Style/AndOr offense
577ed71 Fixed RuboCop Style/AsciiComments offense
565251b Fixed RuboCop Style/EmptyLineBetweenDefs offence
328710e Fixed RuboCop Style/EmptyLines offense
f2a1811 Fixed RuboCop Style/NegatedIf offense
51e041a Fixed RuboCop Style/SignalException offense
6b3bc5c Fixed RuboCop Style/SpaceAroundEqualsInParameterDefault offense
9224811 Fixed RuboCop Style/NilComparison offense
6ff2b19 Fixed RuboCop Style/SpaceAfterComma offense
22c86e2 Fixed RuboCop Style/TrailingBlankLines offense
33fc646 Consistently use @return annotation
709546c Localisation updates from https://translatewiki.net.
6e6dfae build: Clean up fileExists config
Change-Id: I528111c92b89e0302d679ed817a98671035cd8aa
jenkins-bot [Wed, 19 Nov 2014 23:00:35 +0000 (23:00 +0000)]
Merge "Hygiene: Update mixin file to use single line comments"
jenkins-bot [Wed, 19 Nov 2014 21:19:50 +0000 (21:19 +0000)]
Merge "Remove less.js"
Translation updater bot [Wed, 19 Nov 2014 21:07:10 +0000 (22:07 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: Idb44769ae33d7beaa3430c9133c958b0745145df
jenkins-bot [Wed, 19 Nov 2014 20:14:03 +0000 (20:14 +0000)]
Merge "Make calling wfMangleFlashPolicy configurable"
csteipp [Tue, 18 Nov 2014 21:43:05 +0000 (13:43 -0800)]
Make calling wfMangleFlashPolicy configurable
Add $wgMangleFlashPolicy so sites that define a safe master flash
policy can disable mangling of the <cross-domain-policy> string.
Bug: 66776
Change-Id: Ic0db939aae9d0bb6bdfc3cd9ce282661bad46783
jenkins-bot [Wed, 19 Nov 2014 19:46:10 +0000 (19:46 +0000)]
Merge "Avoid sending empty function names to TransactionProfiler"
Aaron Schulz [Wed, 19 Nov 2014 19:39:00 +0000 (11:39 -0800)]
Avoid sending empty function names to TransactionProfiler
* This could happen if the Profiler was a stub
Change-Id: Id4f635f899ee3c0ca85acf1b1e4cde47dcbbdc75
Chad Horohoe [Wed, 19 Nov 2014 19:22:03 +0000 (11:22 -0800)]
Handle missing parser cache keys better in pool counter
Change-Id: I493fd1ee5e9ab6c3a49a7f478460cbfe54393ca0
jenkins-bot [Wed, 19 Nov 2014 19:09:52 +0000 (19:09 +0000)]
Merge "doc: Clean up Doxyfile for doxygen 1.8.6"
jenkins-bot [Wed, 19 Nov 2014 19:06:05 +0000 (19:06 +0000)]
Merge "Remove calls to legacy Profiler::debug()"
jenkins-bot [Wed, 19 Nov 2014 19:04:12 +0000 (19:04 +0000)]
Merge "Placed ProfilerStandard logic directly into SectionProfiler"
Timo Tijhof [Sat, 15 Nov 2014 12:46:26 +0000 (13:46 +0100)]
doc: Clean up Doxyfile for doxygen 1.8.6
Latest stable is v1.8.8, but Ubunu Trusty (which we now use on the
Jenkins slave that generates our documentation) ships doxygen v1.8.6.
Time to migrate away from 1.7.x stuff.
Warnings:
Tag `SYMBOL_CACHE_SIZE' at line 84 of file maintenance/Doxyfile has become obsolete.
Tag `SHOW_DIRECTORIES' at line 118 of file maintenance/Doxyfile has become obsolete.
Tag `HTML_ALIGN_MEMBERS' at line 226 of file maintenance/Doxyfile has become obsolete.
Tag `USE_INLINE_TREES' at line 253 of file maintenance/Doxyfile has become obsolete.
Regenerated with:
$ doxygen -u -s ./maintenance/Doxyfile
Which automatically added new configurations settings, removed
obsolete ones, migrated formatting to their new standard.
Change-Id: I372ea06c439762578cb4c68686344eb446925c04
jenkins-bot [Wed, 19 Nov 2014 18:57:34 +0000 (18:57 +0000)]
Merge "Make Title::makeTitleSafe() not need user variant"
Bryan Davis [Wed, 19 Nov 2014 18:55:28 +0000 (11:55 -0700)]
Remove calls to legacy Profiler::debug()
Profiler::debug() was moved to ProfilerStandard. Since we have
a proposed patch set already that will remove
wfProfileIn()/wfProfileout() calls that wrap whole methods this seem
like an easy problem to solve by removing this logging functionality.
Change-Id: I429ec29fe4393ce886361b896b650fd39480eda5
paladox [Sun, 16 Nov 2014 19:18:00 +0000 (20:18 +0100)]
Remove less.js
Change-Id: I2ec714e79463835016dcfbffcf03f052167a0b61
Kunal Mehta [Wed, 12 Nov 2014 18:34:11 +0000 (10:34 -0800)]
Use cdb library and provide a back-compat layer
The new cdb library is pulled in via composer. Since the
library uses namespaces, a backwards-compatability layer
is provided for the old class names:
* CdbReader
* CdbWriter
* CdbException
The PHP/DBA-specific classes should never have been used directly.
Depends on I98302bdf1 in mediawiki/vendor
Change-Id: I39549ac8540b262cf91f7d1830d36327afb3033d
Brad Jorsch [Wed, 19 Nov 2014 17:51:27 +0000 (12:51 -0500)]
Make Title::makeTitleSafe() not need user variant
In trying to avoid hitting RequestContext::getLanguage() from a call to
User::idFromName(), I05aacd30 made it no longer safe for user input.
A closer analysis of the call stack involved reveals that
Title::makeTitleSafe() is constructing a prefixed dbkey using the
localized name for NS_USER, and then Language::getNsIndex() is needing
to get the variant in order to handle that localized name. But if we use
the canonical name for NS_USER, Language::getNsIndex() short-circuits
and skips the problematic code path.
And it turns out that it doesn't actually matter which prefix
Title::makeTitleSafe() uses, since the prefix doesn't make it anywhere
into the resulting Title object. So let's revert I05aacd30 and Ibeef0409
and just do that instead.
Change-Id: Ib902573996c69d1e77527cc7b2faf4e7fa5d3daf
Bryan Davis [Mon, 23 Jun 2014 22:25:55 +0000 (16:25 -0600)]
Add logging context to database logs
* Add optional $context parameter to wfDebug, wfDebugLog, wfLogDBError
and wfErrorLog that will be passed to MWLogger.
* Add support for PSR-3 style log message parameter interpolation in
MWLoggerLegacyLogger.
* Add context information to wfLogDBError calls made from DatabaseBase,
DatabaseMysqlBase and LoadBalancer instances.
* Deprecate wfDebugTimer() which now appears to be unused.
Change-Id: Ic90d593d00a2b0b5b80ed205908cbe624042603c
Prateek Saxena [Wed, 19 Nov 2014 09:15:15 +0000 (14:45 +0530)]
mediawiki.ui: button: Add specific hover and active rule for color
Overrides general a:active and a:hover rules.
Bug: 73587
Change-Id: I36fa7d66d21f0133ea5525962a8b8e8ffab90494
Legoktm [Wed, 19 Nov 2014 07:25:26 +0000 (07:25 +0000)]
Merge "Bug: Append to wgAutoloadClasses"
Erik Bernhardson [Wed, 19 Nov 2014 06:23:31 +0000 (22:23 -0800)]
Bug: Append to wgAutoloadClasses
When generating $wgAutoloadClasses for an extension the generator
currently outputs an assignment (=), but it is unlikely this is
the desired result. An extension wants to append to the existing
$wgAutoloadClasses. This bug is an unintended consequence of I75403ace
which changed the generator from assigning one key per line to using
an array literal.
This patch changes the output only when generating $wgAutoloadClasses
to the += operator which adds to the array any value that is not
already in the array.
Change-Id: I7d42ee5dc829991c6562878f0c90a06fadb1b6a6
Tim Starling [Wed, 19 Nov 2014 03:25:45 +0000 (14:25 +1100)]
Fix vim folding
The "@{" in these two doc comments was being interpreted as an opening
mark and was causing almost the whole file to be in a single section.
Change-Id: I818ecd2f7621a22b6e8f5a4b93faee6fbf3664dc
jenkins-bot [Wed, 19 Nov 2014 04:12:13 +0000 (04:12 +0000)]
Merge "Follow-up to I05aacd30b: normalize case in User::idFromName"
Ori Livneh [Tue, 18 Nov 2014 22:42:18 +0000 (14:42 -0800)]
Follow-up to I05aacd30b: normalize case in User::idFromName
Change-Id: Ibeef04093338bfef8e65f40b1f9db588c8d5a79d
jenkins-bot [Wed, 19 Nov 2014 04:01:58 +0000 (04:01 +0000)]
Merge "Omit 'window.' when accessing browsing location"
jenkins-bot [Wed, 19 Nov 2014 04:01:50 +0000 (04:01 +0000)]
Merge "Expose ID of relevant page in JS variables"
jenkins-bot [Wed, 19 Nov 2014 02:06:00 +0000 (02:06 +0000)]
Merge "Don't re-apply EXIF rotation to chained thumbnails"
Timo Tijhof [Wed, 19 Nov 2014 00:11:04 +0000 (00:11 +0000)]
Omit 'window.' when accessing browsing location
The location object is a global, just like document.
Using it via 'window' needlessly adds complexity and, for example,
makes it harder to catch typos in static analysis.
Also standardise on location.href in place of the many different
variants, like:
location =
location.href =
location.assign() =
And each with 'window', 'document' and without host object.
Change-Id: I77510294d8b5bd4b8a1b08e06817762a7839d43d
jenkins-bot [Tue, 18 Nov 2014 23:42:21 +0000 (23:42 +0000)]
Merge "Cleaned up template profile report tabbing"
Aaron Schulz [Tue, 18 Nov 2014 22:58:02 +0000 (14:58 -0800)]
Cleaned up template profile report tabbing
Change-Id: I46abfc856d718d4db73d0510bde3e2b589341b10
Aaron Schulz [Tue, 18 Nov 2014 22:27:44 +0000 (14:27 -0800)]
Placed ProfilerStandard logic directly into SectionProfiler
* The former class should eventually be removed
Change-Id: I4e6df3bd0c7047f5f5110e7f115b1cf6fad0316e
Chad Horohoe [Tue, 18 Nov 2014 22:02:32 +0000 (14:02 -0800)]
MW_NO_OUTPUT_BUFFER is never defined
It may have been defined at one time, but now it's just
function overhead to check on every request.
Change-Id: I05963a0e496e0a960a4feb6877a03e67c5a6fc85
jenkins-bot [Tue, 18 Nov 2014 20:56:11 +0000 (20:56 +0000)]
Merge "profiler: Simplify code for class name mapping"
jenkins-bot [Tue, 18 Nov 2014 20:48:19 +0000 (20:48 +0000)]
Merge "Fixed some incorrect Profiler comments"
jenkins-bot [Tue, 18 Nov 2014 20:47:34 +0000 (20:47 +0000)]
Merge "Use upsert() in ProfilerOutputDb"
Timo Tijhof [Tue, 18 Nov 2014 20:46:41 +0000 (20:46 +0000)]
profiler: Simplify code for class name mapping
Follows-up
000c6529d. Handle errors first.
Change-Id: I70308783a2e8b140b3c850758cce36544b32eb20
Aaron Schulz [Tue, 18 Nov 2014 20:39:01 +0000 (12:39 -0800)]
Fixed some incorrect Profiler comments
Change-Id: Ibadc9c7aa0e199e3bd0776a3d563fb6afc1ff7cd
Translation updater bot [Tue, 18 Nov 2014 20:11:54 +0000 (20:11 +0000)]
Merge "Localisation updates from https://translatewiki.net."
Aaron Schulz [Tue, 18 Nov 2014 20:06:05 +0000 (12:06 -0800)]
Use upsert() in ProfilerOutputDb
Change-Id: I807ee78c602b67c99530ecaab90af74410106fc7
Translation updater bot [Tue, 18 Nov 2014 20:05:56 +0000 (21:05 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I72e27a8e125fc604c5fe47f73b243b96b9b50cc6
jenkins-bot [Tue, 18 Nov 2014 20:02:06 +0000 (20:02 +0000)]
Merge "ProfilerOutput: Remove logStandardData() and make log() abstract"
Chad Horohoe [Tue, 18 Nov 2014 19:51:49 +0000 (11:51 -0800)]
ProfilerOutput: Remove logStandardData() and make log() abstract
Became unused layer of abtraction as I266ed820 went through iterations
Change-Id: Ic739fb4519bb2e23e679828b191c11c0158ade78
Brad Jorsch [Tue, 18 Nov 2014 19:33:09 +0000 (14:33 -0500)]
API: Recognize an "Api-User-Agent" header
XMLHttpRequest does not allow overriding the "User-Agent" header. To
allow such clients to make effective use of the api-feature-usage log,
let's give them a different header they can use.
Change-Id: Ia1e4f52f35f8d9a8e9f5590a00854d14c11f7cc9
Kunal Mehta [Tue, 18 Nov 2014 19:12:07 +0000 (11:12 -0800)]
Profiler: Explicitly convert output type to class name
Follows-up
b8d93fb4fd06.
Change-Id: I50faa25fdc4fb980e0ff71014b8d1b2a5818af80
jenkins-bot [Tue, 18 Nov 2014 19:01:41 +0000 (19:01 +0000)]
Merge "Refactor profiling output from profiling"
Bartosz Dziewoński [Tue, 18 Nov 2014 12:32:11 +0000 (13:32 +0100)]
mediawiki.action.history.diff: Rework print styles
* Remove extremely old print styles for diffs from commonPrint.css,
added back in r6970. These were created for the old yellow-green-red
diff styles and look terrible now.
* Add new, minimal print styles, that replace background colors with
text decoration (underline for inserted text, line-through for
deleted). Motivation is the same as in r6970: light colored backgrounds
work great on displays, but not very well in black-and-white print.
* Fixed diff styles demo (mediawiki.action.history.diff.html), updated
with print styles and better example.
Bug: 73544
Change-Id: Ibf08fa11f84ac0cf8c7ed4da8af2b8804de6ab6f
jenkins-bot [Tue, 18 Nov 2014 03:52:13 +0000 (03:52 +0000)]
Merge "filebackend: Log more details about backend-fail-internal errors"
Chad Horohoe [Fri, 14 Nov 2014 18:58:07 +0000 (10:58 -0800)]
Refactor profiling output from profiling
* Added a standard getFunctionStats() method for Profilers to return
per function data as maps. This is not toolbar specific like getRawData().
* Cleaned up the interface of SectionProfiler::getFunctionStats() a bit.
* Removed unused cpu_sq, real_sq fields from profiler UDP output.
* Moved getTime/getInitialTime to ProfilerStandard.
Co-Authored-By: Aaron Schulz <aschulz@wikimedia.org>
Change-Id: I266ed82031a434465f64896eb327f3872fdf1db1
Ori Livneh [Tue, 18 Nov 2014 01:52:20 +0000 (17:52 -0800)]
Avoid calling Title::makeTitleSafe in User::idFromName
We don't want to call Title::makeTitleSafe yet, since that call path
ends up needing the user language, which ends up trying to load the
user object, which ends up back in User::idFromName.
Bug: 54193
Change-Id: I05aacd30be66fe505b5c211113ea938fa82e2492
Roan Kattouw [Mon, 17 Nov 2014 23:49:37 +0000 (18:49 -0500)]
Update OOjs UI to v0.1.0-pre (
f1abca8e82)
New changes:
5883e65 Add 'indeterminate' state to progress bar widget
fbe9248 Fix documentation for getRelativeSelectableItem
27f8805 Localisation updates from https://translatewiki.net.
2edfdaa Localisation updates from https://translatewiki.net.
40d08f0 Localisation updates from https://translatewiki.net.
ce8438f Update OOjs to v1.1.3
5721411 Prepare repository for RuboCop
f1abca8 Followup
ca6a16f: use parent selector both for hiding and showing windows
Change-Id: I7b49bbc81e9b8ba501f0593daaacf7025f16bf00
Gilles Dubuc [Mon, 17 Nov 2014 18:05:52 +0000 (19:05 +0100)]
filebackend: Log more details about backend-fail-internal errors
Bug: 73094
Change-Id: I9e45284e3cfd55bc34d87009387a2c1766e2db4a
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/991
Translation updater bot [Mon, 17 Nov 2014 20:54:11 +0000 (21:54 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I2e0ff8b47f799752f656915729510dad81c00d4a
James D. Forrester [Mon, 17 Nov 2014 19:26:17 +0000 (11:26 -0800)]
Update OOjs to v1.1.3
Release notes:
https://git.wikimedia.org/blob/oojs%2Fcore.git/v1.1.3/History.md
Change-Id: I1bd75ea6f259ca8b35ca8e379a443788d4642f28
Brad Jorsch [Mon, 17 Nov 2014 16:18:09 +0000 (11:18 -0500)]
API: Always request page_is_redirect from ApiQueryInfo
The ApiPageSet doesn't know for sure whether it will be resolving
redirects until it is executed, as the revids parameter may override
that (and it can't easily check before being executed because it might
never actually be executed). So ApiQueryInfo needs to just
unconditionally request page_is_redirect and only consider later whether
to try using it.
Bug: 73464
Change-Id: I2297158188dae5476c5b9b5755ea26cf5b8ae487
Chad Horohoe [Thu, 13 Nov 2014 19:14:37 +0000 (11:14 -0800)]
Remove profiler support from debugging toolbar
It never worked and creates extra dependencies on the profiler
Change-Id: I584c9e94d144baf48a654e23dd9f47690d94f13b
jdlrobson [Sun, 16 Nov 2014 19:16:10 +0000 (11:16 -0800)]
Hygiene: Update mixin file to use single line comments
Since these are not valid CSS they do not turn up in the output. This
makes debugging a lot easier as mixin files typically get included multiple
times across less files.
Change-Id: I5adacb277f18f782a8293285fd8f98e825f39734
Bryan Davis [Mon, 17 Nov 2014 17:32:45 +0000 (10:32 -0700)]
Prettier wfLogProfilingData() log message
Make the profiler logging output introduced in Iae11e1e a little nicer.
Stop adding the Profiler::getRawData() information and add the URL and
textual report to the default log message. When testing with a Monolog
logger and Logstash the getRawData output from the Xhprof profiler was
found to be too big to be usable. The default message output was found
to be less informative than desirable when a PSR-3 logger other than
MWLoggerLegacyLogger was used. MWLoggerLegacyLogger implements special
backwards compatible formatting for the profileoutput channel that will
not be effected by this change.
Change-Id: Id326aed4f72a3489fac30661c101ac3bb3af2530
jenkins-bot [Mon, 17 Nov 2014 17:05:58 +0000 (17:05 +0000)]
Merge "Consistently handle trailing slashes in subpage links."
Erik Bernhardson [Fri, 14 Nov 2014 19:00:36 +0000 (11:00 -0800)]
Doc: Mention the php command in autoload.php to regenerate it
Adds a comment to the top of the generated autoload.php directing
developers to the command to regenerate the file so they may just
copy and paste the command.
Change-Id: If098a1eb51ed732378677215c0e438c73d506697
Bartosz Dziewoński [Sun, 16 Nov 2014 19:18:00 +0000 (20:18 +0100)]
Standardize indentation of multiline 'if'/'elseif' conditions
Always indent the continuation one level deeper, and always place the
closing parenthesis on the next line, per coding conventions.
https://www.mediawiki.org/wiki/Manual:Coding_conventions#Indenting_and_alignment
https://www.mediawiki.org/wiki/Manual:Coding_conventions#Line_continuation
Regexp used: (\t+)(if|while|\} elseif|foreach).+(?<![;}])\n\1\S
Also:
* Change to just one line if line length stays under 100 characters.
* Add "// Do nothing" comment in empty 'if' bodies.
* Change '#' comments to '//' comments near affected code.
Change-Id: I4f62658fddb5a0ed18bbf9b2231cd794683d6402
jenkins-bot [Mon, 17 Nov 2014 10:49:38 +0000 (10:49 +0000)]
Merge "Keep buttons from changing size when they change state"
jenkins-bot [Mon, 17 Nov 2014 09:27:39 +0000 (09:27 +0000)]
Merge "WebInstallerOutput: Apply wfBCP47() to lang attribute"
jenkins-bot [Sun, 16 Nov 2014 23:48:45 +0000 (23:48 +0000)]
Merge "Allow maxlength attribute on HTMLSelectAndOtherField"
Translation updater bot [Sun, 16 Nov 2014 21:10:30 +0000 (22:10 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I3cc1a14ecadf25d0abb58fbaa9d464bb6b6af9dd
umherirrender [Sat, 26 Jul 2014 21:56:37 +0000 (23:56 +0200)]
Allow maxlength attribute on HTMLSelectAndOtherField
A reason on a SelectAndOtherField can have two parts, one of the scroll
down box and a free text field. The free text field is actually
unlimited.
This patch allows the maxlength on that field. To respect the concat of
the two parts, also javascript code is added, which adds a dynamic
maxlength to respect also the text from the scroll down box.
The HTMLSelectAndOtherField is only used on Special:Block,
where the maxlength attribute is now set to 255 (length of the database
field ipb_reason).
Change-Id: I5c164b41ab047e7ecf9d92db6eddcc980e2db048
Bartosz Dziewoński [Fri, 7 Nov 2014 19:21:58 +0000 (20:21 +0100)]
CSSMin: Rewrite encodeImageAsDataURI()
* Make it actually check against the URI length, not file size.
Previous code could produce URIs that edged just over the limit.
* Replace $sizeLimit parameter with $ie8Compat, because that's the
only use case and the file size limit approach was flawed per above,
anyway.
* Remove CSSMin::EMBED_SIZE_LIMIT constant, which is not used anymore.
CSSMin::DATA_URI_SIZE_LIMIT still exists.
* Change code flow to avoid repetition.
* Split off new method, encodeStringAsDataURI(), that does actual
encoding rather than file handling.
Change-Id: I3704404ce831d7e0f6e3a65f23c76f313ad13238
Timo Tijhof [Sun, 16 Nov 2014 11:49:25 +0000 (12:49 +0100)]
MWException: Log stack traces for php errors (not exceptions)
* Remove use of 'error' where it's redundant.
* Remove call to logException from responsibility of MWException.
Call from exception handler instead.
Change-Id: I8764cf5df87b226813c9b9cf99f9b4f3fa4b7c92
jenkins-bot [Sun, 16 Nov 2014 09:43:27 +0000 (09:43 +0000)]
Merge "doc: raise doxygen lookup cache"
umherirrender [Mon, 3 Nov 2014 16:39:45 +0000 (17:39 +0100)]
Use correct case of function ImageGallery::toHTML
Change-Id: I8040c02618a58bb8840658bb7a5c697766c77d2d
umherirrender [Fri, 26 Sep 2014 17:31:51 +0000 (19:31 +0200)]
Remove LinkSearchPage::doQuery override
It is not called and not working, because it missed return statements.
The validation check is done in getQueryInfo and the message is added in
execute, when needed.
Change-Id: I9acbd2f09a922d5a7d66e8ce55e8d24ae65ab560
Kevin Israel [Fri, 14 Nov 2014 23:33:04 +0000 (18:33 -0500)]
AutoloadGenerator: Add newline at end of output file
Change-Id: I2b5a1adc115afd9430c1ea91285516c9c4290875
Translation updater bot [Sat, 15 Nov 2014 21:41:20 +0000 (21:41 +0000)]
Merge "Localisation updates from https://translatewiki.net."
Translation updater bot [Sat, 15 Nov 2014 21:31:09 +0000 (22:31 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I15904e6e70bb623ae6c5259ce2e37ccb5d61c9dd
umherirrender [Thu, 13 Nov 2014 18:43:06 +0000 (19:43 +0100)]
Set default value for $wgSharedSchema
Was added in I25df82065a307b9abc30c694f8c8afff0996d7c1 back in REL1_23
Change-Id: I291e770861751e037befe1db004e5e3f8b449f6c
umherirrender [Mon, 25 Aug 2014 18:12:27 +0000 (20:12 +0200)]
Simplify checks on Special:UserLogin/signup
I27c488e4008a924117ff6bac2216f148cd5e7abd changed the validation code in
User::getCanonicalName, the # and Title::makeTitleSafe checks now done
there and can be removed here.
Follow-Up: I27c488e4008a924117ff6bac2216f148cd5e7abd
Follow-Up: I88c479cea2bc9d2eab882e0ee8ebcbe2d1dd125e
Follow-Up: I983e3f528491817f9f31f71a92d8d2946ce5941d
Change-Id: I17bf88be6398dc402295264ca9bfd57809c872d7
jenkins-bot [Sat, 15 Nov 2014 16:44:39 +0000 (16:44 +0000)]
Merge "Increase QUnit.config.testTimeout to 30s"
Erik Bernhardson [Thu, 13 Nov 2014 22:31:19 +0000 (14:31 -0800)]
Increase QUnit.config.testTimeout to 30s
The default value of 10s is ocasionally failing when loading resources
via RL. Increase to 30s as suggested in the qunit documentation.
http://api.qunitjs.com/QUnit.config/#config-testTimeout
Change-Id: I288db068c8dd1041e0a9be959b3b0c6ddcc7606e
Siebrand Mazeland [Fri, 14 Nov 2014 12:35:54 +0000 (13:35 +0100)]
Update "apihelp-upload-param-stash"
Per suggestion by Lokal Profil at
https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Apihelp-upload-param-stash/sv
Change-Id: I377fb210ee191deab612a156268eca57c6746337
jenkins-bot [Fri, 14 Nov 2014 23:41:46 +0000 (23:41 +0000)]
Merge "generateLocalAutoload.php: Abort for web requests"
Kevin Israel [Fri, 14 Nov 2014 22:27:16 +0000 (17:27 -0500)]
generateLocalAutoload.php: Abort for web requests
The Maintenance class already does this, though this script does not use it
for the obvious reason that when there is a missing or incorrect autoloader
entry, it may not be possible to initialize MediaWiki.
Hence it is necessary to do that explicitly in this script. Overwriting
autoload.php potentially could disrupt the operation of a production wiki
(the file is truncated when it is opened).
Change-Id: I05d5d4b7c30c4643e71ca5819783627688e15da7
James D. Forrester [Mon, 10 Nov 2014 10:45:48 +0000 (10:45 +0000)]
mediawiki.skinning: Provide SVG version of the "magnify clip" icon
PNGs re-generated from the SVG.
Bug: 69705
Change-Id: Ica2e82598f545764a734399462231fe3c4ea7005
jenkins-bot [Fri, 14 Nov 2014 22:22:59 +0000 (22:22 +0000)]
Merge "Delete skins/common/images/bullet.gif"
jenkins-bot [Fri, 14 Nov 2014 22:22:51 +0000 (22:22 +0000)]
Merge "Delete skins/common/images/magnify-clip.png"
jenkins-bot [Fri, 14 Nov 2014 22:10:59 +0000 (22:10 +0000)]
Merge "Delete skins/common/{ajax.js, wikibits.js, images/{magnify-clip-rtl.png, redirectltr.png, redirectrtl.png}}"
C. Scott Ananian [Fri, 14 Nov 2014 21:38:04 +0000 (16:38 -0500)]
Consistently handle trailing slashes in subpage links.
The link text for [[/Foo/]] is `Foo` and the link text for
[[../Foo/]] is `Foo`. So far so good.
But the link text for [[/Foo//]] is `Foo` while the link text
for [[../Foo//]] is `Foo/`. We are stripping all trailing slashes
in the first case, but not the second.
Fix the code so that we strip all trailing slashes in both cases.
Update some of the comments in the code while we are at it.
Change-Id: Id61eacafea9820c404699a7902c8eb8102779516
Bartosz Dziewoński [Fri, 14 Nov 2014 21:56:59 +0000 (22:56 +0100)]
Delete skins/common/images/bullet.gif
There are still some requests for it per bug 69277 comment 90, but per
bug 69678 comment 12 all usages have been already removed.
This is the last file in the skins/common/ directory.
Bug: 69277
Change-Id: Id9de81d0efa91fa20dfd10d56a8ae814de43ff6e
Bartosz Dziewoński [Fri, 14 Nov 2014 21:27:37 +0000 (22:27 +0100)]
Delete skins/common/images/magnify-clip.png
There are still some requests for it per bug 69277 comment 90, but per
bug 69678 comment 10 all usages are forward-compatible or have been
already removed.
Bug: 69277
Change-Id: If6a16fb5aa5a826a58c8dec67e3583ccf12761e2
jenkins-bot [Fri, 14 Nov 2014 21:12:59 +0000 (21:12 +0000)]
Merge "mediawiki.special.changeslist.legend: Avoid legend as stairs"