From: addshore <addshorewiki@gmail.com>
Date: Tue, 21 Mar 2017 22:37:30 +0000 (+0000)
Subject: Cast to bool in Database::update
X-Git-Tag: 1.31.0-rc.0~3731^2
X-Git-Url: http://git.cyclocoop.org/%28?a=commitdiff_plain;h=fd84e8580fffd2a65b109364731fba678ec7c694;p=lhc%2Fweb%2Fwiklou.git

Cast to bool in Database::update

The interface is documented as returning a bool, so stick to that
interface.

Bug: T160956
Change-Id: I725651e1d66fdd6c52ef82e93fd9e3c837edb022
---

diff --git a/includes/libs/rdbms/database/Database.php b/includes/libs/rdbms/database/Database.php
index 90e60a322e..92adaf9ce6 100644
--- a/includes/libs/rdbms/database/Database.php
+++ b/includes/libs/rdbms/database/Database.php
@@ -1542,7 +1542,7 @@ abstract class Database implements IDatabase, IMaintainableDatabase, LoggerAware
 			$sql .= " WHERE " . $this->makeList( $conds, self::LIST_AND );
 		}
 
-		return $this->query( $sql, $fname );
+		return (bool)$this->query( $sql, $fname );
 	}
 
 	public function makeList( $a, $mode = self::LIST_COMMA ) {