From: Roan Kattouw <catrope@users.mediawiki.org>
Date: Fri, 9 May 2008 14:44:32 +0000 (+0000)
Subject: (bug 14021) Removing titles= support from list=backlinks, has been obsolete for ages... 
X-Git-Tag: 1.31.0-rc.0~47777
X-Git-Url: http://git.cyclocoop.org/%28?a=commitdiff_plain;h=dee7ab1a1a7b5dd97253619ecbd8308b6831f503;p=lhc%2Fweb%2Fwiklou.git

(bug 14021) Removing titles= support from list=backlinks, has been obsolete for ages (since July 2007)
---

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index cd67eb0229..e7b60484a0 100644
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -326,6 +326,7 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN
 * (bug 14013) Added rcshow=patrolled to list=recentchanges
 * (bug 14028) Added language attribute to interwiki map in meta=siteinfo
 * (bug 14022) Added usprop=registration and auprop=blockinfo
+* (bug 14021) Removed titles= support from list=backlinks (has been obsolete for ages)
 
 === Languages updated in 1.13 ===
 
diff --git a/includes/api/ApiQueryBacklinks.php b/includes/api/ApiQueryBacklinks.php
index 3b504ecbbd..6e0a58852a 100644
--- a/includes/api/ApiQueryBacklinks.php
+++ b/includes/api/ApiQueryBacklinks.php
@@ -260,20 +260,14 @@ class ApiQueryBacklinks extends ApiQueryGeneratorBase {
 	}
 
 	protected function processContinue() {
-		$pageSet = $this->getPageSet();
-		$count = $pageSet->getTitleCount();
-
 		if (!is_null($this->params['continue']))
 			$this->parseContinueParam();
 		else {
 			$title = $this->params['title'];
 			if (!is_null($title)) {
 				$this->rootTitle = Title :: newFromText($title);
-			} else {  // This case is obsolete. Will support this for a while
-				if ($count !== 1)
-					$this->dieUsage("The {$this->getModuleName()} query requires one title to start", 'bad_title_count');
-				$this->rootTitle = current($pageSet->getTitles()); // only one title there
-				$this->setWarning('Using titles parameter is obsolete for this list. Use ' . $this->encodeParamName('title') . ' instead.');
+			} else {
+				$this->dieUsageMsg(array('missingparam', "title"));
 			}
 		}