From: Derick Alangi <alangiderick@gmail.com>
Date: Mon, 11 Mar 2019 09:34:23 +0000 (+0100)
Subject: ProtectionForm: Follow up on I167ae6300b37d4e9292
X-Git-Tag: 1.34.0-rc.0~2499^2
X-Git-Url: http://git.cyclocoop.org/%28?a=commitdiff_plain;h=c1e9a7c6df6f920345c9f120291047906e3a3d12;p=lhc%2Fweb%2Fwiklou.git

ProtectionForm: Follow up on I167ae6300b37d4e9292

Per code search string "\$this\-\>showLogExtract\( \$ou", method
is only called within the ProtectionForm class so can be safely
made private but there are methods with the same name in a class
like LogEventsList but do different things.

Inspired by @Thiemo's comment on I167ae6300b37d4e9292.

Change-Id: Ic4983ccffecc6285f848d6e926017c4c6df4855f
---

diff --git a/includes/ProtectionForm.php b/includes/ProtectionForm.php
index 0e18e46a3b..7972a1ebe4 100644
--- a/includes/ProtectionForm.php
+++ b/includes/ProtectionForm.php
@@ -623,9 +623,8 @@ class ProtectionForm {
 	 * Show protection long extracts for this page
 	 *
 	 * @param OutputPage $out
-	 * @private
 	 */
-	function showLogExtract( OutputPage $out ) {
+	private function showLogExtract( OutputPage $out ) {
 		# Show relevant lines from the protection log:
 		$protectLogPage = new LogPage( 'protect' );
 		$out->addHTML( Xml::element( 'h2', null, $protectLogPage->getName()->text() ) );