From: Alexandre Emsenhuber <ialex.wiki@gmail.com>
Date: Wed, 4 Jul 2012 08:55:09 +0000 (+0200)
Subject: No need to wrap the result of DatabaseBase::select() in a ResultWrapper object.
X-Git-Tag: 1.31.0-rc.0~23147^2
X-Git-Url: http://git.cyclocoop.org/%28?a=commitdiff_plain;h=c0ea2e70fc5b6565682735a3de7f5ad52aca50cc;p=lhc%2Fweb%2Fwiklou.git

No need to wrap the result of DatabaseBase::select() in a ResultWrapper object.

Change-Id: I2cceb363b4573a850a7a63c93d2ca9899e477a7f
DatabaseBase::select() already returns a ResultWrapper object, so its useless to wrap it again.
---

diff --git a/includes/Pager.php b/includes/Pager.php
index 9d1f9fcb7e..750636d0bb 100644
--- a/includes/Pager.php
+++ b/includes/Pager.php
@@ -306,8 +306,7 @@ abstract class IndexPager extends ContextSource implements Pager {
 	 */
 	public function reallyDoQuery( $offset, $limit, $descending ) {
 		list( $tables, $fields, $conds, $fname, $options, $join_conds ) = $this->buildQueryInfo( $offset, $limit, $descending );
-		$result = $this->mDb->select( $tables, $fields, $conds, $fname, $options, $join_conds );
-		return new ResultWrapper( $this->mDb, $result );
+		return $this->mDb->select( $tables, $fields, $conds, $fname, $options, $join_conds );
 	}
 
 	/**