From: Brion Vibber <brion@users.mediawiki.org>
Date: Fri, 9 Sep 2011 18:43:37 +0000 (+0000)
Subject: Followup r87986: qunit test case for bug 30825
X-Git-Tag: 1.31.0-rc.0~27762
X-Git-Url: http://git.cyclocoop.org/%28?a=commitdiff_plain;h=c0d4714fa5d095c7fa3ae24afc2ffe6536b05b0f;p=lhc%2Fweb%2Fwiklou.git

Followup r87986: qunit test case for bug 30825

jQuery's $.append() and friends go through some funky code paths which sometimes manually load <script> node contents via AJAX and eval them. That failed entirely in IE 7 if given a protocol-relative link ($wgServer = '//commons.wikimedia.org').
The fix in r87986 bypasses that by using DOM append directly on a script node, and thus fixes bug 30825 without even knowing it. :)

This test serves as a regression test.
---

diff --git a/tests/qunit/suites/resources/mediawiki/mediawiki.test.bug30825.js b/tests/qunit/suites/resources/mediawiki/mediawiki.test.bug30825.js
new file mode 100644
index 0000000000..bdf23344a7
--- /dev/null
+++ b/tests/qunit/suites/resources/mediawiki/mediawiki.test.bug30825.js
@@ -0,0 +1,2 @@
+start();
+ok( true, "Bug 30825 -- protocol-relative URL script load via mw.loader.load");
diff --git a/tests/qunit/suites/resources/mediawiki/mediawiki.test.js b/tests/qunit/suites/resources/mediawiki/mediawiki.test.js
index bae323f3bd..588b3d356e 100644
--- a/tests/qunit/suites/resources/mediawiki/mediawiki.test.js
+++ b/tests/qunit/suites/resources/mediawiki/mediawiki.test.js
@@ -169,6 +169,23 @@ test( 'mw.loader.bug29107' , function() {
 	});
 });
 
+test( 'mw.loader.bug30825', function() {
+	// This bug was actually already fixed in 1.18 and later when discovered in 1.17.
+	// Test is for regressions!
+
+	expect(1);
+
+	// Confirm that mw.loader.load() works with protocol-relative URLs
+	var loc = window.location,
+		base = ('//' + loc.hostname + loc.pathname).replace(/\/[^\/]*$/, ''),
+		target = base + '/suites/resources/mediawiki/mediawiki.test.bug30825.js';
+
+	// Async! Include a timeout, as failure in this test leads to neither the
+	// success nor failure callbacks getting called.
+	stop(5000);
+	mw.loader.load( target );
+});
+
 test( 'mw.html', function() {
 	expect(11);