From: Brion Vibber Date: Wed, 31 Dec 2008 22:12:09 +0000 (+0000) Subject: Revert r45197 "* Enable image moving by default. All known serious issues seem to... X-Git-Tag: 1.31.0-rc.0~43651 X-Git-Url: http://git.cyclocoop.org/%28?a=commitdiff_plain;h=be53330439b62e644b1475fbc240ac0ff5b312d8;p=lhc%2Fweb%2Fwiklou.git Revert r45197 "* Enable image moving by default. All known serious issues seem to be fixed." Don't want to do this just yet, we're in the middle of testing things. --- diff --git a/RELEASE-NOTES b/RELEASE-NOTES index 46642dc123..0e9559deac 100644 --- a/RELEASE-NOTES +++ b/RELEASE-NOTES @@ -255,7 +255,6 @@ The following extensions are migrated into MediaWiki 1.14: * Show subversion too even if a "normal" version number is available * (bug 16121) Add a note that a page move was without creating a redirect in the move log -* Image moving is now enabled for sysops by default === Bug fixes in 1.14 === diff --git a/includes/DefaultSettings.php b/includes/DefaultSettings.php index 695e38c28d..5dc785122d 100644 --- a/includes/DefaultSettings.php +++ b/includes/DefaultSettings.php @@ -1163,42 +1163,41 @@ $wgEmailConfirmToEdit=false; $wgGroupPermissions = array(); // Implicit group for all visitors -$wgGroupPermissions['*']['createaccount'] = true; -$wgGroupPermissions['*']['read'] = true; -$wgGroupPermissions['*']['edit'] = true; -$wgGroupPermissions['*']['createpage'] = true; -$wgGroupPermissions['*']['createtalk'] = true; -$wgGroupPermissions['*']['writeapi'] = true; +$wgGroupPermissions['*' ]['createaccount'] = true; +$wgGroupPermissions['*' ]['read'] = true; +$wgGroupPermissions['*' ]['edit'] = true; +$wgGroupPermissions['*' ]['createpage'] = true; +$wgGroupPermissions['*' ]['createtalk'] = true; +$wgGroupPermissions['*' ]['writeapi'] = true; // Implicit group for all logged-in accounts -$wgGroupPermissions['user']['move'] = true; -$wgGroupPermissions['user']['move-subpages'] = true; -$wgGroupPermissions['user']['move-rootuserpages'] = true; // can move root userpages -//$wgGroupPermissions['user']['movefile'] = true; // Disabled for now due to possible bugs and security concerns -$wgGroupPermissions['user']['read'] = true; -$wgGroupPermissions['user']['edit'] = true; -$wgGroupPermissions['user']['createpage'] = true; -$wgGroupPermissions['user']['createtalk'] = true; -$wgGroupPermissions['user']['writeapi'] = true; -$wgGroupPermissions['user']['upload'] = true; -$wgGroupPermissions['user']['reupload'] = true; -$wgGroupPermissions['user']['reupload-shared'] = true; -$wgGroupPermissions['user']['minoredit'] = true; -$wgGroupPermissions['user']['purge'] = true; // can use ?action=purge without clicking "ok" +$wgGroupPermissions['user' ]['move'] = true; +$wgGroupPermissions['user' ]['move-subpages'] = true; +$wgGroupPermissions['user' ]['move-rootuserpages'] = true; // can move root userpages +$wgGroupPermissions['user' ]['read'] = true; +$wgGroupPermissions['user' ]['edit'] = true; +$wgGroupPermissions['user' ]['createpage'] = true; +$wgGroupPermissions['user' ]['createtalk'] = true; +$wgGroupPermissions['user' ]['writeapi'] = true; +$wgGroupPermissions['user' ]['upload'] = true; +$wgGroupPermissions['user' ]['reupload'] = true; +$wgGroupPermissions['user' ]['reupload-shared'] = true; +$wgGroupPermissions['user' ]['minoredit'] = true; +$wgGroupPermissions['user' ]['purge'] = true; // can use ?action=purge without clicking "ok" // Implicit group for accounts that pass $wgAutoConfirmAge $wgGroupPermissions['autoconfirmed']['autoconfirmed'] = true; // Users with bot privilege can have their edits hidden // from various log pages by default -$wgGroupPermissions['bot']['bot'] = true; -$wgGroupPermissions['bot']['autoconfirmed'] = true; -$wgGroupPermissions['bot']['nominornewtalk'] = true; -$wgGroupPermissions['bot']['autopatrol'] = true; -$wgGroupPermissions['bot']['suppressredirect'] = true; -$wgGroupPermissions['bot']['apihighlimits'] = true; -$wgGroupPermissions['bot']['writeapi'] = true; -#$wgGroupPermissions['bot']['editprotected'] = true; // can edit all protected pages without cascade protection enabled +$wgGroupPermissions['bot' ]['bot'] = true; +$wgGroupPermissions['bot' ]['autoconfirmed'] = true; +$wgGroupPermissions['bot' ]['nominornewtalk'] = true; +$wgGroupPermissions['bot' ]['autopatrol'] = true; +$wgGroupPermissions['bot' ]['suppressredirect'] = true; +$wgGroupPermissions['bot' ]['apihighlimits'] = true; +$wgGroupPermissions['bot' ]['writeapi'] = true; +#$wgGroupPermissions['bot' ]['editprotected'] = true; // can edit all protected pages without cascade protection enabled // Most extra permission abilities go to this group $wgGroupPermissions['sysop']['block'] = true; @@ -1232,7 +1231,6 @@ $wgGroupPermissions['sysop']['markbotedits'] = true; $wgGroupPermissions['sysop']['apihighlimits'] = true; $wgGroupPermissions['sysop']['browsearchive'] = true; $wgGroupPermissions['sysop']['noratelimit'] = true; -$wgGroupPermissions['sysop']['movefile'] = true; #$wgGroupPermissions['sysop']['mergehistory'] = true; // Permission to change users' group assignments @@ -1670,8 +1668,8 @@ $wgAllowExternalImagesFrom = ''; */ $wgEnableImageWhitelist = true; -/** Allows to move images and other media files */ -$wgAllowImageMoving = true; +/** Allows to move images and other media files. Experemintal, not sure if it always works */ +$wgAllowImageMoving = false; /** Disable database-intensive features */ $wgMiserMode = false; diff --git a/includes/Title.php b/includes/Title.php index bc042210c0..122d5c2ecd 100644 --- a/includes/Title.php +++ b/includes/Title.php @@ -1222,10 +1222,6 @@ class Title { // Show user page-specific message only if the user can move other pages $errors[] = array( 'cant-move-user-page' ); } - // Check if user is allowed to move files if it's a file - if( $this->getNamespace() == NS_FILE && !$user->isAllowed( 'movefile' ) ) { - $errors[] = array( 'movenotallowedfile' ); - } // Check for immobile pages if( !MWNamespace::isMovable( $this->getNamespace() ) ) { // Specific message for this case diff --git a/includes/User.php b/includes/User.php index 4f36d14138..3a0023ada7 100644 --- a/includes/User.php +++ b/includes/User.php @@ -151,7 +151,6 @@ class User { 'markbotedits', 'minoredit', 'move', - 'movepage', 'move-rootuserpages', 'move-subpages', 'nominornewtalk', diff --git a/languages/messages/MessagesEn.php b/languages/messages/MessagesEn.php index 03da2742a3..00a2d0479d 100644 --- a/languages/messages/MessagesEn.php +++ b/languages/messages/MessagesEn.php @@ -1620,7 +1620,6 @@ please see math/README to configure.', 'right-move' => 'Move pages', 'right-move-subpages' => 'Move pages with their subpages', 'right-move-rootuserpages' => 'Move root user pages', -'right-movefile' => 'Move files', 'right-suppressredirect' => 'Not create a redirect from the old name when moving a page', 'right-upload' => 'Upload files', 'right-reupload' => 'Overwrite an existing file', @@ -2691,7 +2690,6 @@ In those cases, you will have to move or merge the page manually if desired.", 'movenologin' => 'Not logged in', 'movenologintext' => 'You must be a registered user and [[Special:UserLogin|logged in]] to move a page.', 'movenotallowed' => 'You do not have permission to move pages.', -'movenotallowedfile' => 'You do not have permission to move files.', 'cant-move-user-page' => 'You do not have permission to move user pages (apart from subpages).', 'cant-move-to-user-page' => 'You do not have permission to move a page to a user page (except to a user subpage).', 'newtitle' => 'To new title:',