From: Brion Vibber <brion@users.mediawiki.org>
Date: Wed, 19 Aug 2009 02:33:04 +0000 (+0000)
Subject: Revert r54585 "Fix bug 19261 by saving the username as the signature if it is submitt... 
X-Git-Tag: 1.31.0-rc.0~40214
X-Git-Url: http://git.cyclocoop.org/%28?a=commitdiff_plain;h=8737795ba0c14723cbbcc73df8cf89dc12162f74;p=lhc%2Fweb%2Fwiklou.git

Revert r54585 "Fix bug 19261 by saving the username as the signature if it is submitted empty"

Looks like the base problem is that empty is being interpreted as "put empty in the sig" instead of as "use default sig" at signature replacement time.
We shouldn't be saving the username into preferences if it hasn't been explicitly typed; if the user changes their name, they should automatically pick up the new value.
---

diff --git a/includes/Preferences.php b/includes/Preferences.php
index e4da11e205..9553a401ae 100644
--- a/includes/Preferences.php
+++ b/includes/Preferences.php
@@ -1121,9 +1121,6 @@ class Preferences {
 			// When no fancy sig used, make sure ~{3,5} get removed.
 			$signature = $wgParser->cleanSigInSig( $signature );
 		}
-		
-		global $wgUser;
-		if (!$signature) $signature = $wgUser->getName();
 
 		return $signature;
 	}