From: Tim Starling <tstarling@wikimedia.org>
Date: Wed, 1 Aug 2018 00:18:08 +0000 (+1000)
Subject: Fix total breakage of SQLite web upgrade
X-Git-Tag: 1.34.0-rc.0~4605
X-Git-Url: http://git.cyclocoop.org/%28?a=commitdiff_plain;h=7584bf22fb2bda3c66ecf50c1edaad904ee1a649;p=lhc%2Fweb%2Fwiklou.git

Fix total breakage of SQLite web upgrade

Partial revert of 8d61cf2793abd2, since LBFactoryTest.php passes without
overriding selectDB() in the current master. It's unclear why it was necessary.

Bug: T200861
Change-Id: I7c0560d7890616899297f81a227db98996d5cb7f
---

diff --git a/includes/libs/rdbms/database/DatabaseSqlite.php b/includes/libs/rdbms/database/DatabaseSqlite.php
index ca44572dd5..b0fd12a69c 100644
--- a/includes/libs/rdbms/database/DatabaseSqlite.php
+++ b/includes/libs/rdbms/database/DatabaseSqlite.php
@@ -220,10 +220,6 @@ class DatabaseSqlite extends Database {
 		return false;
 	}
 
-	public function selectDB( $db ) {
-		return false; // doesn't make sense
-	}
-
 	/**
 	 * @return string SQLite DB file path
 	 * @since 1.25