From: Brion Vibber <brion@users.mediawiki.org>
Date: Sun, 27 Nov 2005 09:53:13 +0000 (+0000)
Subject: * (bug 4090) Fix diff links in Special:Recentchangeslinked
X-Git-Tag: 1.6.0~1111
X-Git-Url: http://git.cyclocoop.org/%28?a=commitdiff_plain;h=72ad47d1831984885af4a233e604f6241b14625a;p=lhc%2Fweb%2Fwiklou.git

* (bug 4090) Fix diff links in Special:Recentchangeslinked
---

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index 93011b5c4d..7e5e4f4ddb 100644
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -257,6 +257,7 @@ fully support the editing toolbar, but was found to be too confusing.
 * Fix ulimit parameters for wfShellExec when memory_limit is specified in 'm'
 * (bug 3979) Save correct {{REVISIONID}} into parser cache on edit
 * Substitute {{REVISIONID}} correctly in diff display
+* (bug 4090) Fix diff links in Special:Recentchangeslinked
 
 
 === Caveats ===
diff --git a/includes/SpecialRecentchangeslinked.php b/includes/SpecialRecentchangeslinked.php
index 363c22f659..5ebaef7970 100644
--- a/includes/SpecialRecentchangeslinked.php
+++ b/includes/SpecialRecentchangeslinked.php
@@ -68,50 +68,58 @@ function wfSpecialRecentchangeslinked( $par = NULL ) {
 	if( $nt->getNamespace() == NS_CATEGORY ) {
 		$catkey = $dbr->addQuotes( $nt->getDBKey() );
 		$sql = "SELECT /* wfSpecialRecentchangeslinked */ 
-        			rc_cur_id page_id,
-        			rc_namespace page_namespace,
-        			rc_title page_title,
-        			rc_this_oldid rev_id,
-        			rc_user rev_user,
-        			rc_comment rev_comment,
-                 rc_user_text rev_user_text,
-        			rc_timestamp rev_timestamp,
-        			rc_minor rev_minor_edit,
-                 rc_new page_is_new
+        			rc_id,
+        			rc_cur_id,
+        			rc_namespace,
+        			rc_title,
+        			rc_this_oldid,
+        			rc_last_oldid,
+        			rc_user,
+        			rc_comment,
+                 	rc_user_text,
+        			rc_timestamp,
+        			rc_minor,
+					rc_new,
+					rc_patrolled,
+					rc_type
             FROM $categorylinks, $recentchanges
            WHERE rc_timestamp > '{$cutoff}'
              {$cmq}
              AND cl_from=rc_cur_id
              AND cl_to=$catkey
-        GROUP BY page_id,page_namespace,page_title,
-                 rev_user,rev_comment,rev_user_text,rev_timestamp,rev_minor_edit,
-                 page_is_new
-        ORDER BY rev_timestamp DESC
+        GROUP BY rc_cur_id,rc_namespace,rc_title,
+                 rc_user,rc_comment,rc_user_text,rc_timestamp,rc_minor,
+                 rc_new
+        ORDER BY rc_timestamp DESC
            LIMIT {$limit};
  ";
 	} else {
 		$sql =
 "SELECT /* wfSpecialRecentchangeslinked */ 
-			rc_cur_id page_id,
-			rc_namespace page_namespace,
-			rc_title page_title,
-         		rc_user rev_user,
-			rc_comment rev_comment,
-			rc_user_text rev_user_text,
+			rc_id,
+			rc_cur_id,
+			rc_namespace,
+			rc_title,
+         	rc_user,
+			rc_comment,
+			rc_user_text,
 			rc_this_oldid,
-			rc_timestamp rev_timestamp,
-			rc_minor rev_minor_edit,
-         rc_new page_is_new
+			rc_last_oldid,
+			rc_timestamp,
+			rc_minor,
+			rc_new,
+			rc_patrolled,
+			rc_type
     FROM $pagelinks, $recentchanges
    WHERE rc_timestamp > '{$cutoff}'
 	{$cmq}
      AND pl_namespace=rc_namespace
      AND pl_title=rc_title
      AND pl_from=$id
-GROUP BY page_id,page_namespace,page_title,
-         rev_user,rev_comment,rev_user_text,rev_timestamp,rev_minor_edit,
-         page_is_new
-ORDER BY rev_timestamp DESC
+GROUP BY rc_cur_id,rc_namespace,rc_title,
+         rc_user,rc_comment,rc_user_text,rc_timestamp,rc_minor,
+         rc_new
+ORDER BY rc_timestamp DESC
    LIMIT {$limit}";
 	}
 	$res = $dbr->query( $sql, $fname );
@@ -136,7 +144,7 @@ ORDER BY rev_timestamp DESC
 		$obj = $dbr->fetchObject( $res );
 		--$count;
 
-		$rc = RecentChange::newFromCurRow( $obj );
+		$rc = RecentChange::newFromRow( $obj );
 		$rc->counter = $counter++;
 		$s .= $list->recentChangesLine( $rc );
 		--$limit;