From: Brion Vibber <brion@users.mediawiki.org>
Date: Fri, 22 Apr 2005 02:56:26 +0000 (+0000)
Subject: Remove reference parameters on make*LinkObj() methods. They're unnecessary and PHP5... 
X-Git-Tag: 1.5.0alpha1~186
X-Git-Url: http://git.cyclocoop.org/%28?a=commitdiff_plain;h=197e4592fba04a07851d6dc68a42f8497f2f845c;p=lhc%2Fweb%2Fwiklou.git

Remove reference parameters on make*LinkObj() methods. They're unnecessary and PHP5 is pickier about what it lets you pass that way. (Besides they're passed as normal references on PHP5 anyway.)
---

diff --git a/includes/Linker.php b/includes/Linker.php
index f89a92020b..70d8e78d27 100644
--- a/includes/Linker.php
+++ b/includes/Linker.php
@@ -264,7 +264,7 @@ class Linker {
 	/**
 	 * Pass a title object, not a title string
 	 */
-	function makeKnownLinkObj( &$nt, $text = '', $query = '', $trail = '', $prefix = '' , $aprops = '' ) {
+	function makeKnownLinkObj( $nt, $text = '', $query = '', $trail = '', $prefix = '' , $aprops = '' ) {
 		global $wgOut, $wgTitle, $wgInputEncoding;
 
 		$fname = 'Skin::makeKnownLinkObj';
@@ -310,7 +310,7 @@ class Linker {
 	/**
 	 * Pass a title object, not a title string
 	 */
-	function makeBrokenLinkObj( &$nt, $text = '', $query = '', $trail = '', $prefix = '' ) {
+	function makeBrokenLinkObj( $nt, $text = '', $query = '', $trail = '', $prefix = '' ) {
 		# Fail gracefully
 		if ( ! isset($nt) ) {
 			# wfDebugDieBacktrace();
@@ -348,7 +348,7 @@ class Linker {
 	/**
  	 * Pass a title object, not a title string
 	 */
-	function makeStubLinkObj( &$nt, $text = '', $query = '', $trail = '', $prefix = '' ) {
+	function makeStubLinkObj( $nt, $text = '', $query = '', $trail = '', $prefix = '' ) {
 		$link = $nt->getPrefixedURL();
 
 		$u = $nt->escapeLocalURL( $query );
@@ -370,7 +370,7 @@ class Linker {
 	}
 
 	/** @todo document */
-	function makeSelfLinkObj( &$nt, $text = '', $query = '', $trail = '', $prefix = '' ) {
+	function makeSelfLinkObj( $nt, $text = '', $query = '', $trail = '', $prefix = '' ) {
 		$u = $nt->escapeLocalURL( $query );
 		if ( '' == $text ) {
 			$text = htmlspecialchars( $nt->getPrefixedText() );