From: Timo Tijhof <krinklemail@gmail.com>
Date: Wed, 30 May 2018 22:09:40 +0000 (+0100)
Subject: resourceloader: Re-enable testGetBlobCached() test case
X-Git-Tag: 1.34.0-rc.0~5127^2
X-Git-Url: http://git.cyclocoop.org/%28?a=commitdiff_plain;h=16663db53a4c7319c0ffdc64a2ef3809129cd28f;p=lhc%2Fweb%2Fwiklou.git

resourceloader: Re-enable testGetBlobCached() test case

Unable to reproduce the failure locally with Quibble.

The failure never made sense to begin with, as the only thing I could
conclude after ruling out all other possibilities was that PHP was
somehow forgetting/losing a key in a plain array in HashBagOStuff.

Bug: T176097
Change-Id: Ia438d5a929d7bd5dccf09387980ba92207616db0
---

diff --git a/tests/phpunit/includes/resourceloader/MessageBlobStoreTest.php b/tests/phpunit/includes/resourceloader/MessageBlobStoreTest.php
index 4d98773890..fa4d804ee8 100644
--- a/tests/phpunit/includes/resourceloader/MessageBlobStoreTest.php
+++ b/tests/phpunit/includes/resourceloader/MessageBlobStoreTest.php
@@ -103,11 +103,6 @@ class MessageBlobStoreTest extends PHPUnit\Framework\TestCase {
 		$this->assertEquals( '{"foo":"Example"}', $blob, 'Generated blob' );
 	}
 
-	/**
-	 * Seems to fail sometimes (T176097).
-	 *
-	 * @group Broken
-	 */
 	public function testGetBlobCached() {
 		$module = $this->makeModule( [ 'example' ] );
 		$rl = new ResourceLoader();