Remove pass-by-reference from WikiExporter constructor
authorumherirrender <umherirrender_de.wp@web.de>
Sun, 23 Sep 2012 18:53:30 +0000 (20:53 +0200)
committerumherirrender <umherirrender_de.wp@web.de>
Sun, 23 Sep 2012 18:53:30 +0000 (20:53 +0200)
The pass-by-reference is a left over from PHP 4 times.

This avoids:
Strict Standards: Only variables should be passed by reference in
\includes\api\ApiQuery.php on line 523

Change-Id: I8c9afcd9f7631bbb0bdb9ea608339bbbd5726a26

includes/Export.php

index f01fb23..c2409de 100644 (file)
@@ -83,9 +83,9 @@ class WikiExporter {
         * @param $buffer Int: one of WikiExporter::BUFFER or WikiExporter::STREAM
         * @param $text Int: one of WikiExporter::TEXT or WikiExporter::STUB
         */
-       function __construct( &$db, $history = WikiExporter::CURRENT,
+       function __construct( $db, $history = WikiExporter::CURRENT,
                        $buffer = WikiExporter::BUFFER, $text = WikiExporter::TEXT ) {
-               $this->db =& $db;
+               $this->db = $db;
                $this->history = $history;
                $this->buffer  = $buffer;
                $this->writer  = new XmlDumpWriter();