Remove FormSpecialPage::$fields

Just use the result of FormSpecialPage::getFormFields() directly

Change-Id: I2f6f8e20b83a24e744ab4c6ea5417d9627a3e0aa

diff --git a/includes/specialpage/FormSpecialPage.php b/includes/specialpage/FormSpecialPage.php
index 21e465a..9056761 100644 (file)
--- a/includes/specialpage/FormSpecialPage.php
+++ b/includes/specialpage/FormSpecialPage.php
@@ -89,11 +89,9 @@ abstract class FormSpecialPage extends SpecialPage {
         * @return HTMLForm|null
         */
        protected function getForm() {
-               $this->fields = $this->getFormFields();
-
                $form = HTMLForm::factory(
                        $this->getDisplayFormat(),
-                       $this->fields,
+                       $this->getFormFields(),
                        $this->getContext(),
                        $this->getMessagePrefix()
                );