Merge "Fix warning on Special:ListGroupRights for group with invalid group page"
authorjenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Mon, 29 Dec 2014 20:47:46 +0000 (20:47 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Mon, 29 Dec 2014 20:47:46 +0000 (20:47 +0000)
includes/specials/SpecialListgrouprights.php

index 8b9a0ee..828a93b 100644 (file)
@@ -86,13 +86,14 @@ class SpecialListGroupRights extends SpecialPage {
                        $grouppageLocalized = !$msg->isBlank() ?
                                $msg->text() :
                                MWNamespace::getCanonicalName( NS_PROJECT ) . ':' . $groupname;
+                       $grouppageLocalizedTitle = Title::newFromText( $grouppageLocalized );
 
-                       if ( $group == '*' ) {
-                               // Do not make a link for the generic * group
+                       if ( $group == '*' || !$grouppageLocalizedTitle ) {
+                               // Do not make a link for the generic * group or group with invalid group page
                                $grouppage = htmlspecialchars( $groupnameLocalized );
                        } else {
                                $grouppage = Linker::link(
-                                       Title::newFromText( $grouppageLocalized ),
+                                       $grouppageLocalizedTitle,
                                        htmlspecialchars( $groupnameLocalized )
                                );
                        }