Revert r44292 "Assign by ref to make sure cache fields carry over"

This isn't PHP 4; the object's fields are changed on the object itself just fine. Unless people are changing the global variable $wgTitle to something different this should be fine. If there is a problem that this fixes, that's probably a problem itself and should be fixed in a cleaner way :D

diff --git a/includes/Skin.php b/includes/Skin.php
index d02c077..03d6dd2 100644 (file)
--- a/includes/Skin.php
+++ b/includes/Skin.php
@@ -266,7 +266,7 @@ class Skin extends Linker {
 
        function setMembers(){
                global $wgTitle, $wgUser;
-               $this->mTitle =& $wgTitle;
+               $this->mTitle = $wgTitle;
                $this->mUser = $wgUser;
                $this->userpage = $wgUser->getUserPage()->getPrefixedText();
                $this->usercss = false;