ContribsPager: Fix slow queries

[lhc/web/wiklou.git] / tests / phpunit / includes / specials / ContribsPagerTest.php

diff --git a/tests/phpunit/includes/specials/ContribsPagerTest.php b/tests/phpunit/includes/specials/ContribsPagerTest.php
index d7fc13d..e881611 100644 (file)
--- a/tests/phpunit/includes/specials/ContribsPagerTest.php
+++ b/tests/phpunit/includes/specials/ContribsPagerTest.php
@@ -1,15 +1,31 @@
 <?php
 
+use Wikimedia\TestingAccessWrapper;
+
 /**
  * @group Database
  */
-class ContribsPagerTest extends \PHPUnit_Framework_TestCase {
+class ContribsPagerTest extends MediaWikiTestCase {
+       /** @var ContribsPager */
+       private $pager;
+
+       function setUp() {
+               $context = new RequestContext();
+               $this->pager = new ContribsPager( $context, [
+                       'start' => '2017-01-01',
+                       'end' => '2017-02-02',
+               ] );
+
+               parent::setUp();
+       }
+
        /**
+        * @covers ContribsPager::processDateFilter
         * @dataProvider dateFilterOptionProcessingProvider
         * @param array $inputOpts Input options
         * @param array $expectedOpts Expected options
         */
-       public function testDateFilterOptionProcessing( $inputOpts, $expectedOpts ) {
+       public function testDateFilterOptionProcessing( array $inputOpts, array $expectedOpts ) {
                $this->assertArraySubset( $expectedOpts, ContribsPager::processDateFilter( $inputOpts ) );
        }
 
@@ -47,4 +63,102 @@ class ContribsPagerTest extends \PHPUnit_Framework_TestCase {
                                'end' => '2012-12-31' ] ],
                ];
        }
+
+       /**
+        * @covers ContribsPager::isQueryableRange
+        * @dataProvider provideQueryableRanges
+        */
+       public function testQueryableRanges( $ipRange ) {
+               $this->setMwGlobals( [
+                       'wgRangeContributionsCIDRLimit' => [
+                               'IPv4' => 16,
+                               'IPv6' => 32,
+                       ],
+               ] );
+
+               $this->assertTrue(
+                       $this->pager->isQueryableRange( $ipRange ),
+                       "$ipRange is a queryable IP range"
+               );
+       }
+
+       public function provideQueryableRanges() {
+               return [
+                       [ '116.17.184.5/32' ],
+                       [ '0.17.184.5/16' ],
+                       [ '2000::/32' ],
+                       [ '2001:db8::/128' ],
+               ];
+       }
+
+       /**
+        * @covers ContribsPager::isQueryableRange
+        * @dataProvider provideUnqueryableRanges
+        */
+       public function testUnqueryableRanges( $ipRange ) {
+               $this->setMwGlobals( [
+                       'wgRangeContributionsCIDRLimit' => [
+                               'IPv4' => 16,
+                               'IPv6' => 32,
+                       ],
+               ] );
+
+               $this->assertFalse(
+                       $this->pager->isQueryableRange( $ipRange ),
+                       "$ipRange is not a queryable IP range"
+               );
+       }
+
+       public function provideUnqueryableRanges() {
+               return [
+                       [ '116.17.184.5/33' ],
+                       [ '0.17.184.5/15' ],
+                       [ '2000::/31' ],
+                       [ '2001:db8::/9999' ],
+               ];
+       }
+
+       /**
+        * @covers \ContribsPager::getExtraSortFields
+        * @covers \ContribsPager::getIndexField
+        * @covers \ContribsPager::getQueryInfo
+        */
+       public function testUniqueSortOrderWithoutIpChanges() {
+               $pager = new ContribsPager( new RequestContext(), [
+                       'start' => '',
+                       'end' => '',
+               ] );
+
+               /** @var ContribsPager $pager */
+               $pager = TestingAccessWrapper::newFromObject( $pager );
+               $queryInfo = $pager->buildQueryInfo( '', 1, false );
+
+               $this->assertNotContains( 'ip_changes', $queryInfo[0] );
+               $this->assertArrayNotHasKey( 'ip_changes', $queryInfo[5] );
+               $this->assertContains( 'rev_timestamp', $queryInfo[1] );
+               $this->assertContains( 'rev_id', $queryInfo[1] );
+               $this->assertSame( [ 'rev_timestamp DESC', 'rev_id DESC' ], $queryInfo[4]['ORDER BY'] );
+       }
+
+       /**
+        * @covers \ContribsPager::getExtraSortFields
+        * @covers \ContribsPager::getIndexField
+        * @covers \ContribsPager::getQueryInfo
+        */
+       public function testUniqueSortOrderOnIpChanges() {
+               $pager = new ContribsPager( new RequestContext(), [
+                       'target' => '116.17.184.5/32',
+                       'start' => '',
+                       'end' => '',
+               ] );
+
+               /** @var ContribsPager $pager */
+               $pager = TestingAccessWrapper::newFromObject( $pager );
+               $queryInfo = $pager->buildQueryInfo( '', 1, false );
+
+               $this->assertContains( 'ip_changes', $queryInfo[0] );
+               $this->assertArrayHasKey( 'ip_changes', $queryInfo[5] );
+               $this->assertSame( [ 'ipc_rev_timestamp DESC', 'ipc_rev_id DESC' ], $queryInfo[4]['ORDER BY'] );
+       }
+
 }