Aaron Schulz [Mon, 18 Mar 2019 23:09:26 +0000 (16:09 -0700)]
Make BagOStuff::incr abstract to discourage bad implementations
Callers should really use atomic TTL-preserving implementations
so that calling code works correctly. The old default base class
code did not do either.
Change-Id: Icf66db05e48b86c8d481dc08dc9041bd1fa6dbe9
jenkins-bot [Mon, 18 Mar 2019 01:07:10 +0000 (01:07 +0000)]
Merge "Password: update documentation"
Translation updater bot [Sun, 17 Mar 2019 20:54:44 +0000 (21:54 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I2d4ac09f82c79444730cf9cf0c8f01fc5109b917
Max Semenik [Sun, 17 Mar 2019 19:44:19 +0000 (12:44 -0700)]
Password: update documentation
Change-Id: Ifd7afc48e301a7985c2dd9134a7ea75af9bfeb4b
jenkins-bot [Sun, 17 Mar 2019 18:49:05 +0000 (18:49 +0000)]
Merge "Make LinkCache::isCacheable include namespaces like NS_CATEGORY/NS_MODULE"
jenkins-bot [Sun, 17 Mar 2019 16:33:19 +0000 (16:33 +0000)]
Merge "Advertise feeds only if $wgFeed is enabled"
RazeSoldier [Sun, 18 Feb 2018 17:31:29 +0000 (01:31 +0800)]
runJobs.php output something when the job queue is empty
If the job queue is empty, output "Job queue is empty."
Bug: T187628
Change-Id: I7d0925bd2995526b1a67148096e9543766a62da7
saper [Sun, 28 Jan 2018 02:21:51 +0000 (03:21 +0100)]
Advertise feeds only if $wgFeed is enabled
Wikis with $wgFeed=false should not present an Atom icon on the RecentChanges/Watchlist.
Bug: T116145
Change-Id: Ic64f7f5115a77c42ed2b336f6996fe711b3822ba
jenkins-bot [Sat, 16 Mar 2019 22:54:32 +0000 (22:54 +0000)]
Merge "RELEASE-NOTES: Make more consistent and useful for sysadmins"
jenkins-bot [Sat, 16 Mar 2019 22:12:55 +0000 (22:12 +0000)]
Merge "Various fixes for phan-taint-check"
jenkins-bot [Sat, 16 Mar 2019 22:03:25 +0000 (22:03 +0000)]
Merge "ProtectionForm: Follow up on I167ae6300b37d4e9292"
jenkins-bot [Sat, 16 Mar 2019 21:23:36 +0000 (21:23 +0000)]
Merge "rdbms: improve database connection loss handling"
James D. Forrester [Fri, 15 Mar 2019 00:58:24 +0000 (17:58 -0700)]
RELEASE-NOTES: Make more consistent and useful for sysadmins
* Move the "upgrading" bit further up, and put the notes specific
to upgrading inside it.
* Word all configuration changes to start with the $wg… – rubric
so they're easy to spot.
* Be explicit when new configuration options are temporary.
* Split user and developer features. Sysadmin features are what
the "Configuration changes" section is for, so spell that out.
Change-Id: Id12ced8bb764f2c3945c14799d63c17e2711c6f6
Brian Wolff [Sun, 17 Feb 2019 11:47:41 +0000 (11:47 +0000)]
Various fixes for phan-taint-check
Change-Id: I56f42ef2d2e9b4f3c23e1e93d1a4d3db64f16de7
Derick Alangi [Mon, 11 Mar 2019 09:34:23 +0000 (10:34 +0100)]
ProtectionForm: Follow up on I167ae6300b37d4e9292
Per code search string "\$this\-\>showLogExtract\( \$ou", method
is only called within the ProtectionForm class so can be safely
made private but there are methods with the same name in a class
like LogEventsList but do different things.
Inspired by @Thiemo's comment on I167ae6300b37d4e9292.
Change-Id: Ic4983ccffecc6285f848d6e926017c4c6df4855f
Jack Phoenix [Fri, 15 Mar 2019 23:13:36 +0000 (01:13 +0200)]
Code style tweaks
Change-Id: I2c602ba642e5692e6c56817aac89be9058bf5bdb
Aaron Schulz [Thu, 14 Mar 2019 06:44:38 +0000 (23:44 -0700)]
Make LinkCache::isCacheable include namespaces like NS_CATEGORY/NS_MODULE
Category and module pages are some of the most frequently referenced
Change-Id: I6d29e883883cbea596b287494e75663d09130749
jenkins-bot [Sat, 16 Mar 2019 03:03:28 +0000 (03:03 +0000)]
Merge "User: Remove redundant wgClockSkewFudge code"
jenkins-bot [Sat, 16 Mar 2019 03:01:28 +0000 (03:01 +0000)]
Merge "Remove wgSitesCacheFile and rebuildSitesCache.php (unused)"
jenkins-bot [Fri, 15 Mar 2019 23:17:41 +0000 (23:17 +0000)]
Merge "Localisation updates from https://translatewiki.net."
jenkins-bot [Fri, 15 Mar 2019 23:11:11 +0000 (23:11 +0000)]
Merge "Make EditPage::getTemplates avoid page table query spam"
jenkins-bot [Fri, 15 Mar 2019 22:57:31 +0000 (22:57 +0000)]
Merge "rdbms: lower the log channel severity of LoadMonitor::getServerStates"
jenkins-bot [Fri, 15 Mar 2019 22:03:29 +0000 (22:03 +0000)]
Merge "Remove empty and unnecessary /* @{{ … */ comments"
jenkins-bot [Fri, 15 Mar 2019 21:46:07 +0000 (21:46 +0000)]
Merge "Fix WatchedItemStore last-seen stashing logic"
Translation updater bot [Fri, 15 Mar 2019 21:05:39 +0000 (22:05 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I910aa8cc077a12f2a7ef00f41087f5c3e08ab0d4
Timo Tijhof [Fri, 15 Mar 2019 00:05:52 +0000 (00:05 +0000)]
User: Remove redundant wgClockSkewFudge code
Ensuring the new value is at least as high as 1 second higher
than the current value is sufficient.
The main code paths using this are checkAndSetTouched (for user group
changes) and saveSettings(), both of which use makeUpdateConditions() which
ensures we bail out if something else already wrote to it in the mean time.
As such, there is no longer a need to make sure our time is higher than
something another server may have written, given that is no longer something
we support.
This variable was introduced in 2005 (MW 1.4) with r9403 (
1d12276bcb3),
and factored out as newTouchedTimestamp() in 2007 (MW 1.8)
with r16772 (
c1094ba9876).
Change-Id: I940fb0dd125286a4a348c11e2c8d197f9288a75d
Timo Tijhof [Thu, 14 Mar 2019 19:46:19 +0000 (19:46 +0000)]
Remove wgSitesCacheFile and rebuildSitesCache.php (unused)
This seems to have been intended as optimization for SiteStore,
but was never used as far as I can tell. Instead, SiteStore is
already cached via LocalServerCache (APC).
Keep the FileBasedSiteLookup class for one release cycle in case
third parties not indexed by MediaWiki Codesearch are using it.
== History
* 2013: Report of high memcached usage by Wikibase via SiteStore.
* 2014: Lazy-load the data in Wikibase (
d3f2e99cb6).
* 2014: Implement the file-based cache (via T47532 and
90f6efc360fd5).
* 2015: Use local-server cache (APC), per T58602.
The file-based code was never used. The related task marked
invalid (T47532).
Change-Id: I8e2d9edcf3880149f824cc3de37793ca57435b49
jenkins-bot [Fri, 15 Mar 2019 19:09:57 +0000 (19:09 +0000)]
Merge "deferred: Remove deprecated CdnCacheUpdate::newSimplePurge"
Aaron Schulz [Fri, 12 Oct 2018 20:45:23 +0000 (13:45 -0700)]
Split out new RefreshSecondaryDataUpdate class
Make DerivedPageDataUpdater bundle all the related DataUpdate tasks
on page change with a RefreshSecondaryDataUpdate wrapper. If one of
the DataUpdate tasks fails, then the entire bundle of updates can be
re-run in the form of enqueueing a RefreshLinksJob instance (these
jobs are idempotent). If several of the bundled tasks fail, it is easy
for DeferredUpdates to know that only one RefreshLinksJob should be
enqueued.
The goal is to make DataUpdate tasks more reliable and resilient.
Most of these deferred update failures are due to ephemeral problems
like lock contention. Since the job queue is already able to reliably
store and retry jobs, and the time that a regular web request can spend
in post-send is more limited, it makes the most sense to just enqueue
tasks as jobs if they fail post-send.
Make LinkUpdate no longer defined as enqueueable as RefreshLinksJob
since they are not very congruent (LinksUpdate only does some of the
work that RefreshLinksJob does). Only the wrapper, with the bundle of
DataUpdate instances, is congruent to RefreshLinksJob.
This change does not itself implement the enqueue-on-failure logic
in DeferredUpdates, but is merely a prerequisite.
Bug: T206288
Change-Id: I191103c1aeff4c9fedbf524ee387dad9bdf5fab8
Thiemo Kreuz [Fri, 15 Mar 2019 13:53:12 +0000 (14:53 +0100)]
Remove empty and unnecessary /* @{{ … */ comments
This was the only comment I could find that uses two curly brackets
for some reason. There are a few more with one curly bracket.
Change-Id: Iaed631916064e6be4895edd4c7a3d7de491e16c2
jenkins-bot [Fri, 15 Mar 2019 12:39:12 +0000 (12:39 +0000)]
Merge "Add /** @var SplFileInfo $fileInfo */ docs where needed"
jenkins-bot [Fri, 15 Mar 2019 10:53:42 +0000 (10:53 +0000)]
Merge "Fix ChangeTagsTest failing on Postgres"
Aaron Schulz [Fri, 15 Mar 2019 09:24:31 +0000 (02:24 -0700)]
Make EditPage::getTemplates avoid page table query spam
This changes TemplatesOnThisPageFormatter to use LinkBatch
and LinkBatch/LinkCache to manage the field.
Change-Id: I523158cdffc599d4d29bab91c98e55085130cee2
Thiemo Kreuz [Fri, 15 Mar 2019 09:10:33 +0000 (10:10 +0100)]
Fix ChangeTagsTest failing on Postgres
The order of elements returned by the SELECT is not guaranteed. But the
assertEquals() can't know this. It does not know how to identify the two
objects, other than by their array index.
Using assertArrayEquals() would fix this. But I honestly don't like this
helper method. It is expensive, for example. So I went for an ORDER BY.
An example for this failure can be seen here:
https://integration.wikimedia.org/ci/job/mediawiki-quibble-vendor-postgres-php70-docker/2484/console
Change-Id: I284d13d21b9bc34270307e78430180d94fc6665e
Aaron Schulz [Fri, 15 Mar 2019 03:43:13 +0000 (20:43 -0700)]
rdbms: lower the log channel severity of LoadMonitor::getServerStates
Change-Id: If42e3973c3a4ce5baff628befd58d4b7b3a2909b
Aaron Schulz [Thu, 14 Mar 2019 02:29:36 +0000 (19:29 -0700)]
rdbms: improve database connection loss handling
Avoid throwing errors in Database::replaceLostConnection()
Bug: T218226
Change-Id: Id07f305816c61f62aaf1ae893f5d37c03c865f46
Krinkle [Fri, 15 Mar 2019 01:16:53 +0000 (01:16 +0000)]
Merge "rdbms: make Database::query() more readable and consistent"
Timo Tijhof [Fri, 15 Mar 2019 01:16:05 +0000 (01:16 +0000)]
deferred: Remove deprecated CdnCacheUpdate::newSimplePurge
Change-Id: I4ad7429b5253b5f2d38b9380d55acf42e34e21ba
Krinkle [Fri, 15 Mar 2019 01:00:26 +0000 (01:00 +0000)]
Merge "objectcache: make BagOStuff::add() abstract to discourage non-atomic versions"
Krinkle [Fri, 15 Mar 2019 00:56:31 +0000 (00:56 +0000)]
Merge "objectcache: make the BagOStuff::add() operation more atomic for WinCache"
Krinkle [Fri, 15 Mar 2019 00:56:02 +0000 (00:56 +0000)]
Merge "objectcache: make the BagOStuff::add() operation more atomic for APC"
jenkins-bot [Fri, 15 Mar 2019 00:51:19 +0000 (00:51 +0000)]
Merge "objectcache: add BagOStuff::deleteMulti() method for consistency"
Aaron Schulz [Tue, 12 Mar 2019 10:02:24 +0000 (03:02 -0700)]
objectcache: make BagOStuff::add() abstract to discourage non-atomic versions
Change-Id: If3c3fbf21207b0c74cad8a29fa5bbabe0af896e3
Aaron Schulz [Tue, 12 Mar 2019 10:01:37 +0000 (03:01 -0700)]
objectcache: make the BagOStuff::add() operation more atomic for WinCache
Change-Id: I285ed9a7d0894adfe29b0bdc106b7518f655ba45
Aaron Schulz [Tue, 12 Mar 2019 09:49:59 +0000 (02:49 -0700)]
objectcache: make the BagOStuff::add() operation more atomic for APC
Change-Id: Ifb72b1c17439c80e6d431d5fe2ec9ad9437e3ad7
jenkins-bot [Fri, 15 Mar 2019 00:33:22 +0000 (00:33 +0000)]
Merge "user: Avoid page_touched update in User::saveSettings"
jenkins-bot [Fri, 15 Mar 2019 00:15:57 +0000 (00:15 +0000)]
Merge "Deprecate Profiler::profileIn and Profiler::profileOut stubs"
jenkins-bot [Fri, 15 Mar 2019 00:10:06 +0000 (00:10 +0000)]
Merge "filebackend: change "profiler" parameter in FileBackend so it works again"
jenkins-bot [Fri, 15 Mar 2019 00:02:35 +0000 (00:02 +0000)]
Merge "rdbms: change "profiler" argument in Database::factory so it works again"
Aaron Schulz [Thu, 14 Mar 2019 23:46:44 +0000 (16:46 -0700)]
user: Avoid page_touched update in User::saveSettings
This was added in r42179 (
65bbc147836aa) and only CDN and object caches
need purging.
Change-Id: I7ca40f8eda15ffeac3aa21aa4445b993d9fcc131
Aaron Schulz [Tue, 12 Mar 2019 07:38:56 +0000 (00:38 -0700)]
objectcache: add BagOStuff::deleteMulti() method for consistency
Also:
* Make the BagOStuff tests actually pass for memcached and sql
* Add more unit tests for BagOStuff
* Make SqlBagOStuff::add() more atomic
Change-Id: Ic1eec0990a66b595b57c646498c3bd229442230c
Aaron Schulz [Thu, 14 Mar 2019 01:56:26 +0000 (18:56 -0700)]
rdbms: make Database::query() more readable and consistent
Mainly:
* Stash trxLevel as the variable $priorTransaction since
Database::replaceLostConnection might make it 0 when called.
* Factor out Database::beginIfImplied method and call it on
each query attempt of query(), not just the first one.
* Do not bother setting STATUS_TRX_ERROR if a query fails due to
connection issues and was recoverable since requiring ROLLBACK
in order to continue has no real advantage.
* Do not bother setting trxDoneWrites/lastWriteTime for temporary
table operations.
* Make Database::handleTransactionLoss() keep TransactionProfiler
cleaner by calling Database::transactionWritingOut().
Also:
* Make sure Database::wasKnownStatementRollbackError() calls are
right after the corresponding queries so it is easy to follow.
Having connection attempts in between seems fragile.
* Rename Database::doProfiledQuery => Database::attemptQuery and
move more logic to that method.
* Factor out Database::assertNeitherReplicaNorReadOnly method.
* Rename Database::assertOpen => Database::assertHasConnectionHandle.
* Fix wording of Database::wasKnownStatementRollbackError comments.
* Use $isEffectiveWrite variable name instead of $isNonTempWrite
and $isWrite in some places.
Bug: T218226
Change-Id: I2063e4080b41d5fc504f9207a56312ce92130ed7
Aaron Schulz [Wed, 13 Mar 2019 18:18:22 +0000 (11:18 -0700)]
Deprecate Profiler::profileIn and Profiler::profileOut stubs
Change-Id: I2a8764d2464883e9fe66048e97b688c5a76d595a
Aaron Schulz [Wed, 13 Mar 2019 18:14:19 +0000 (11:14 -0700)]
filebackend: change "profiler" parameter in FileBackend so it works again
The Profiler::profileIn and Profiler::profileOut methods are just stubs.
Use a callback to the Profile::scopedProfileIn method instead.
Change-Id: I7b493c145357994f61faebfbe3f65d38d2e6da42
Aaron Schulz [Wed, 13 Mar 2019 18:11:18 +0000 (11:11 -0700)]
rdbms: change "profiler" argument in Database::factory so it works again
The Profiler::profileIn and Profiler::profileOut methods are just stubs.
Use a callback to the Profiler::scopedProfileIn method instead.
Change-Id: I16068bce583bb880250fe91235f2283453be5e4c
jenkins-bot [Thu, 14 Mar 2019 22:14:23 +0000 (22:14 +0000)]
Merge "Avoid using outdated $casToken field for BagOStuff calls"
jenkins-bot [Thu, 14 Mar 2019 22:14:18 +0000 (22:14 +0000)]
Merge "Avoid sending duplicate ProfilerOutputText comments/html"
jenkins-bot [Thu, 14 Mar 2019 21:58:58 +0000 (21:58 +0000)]
Merge "rdbms: make query exceptions include the backtrace when logged"
jenkins-bot [Thu, 14 Mar 2019 21:58:53 +0000 (21:58 +0000)]
Merge "rdbms: clarify $uniqueIndexes argument to replace()/upsert()"
Aaron Schulz [Thu, 14 Mar 2019 19:50:52 +0000 (12:50 -0700)]
Fix WatchedItemStore last-seen stashing logic
This should be the "last revision seen" timestamp, which is
different than the "first revision not seen" timestamp in the DB.
Also make sure that SpecialWatchlist accounts for the stash values.
Relatedly, better document the callback usage in BagOStuff::merge().
Change-Id: I98b03a5cd40fec5b4a2633d499ff77079d264e3c
Translation updater bot [Thu, 14 Mar 2019 21:37:35 +0000 (22:37 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I2157943a62f159425a99eb7a577658b813681678
jenkins-bot [Thu, 14 Mar 2019 18:58:23 +0000 (18:58 +0000)]
Merge "Fix assertArrayEquals() calls with bogus 3rd parameter"
jenkins-bot [Thu, 14 Mar 2019 18:42:17 +0000 (18:42 +0000)]
Merge "objectcache: make the $flags argument appear more consistently in BagOStuff"
jenkins-bot [Thu, 14 Mar 2019 17:39:24 +0000 (17:39 +0000)]
Merge "SpecialContributions: Conditionally hide the namespace checkboxes"
jenkins-bot [Thu, 14 Mar 2019 17:39:18 +0000 (17:39 +0000)]
Merge "SpecialWatchlist: Conditionally hide the namespace checkboxes"
Thiemo Kreuz [Thu, 14 Mar 2019 13:53:41 +0000 (14:53 +0100)]
Fix assertArrayEquals() calls with bogus 3rd parameter
This issue came up in I8a49143, see
https://integration.wikimedia.org/ci/job/mediawiki-quibble-vendor-postgres-php70-docker/2453/console
The third parameter of assertArrayEquals() is called $ordered and is
meant to take the order of elements into account. Providing a string sets
this to true. The SQL query in ChangesListSpecialPageTest seems to behave
a bit random in Postgres and does not always return the elements in the
same order. This is fine. It's just the assertion that was to strict, by
accident.
I found a few more instances of the same issue with a regular expression.
In most cases I intentionally changed it to assertSame() because the order
of elements is actually guaranteed by the code, and needs to be (e.g.
mixing width and height of an image would be fatal).
Change-Id: Ice66cab873a7271d55809a486ce28cf637e43e33
jenkins-bot [Thu, 14 Mar 2019 16:09:11 +0000 (16:09 +0000)]
Merge "Throw exception on wrong type in Language::isValidCode( $code )"
jenkins-bot [Thu, 14 Mar 2019 16:09:05 +0000 (16:09 +0000)]
Merge "Site: Explicit allow setLanguageCode( null )"
jenkins-bot [Thu, 14 Mar 2019 14:44:11 +0000 (14:44 +0000)]
Merge "Make copyTestData work on postgres"
Thiemo Kreuz [Thu, 14 Mar 2019 14:04:05 +0000 (15:04 +0100)]
Add /** @var SplFileInfo $fileInfo */ docs where needed
Change-Id: Ia844af3347db52f9f004892578ba4aefac7dd875
jenkins-bot [Thu, 14 Mar 2019 13:17:47 +0000 (13:17 +0000)]
Merge "Add a user preference to opt in or out of a confirmation prompt for rollbacks."
jenkins-bot [Thu, 14 Mar 2019 12:41:22 +0000 (12:41 +0000)]
Merge "Add MessagesNqo.php"
jenkins-bot [Thu, 14 Mar 2019 11:07:39 +0000 (11:07 +0000)]
Merge "Update OOUI to v0.31.0"
jenkins-bot [Thu, 14 Mar 2019 10:07:38 +0000 (10:07 +0000)]
Merge "Language: Use Assert::parameterType for type checks"
Amir Aharoni [Mon, 4 Mar 2019 12:52:08 +0000 (14:52 +0200)]
Add MessagesNqo.php
The export from translatewiki was not done yet,
but there is good localization activity,
and having this file will allow correct RTL layout.
Bug: T152908
Change-Id: I8cfc718af5e96ce9d902d1bf5400a3bb2971acde
MaxSem [Thu, 14 Mar 2019 05:41:52 +0000 (05:41 +0000)]
Merge "Avoid page table query spam in HistoryPager due to lastLink()"
James D. Forrester [Thu, 14 Mar 2019 01:03:02 +0000 (18:03 -0700)]
Update OOUI to v0.31.0
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.31.0
Bug: T215645
Bug: T217471
Bug: T217584
Bug: T217952
Bug: T218271
Depends-On: Icc14a3662039080f1a65d098004640366351f0bb
Change-Id: Icc14a3662039080f1a65d098004640366351f0ba
jenkins-bot [Wed, 13 Mar 2019 23:31:02 +0000 (23:31 +0000)]
Merge "Remove references to Html5Depurate"
jenkins-bot [Wed, 13 Mar 2019 22:23:50 +0000 (22:23 +0000)]
Merge "Avoid a few overly complicated is_null() checks"
Subramanya Sastry [Wed, 13 Mar 2019 21:33:37 +0000 (16:33 -0500)]
Remove references to Html5Depurate
Change-Id: I4f07c5ae606f5c86242bb7d299f4f30a044860b4
daniel [Mon, 4 Mar 2019 22:01:38 +0000 (23:01 +0100)]
Make copyTestData work on postgres
The issue with SQLite mentioned in the ticket remains unresolved
for now. To make this less confusing, copyTestData() will throw
for sqlite with an explanation instead of failing later. The test
for copyTestData is skipped on sqlite as well.
Bug: T217607
Change-Id: Ib9baa15cb6feff6c06959359f846b94ae6efab07
Translation updater bot [Wed, 13 Mar 2019 20:58:23 +0000 (21:58 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I0b3266b3300731491affb838bb287496fe942d3a
Aaron Schulz [Wed, 13 Mar 2019 16:12:47 +0000 (09:12 -0700)]
rdbms: make query exceptions include the backtrace when logged
Previously, the corresponding Exception channel entry was relied on for
the backtrace, though there might not always be one.
Change-Id: I4a3b0fec0beaec1ebfe71be3850aa353cd37d562
Aaron Schulz [Wed, 13 Mar 2019 18:31:58 +0000 (11:31 -0700)]
Avoid page table query spam in HistoryPager due to lastLink()
Pass in the Title so there is not an extra query for each revision.
Change-Id: I0d36422a304c31c4bda0a408ef4a6fcd52ad57f1
jenkins-bot [Wed, 13 Mar 2019 18:11:21 +0000 (18:11 +0000)]
Merge "resourceloader: Remove redundant var-freeing in addScript()"
jenkins-bot [Wed, 13 Mar 2019 17:59:14 +0000 (17:59 +0000)]
Merge "resourceloader: Reduce size of ES5 StringSet fallback"
jenkins-bot [Wed, 13 Mar 2019 17:59:08 +0000 (17:59 +0000)]
Merge "resourceloader: Minor optimisation in variable declarations"
Aaron Schulz [Wed, 13 Mar 2019 17:27:38 +0000 (10:27 -0700)]
Avoid sending duplicate ProfilerOutputText comments/html
Change-Id: I4130845cdb7208b8456740e5dbaf8bf96e175f49
Arlo Breault [Wed, 6 Mar 2019 21:49:07 +0000 (16:49 -0500)]
parser: closeParagraph already resets the lastSection
Change-Id: Ic24c9aa25852cc786a5ca438c2c1e9031f9e7c17
Aaron Schulz [Wed, 13 Mar 2019 03:09:21 +0000 (20:09 -0700)]
rdbms: clarify $uniqueIndexes argument to replace()/upsert()
Also make upsert() match replace() for consistency.
Change-Id: I208f3ab810a61c6949ac0050436767675f99a60b
jenkins-bot [Wed, 13 Mar 2019 00:27:11 +0000 (00:27 +0000)]
Merge "Replace sorting classes with better naming convention"
Aaron Schulz [Tue, 12 Mar 2019 07:30:34 +0000 (00:30 -0700)]
objectcache: make the $flags argument appear more consistently in BagOStuff
Change-Id: I08879ede5e9f0ab227497bb1dab89ea61b65abce
Translation updater bot [Tue, 12 Mar 2019 21:09:11 +0000 (22:09 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I2887536cb78f5b4780550b67a2fde8aaf7530a97
jenkins-bot [Tue, 12 Mar 2019 17:55:18 +0000 (17:55 +0000)]
Merge "LogEntry: Restore logic to add change tags on udp-only publish"
Ottomata [Tue, 12 Mar 2019 17:23:12 +0000 (17:23 +0000)]
Merge "ApiMain.php api/request logging event changes"
jenkins-bot [Tue, 12 Mar 2019 16:35:00 +0000 (16:35 +0000)]
Merge "Add password policy setting `suggestChangeOnLogin`"
Andrew Otto [Fri, 8 Mar 2019 21:50:34 +0000 (16:50 -0500)]
ApiMain.php api/request logging event changes
- Use 'Z' UTC timezone on dt
- Don't provide empty arrays if no data entries
- No need to set X-Request-Id in http.request_headers, it is meta.request_id
Bug: T214080
Bug: T212529
Change-Id: I37aa41a46ce74b372070e88a2f4da746fcbe2449
Fomafix [Wed, 27 Jun 2018 10:16:26 +0000 (12:16 +0200)]
Throw exception on wrong type in Language::isValidCode( $code )
This prevents that Language::isValidCode( null ) returns true.
Depends-On: I38d8358469903afb15331212206635283cedcd46
Change-Id: I5dc5bd45d648a548dfd27aaa1b3c29a2e99f0e8b
Brad Jorsch [Tue, 12 Mar 2019 14:55:27 +0000 (10:55 -0400)]
LogEntry: Restore logic to add change tags on udp-only publish
This was unintentionally removed in I8df2fd98.
Bug: T218110
Change-Id: Ie8678b4207032d6eb877d596eb8f115798c80a1e
Fomafix [Tue, 26 Jun 2018 07:30:39 +0000 (09:30 +0200)]
Site: Explicit allow setLanguageCode( null )
$site->setLanguageCode( null ) is already used in
DBSiteStore::loadSites and this worked because
Language::isValidCode( null ) === true.
This change explicit check for null and allow to set null without
depending on Language::isValidCode( null ) === true.
Change-Id: I0c9fe03cbf1434b0340e61e96360c0aaeb0fe89d