Daniel Kinzler [Tue, 31 Aug 2010 13:47:24 +0000 (13:47 +0000)]
Follow-up to r71944: Interoducing MimeMagic::improveTypeFromExtension() for two reasons:
a) avoid redundant inspection of file contents when validating uploads, caused by multiple calls to guessMimeType
b) deprecated obscure use of the file extension when guessing mime types, using an explicit call to improveTypeFromExtension() instead
Note that File::getPropsFromPath() will now return an additional field: $props['file-mime'] contains the mime type as determined solely from the file's content, $props['mime'] contains the type that was derived considering the file extension too.
Platonides [Tue, 31 Aug 2010 13:16:42 +0000 (13:16 +0000)]
Move FileUpload hook out of the transaction.
FileSearch relied on the article not existing to detect if it's a but it was broken: always detected it as a reupload.
Add a new parameter to the hook to detect reuploads.
Fixed other issues on FileSearch extension.
Platonides [Tue, 31 Aug 2010 11:12:33 +0000 (11:12 +0000)]
(Bug 20744) - Wiki forgets about an uploaded file
(Bug 24978) - "A file disappeared" thread on Commons:VP
Only save the LocalFile to memcache after the db entry has been commited.
Otherwise, when the transaction fails, the file apparently succeeded, but
after a week (memcached expiry) it disappears.
Fixes bug 20744 and bug 24978. Found by the Great Domas.
The correlation with db problems is probably just that in such case there are more transactions get rollbacked.
Derk-Jan Hartman [Tue, 31 Aug 2010 11:01:00 +0000 (11:01 +0000)]
Followup r71942. Documentation fix, the mime passed is a string, not an object.
Daniel Kinzler [Tue, 31 Aug 2010 09:38:11 +0000 (09:38 +0000)]
reverting r71944 as per TheDJ's comment. Will investigate a better way to avoid redundant mime guesses
Siebrand Mazeland [Tue, 31 Aug 2010 06:32:18 +0000 (06:32 +0000)]
Localisation updates for core messages from translatewiki.net
* Fix translator messup for French.
Ryan Kaldari [Tue, 31 Aug 2010 00:33:14 +0000 (00:33 +0000)]
Fixing comment so that method documentation isn't broken
Siebrand Mazeland [Mon, 30 Aug 2010 21:00:57 +0000 (21:00 +0000)]
Localisation updates for core messages from translatewiki.net
* Minangkabau (min) (new)
Sam Reed [Mon, 30 Aug 2010 20:28:32 +0000 (20:28 +0000)]
Spaces and braces
Raimond Spekking [Mon, 30 Aug 2010 19:13:28 +0000 (19:13 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-08-30 18:48:00 UTC)
Chad Horohoe [Mon, 30 Aug 2010 19:07:09 +0000 (19:07 +0000)]
Tweak SpecialRecentChangesQuery hook. Need to be able to modify selected fields on RCL (part 1 for bug 23916)
Niklas Laxström [Mon, 30 Aug 2010 18:16:43 +0000 (18:16 +0000)]
Avoid stupid queries in LinkHolderArray
Title::isAlwaysKnown will return true for all existing special pages, so the rest don't exists
Chad Horohoe [Mon, 30 Aug 2010 16:52:51 +0000 (16:52 +0000)]
Get rid of PHP4-style constructors
Chad Horohoe [Mon, 30 Aug 2010 14:23:52 +0000 (14:23 +0000)]
Mark wfSeedRandom() for removal in next version. Not used anywhere
Daniel Kinzler [Mon, 30 Aug 2010 12:51:44 +0000 (12:51 +0000)]
as per r71789: don't guess mime type again, that's expensive. Re-use the value from FileProps.
Daniel Kinzler [Mon, 30 Aug 2010 12:10:02 +0000 (12:10 +0000)]
interoduced new hoop in Uploadbase::verifyFile, as per comments to r71789
Aryeh Gregor [Sun, 29 Aug 2010 21:46:29 +0000 (21:46 +0000)]
RELEASE-NOTES for r71903
Aryeh Gregor [Sun, 29 Aug 2010 21:40:27 +0000 (21:40 +0000)]
Make SpecialUpload members public again
These were made protected in r57868 with no explanation, and it broke
extensions. See bug 24981, which points out that there's no longer any
way for extensions to edit things like $mComment from the
UploadForm:BeforeProcessing hook.
Will backport to 1.16, as a regression from 1.15.
Aryeh Gregor [Sun, 29 Aug 2010 21:21:57 +0000 (21:21 +0000)]
Fix category count when category table out of sync
This should fix a regression from my category sort work, caused by not
accounting for the the fact that $this->from and $this->until were
changed to arrays. Wrong counts for the number of pages in the category
might have been displayed in some cases.
Platonides [Sun, 29 Aug 2010 19:11:23 +0000 (19:11 +0000)]
Follow up r32776.
$log->addEntry got added an extra indentation, which was wrong.
Functionality was right. It goes *outside* the if
Aryeh Gregor [Sun, 29 Aug 2010 19:07:06 +0000 (19:07 +0000)]
Use <<<HTML for vim docstring syntax highlighting
This way vim highlights the docstring as HTML instead of plaintext,
which is nice.
Raimond Spekking [Sun, 29 Aug 2010 19:04:07 +0000 (19:04 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-08-29 18:53:00 UTC)
Chad Horohoe [Sun, 29 Aug 2010 13:06:22 +0000 (13:06 +0000)]
Partial revert r71363. I lied, these are used. They're just not documented for crap
Siebrand Mazeland [Sun, 29 Aug 2010 11:40:28 +0000 (11:40 +0000)]
(bug 24794) Update Tatar link trail.
Andrew Garrett [Sun, 29 Aug 2010 03:08:15 +0000 (03:08 +0000)]
Unmerging r71867. Merge-conflicts with some things Nikerabbit was doing. He broke it, leaving him to fix it for now :-)
Andrew Garrett [Sun, 29 Aug 2010 03:03:28 +0000 (03:03 +0000)]
Fix bug introduced in untested r71576. getNamespaces() did not use getCanonicalNamespaces for backwards-compatibility with 1.16wmf4 :-)
Siebrand Mazeland [Sat, 28 Aug 2010 23:52:46 +0000 (23:52 +0000)]
Localisation updates for core messages from translatewiki.net
Raimond Spekking [Sat, 28 Aug 2010 19:25:37 +0000 (19:25 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-08-28 19:12:00 UTC)
Alexandre Emsenhuber [Sat, 28 Aug 2010 12:27:29 +0000 (12:27 +0000)]
Reuse code from updateRestrictions.php in do_restrictions_update() instead of having its own code
Sam Reed [Sat, 28 Aug 2010 01:18:18 +0000 (01:18 +0000)]
Describe user property in ApiQueryAllimages
Add userid to ApiQueryProtectedTitles
bug 19195
Sam Reed [Sat, 28 Aug 2010 01:09:21 +0000 (01:09 +0000)]
Bug 19195 - Make user IDs more readily available with the API
Rest of user props done
Sam Reed [Sat, 28 Aug 2010 00:57:58 +0000 (00:57 +0000)]
r71834, params and desc would be good
Sam Reed [Sat, 28 Aug 2010 00:54:16 +0000 (00:54 +0000)]
Followup r71831, it's not mutually exclusive!
Add missing if
Sam Reed [Sat, 28 Aug 2010 00:52:38 +0000 (00:52 +0000)]
Couple more userid properties for Bug 19195
Sam Reed [Sat, 28 Aug 2010 00:37:48 +0000 (00:37 +0000)]
Part of Bug 19195 - Make user IDs more readily available with the API
ApiQueryAllUsers, ApiQueryImageInfo and ApiQueryRevisions exposing user_id
Raimond Spekking [Fri, 27 Aug 2010 20:59:18 +0000 (20:59 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-08-27 20:38:00 UTC)
Platonides [Fri, 27 Aug 2010 20:57:32 +0000 (20:57 +0000)]
Make a bunch of incompatible changes to the PoolCounter.
It wasn't finished, so it's not a big deal.
* Use the term workers instead of threads, which fits better for a multiserver setup.
* The API is now more accurate for our goals (I hope).
* Add support for using the parse from another worker.
* Use child classes instead of array callbacks.
* The daemon is written in C using libevent instead of python using twistd.
* The hash function used is that of Bob Jenkins, with files hash.c and hash.h directly copied from memcached 1.4.5
* Although similar in a few aspects to memcached assoc.c hash table, this is a different hash table implementation. Most important:
** The usage of a double linked list in the hash table.
** Growing is not performed using a maintenance thread. Since the entries are shortlived, it just waits for the old hash table to disappear.
* Note: valgrind 3.5.0 (2009-8-19) does not support accept4 (added in r10955, 2009-11-25). In the meantime you need to use HAVE_ACCEPT4=0 for running with valgrind (as you would need for a non-linux system).
* Sending SIGUSR1 to the daemon gracefully restarts it. The maximum limits will be doubled until the old instance finishes (ie. all its client connections expire).
* Do not try to test it with instances calling an ?action=purge They will serialize on the "UPDATE `page` SET page_touched" query instead of being serialized by the PoolCounter.
* The workers parameter is not stored by the poolcounter. It is expected that all requests with the same key will also have the same value. A reduction in new entries will not take effect if that number is working (not even when they end, if there are waiting entries). But an increase will increase throughput even for old queued requests.
Platonides [Fri, 27 Aug 2010 17:55:20 +0000 (17:55 +0000)]
Remove old var_dump
Sam Reed [Fri, 27 Aug 2010 17:35:07 +0000 (17:35 +0000)]
Revert insertOrUpdate work
Will mark relevant revisions as reverted on CR as appropriate
Aryeh Gregor [Fri, 27 Aug 2010 16:42:18 +0000 (16:42 +0000)]
Style fixes for r71609 and follow-ups
Avoid one-letter variable names, be descriptive. Name an unused value
variable in foreach "$unused". Add spaces where needed. Wrap comments
at 79 columns, not some arbitrarily-selected number. Remove blank line.
Mark A. Hershberger [Fri, 27 Aug 2010 01:38:09 +0000 (01:38 +0000)]
Start of verbose option, fix url option
Chad Horohoe [Fri, 27 Aug 2010 00:08:04 +0000 (00:08 +0000)]
Might not be GPLv2
Sam Reed [Thu, 26 Aug 2010 23:37:59 +0000 (23:37 +0000)]
Move ApiFormatYaml_spyc.php to spyc.php as per r71763
Chad Horohoe [Thu, 26 Aug 2010 23:31:00 +0000 (23:31 +0000)]
Copy paste fail
Chad Horohoe [Thu, 26 Aug 2010 23:22:17 +0000 (23:22 +0000)]
Per wikitech-l discussion, it would be kind of cool if we collected our non-MediaWiki-specific classes in one location to encourage reuse. So I moved IEContentAnalyzer to includes/libs and put a README for 3rd party users. Code that goes in includes/libs should call ZERO MediaWiki code. This means no wfProfileIn, no globals, nada
Chad Horohoe [Thu, 26 Aug 2010 23:10:11 +0000 (23:10 +0000)]
Move all abstract stuff that DatabaseBase children must implement to new interface DatabaseType. Puts all of the 'must implement' things in one place. Also lets me use abstract statics, as a workaround for r71441
Chad Horohoe [Thu, 26 Aug 2010 22:39:14 +0000 (22:39 +0000)]
Doc fix
Sam Reed [Thu, 26 Aug 2010 22:31:49 +0000 (22:31 +0000)]
Drop $options from insertOrUpdate - r71662
Sam Reed [Thu, 26 Aug 2010 22:23:03 +0000 (22:23 +0000)]
Followup r71662
Update fname (same for DatabaseMysql)
Add missing spaces, remove superfluous makeList() call
Sam Reed [Thu, 26 Aug 2010 22:12:01 +0000 (22:12 +0000)]
I really do hate whitespace
Sam Reed [Thu, 26 Aug 2010 22:09:29 +0000 (22:09 +0000)]
* (bug 24724) list=allusers is out by 1 (shows total users - 1)
Roan Kattouw [Thu, 26 Aug 2010 21:02:12 +0000 (21:02 +0000)]
Merge r71750 to trunk: let wfTimestamp() accept TS_RFC2822 as an input format in addition to output
Mark A. Hershberger [Thu, 26 Aug 2010 20:52:21 +0000 (20:52 +0000)]
* Adapt the RunSeleniumTests.php to the Maintenance framework.
* Add Maintenance::deleteOption() for removing default options.
* Add Maintenance::addDescription() for updating the description.
Aryeh Gregor [Thu, 26 Aug 2010 19:40:29 +0000 (19:40 +0000)]
Style fixes for Linker.php
Mostly stylize.php, some manual. As usual, if you're seeing this in a
blame, use "svn blame -x -w" or "git blame -w", as appropriate.
Platonides [Thu, 26 Aug 2010 18:28:33 +0000 (18:28 +0000)]
When the CSRF token on is not available in the session, show the
'you have cookies disabled' message instead of "Session problem,
canceled to avoid session hijacking"
Max Semenik [Thu, 26 Aug 2010 15:47:18 +0000 (15:47 +0000)]
Temporary plug for bug 24939 (interwiki creation during installation fails on SQLite), before we switch to new-installer.
Sam Reed [Thu, 26 Aug 2010 14:14:14 +0000 (14:14 +0000)]
Followup r71662, remove debug code
Siebrand Mazeland [Thu, 26 Aug 2010 08:03:07 +0000 (08:03 +0000)]
* Danish (dk) (removed deprecated language code)
* Fiji Hindi (Devangari script) (removed because of very low localisation level - might return later)
Sam Reed [Wed, 25 Aug 2010 23:00:27 +0000 (23:00 +0000)]
Tweak to insertOnDupeUpdate in DatabaseMysql to split how wanted ( foo = bar )
Siebrand Mazeland [Wed, 25 Aug 2010 22:01:30 +0000 (22:01 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-08-25 21:36 UTC)
Sam Reed [Wed, 25 Aug 2010 21:46:45 +0000 (21:46 +0000)]
Fill out insertOrUpdate in DatabaseBase, rather than blank stub. Followup to r71634
Sam Reed [Wed, 25 Aug 2010 19:08:52 +0000 (19:08 +0000)]
Improve comment for $uniqueIndexes r71644
Sam Reed [Wed, 25 Aug 2010 18:50:36 +0000 (18:50 +0000)]
Replace todo with documentation with partial
Move brace
Sam Reed [Wed, 25 Aug 2010 18:36:19 +0000 (18:36 +0000)]
Update Frr linktrail per frr.wikipedia.org/wiki/Wikipedia:Diskusjoon#Sonderzeichen
Aryeh Gregor [Wed, 25 Aug 2010 17:56:03 +0000 (17:56 +0000)]
Blacklist % in HTML id's
As pointed out by entlinkt at bug 24918, this could cause problems --
browsers don't interpret percent escapes in fragments consistently, so
any percent sign that might be part of an escape could be a problem.
For simplicity, just strip all of them.
Sam Reed [Wed, 25 Aug 2010 17:45:00 +0000 (17:45 +0000)]
Move insertOnDupeUpdate (and rename to insertOrUpdate) to DatabaseMysql. Add todo/fixme in insertOrUpdate in DatabaseBase
Add some braces
Sam Reed [Wed, 25 Aug 2010 15:58:58 +0000 (15:58 +0000)]
Change usages of Database:: for function names in DatabaseMssql to DatabaseMssql::
Sam Reed [Wed, 25 Aug 2010 15:38:32 +0000 (15:38 +0000)]
Braces for MaxSem
Sam Reed [Wed, 25 Aug 2010 15:26:45 +0000 (15:26 +0000)]
Followup r71593 - Spaces, I *still* hate you
Sam Reed [Wed, 25 Aug 2010 02:24:54 +0000 (02:24 +0000)]
Followup r71609 add missing $
Sam Reed [Wed, 25 Aug 2010 01:24:47 +0000 (01:24 +0000)]
Update documentation - Database:: to DatabaseBase:: considering Database:: is some legacy alias for DatabaseMySql
Sam Reed [Wed, 25 Aug 2010 01:03:43 +0000 (01:03 +0000)]
Create insertOnDupeUpdate, called by insert
Will be using soon
Sam Reed [Wed, 25 Aug 2010 00:18:47 +0000 (00:18 +0000)]
Param and return documentation for insert
Siebrand Mazeland [Tue, 24 Aug 2010 23:02:39 +0000 (23:02 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-08-24 22:46 UTC)
Sam Reed [Tue, 24 Aug 2010 22:44:44 +0000 (22:44 +0000)]
Whitespace, I hate you.
Sam Reed [Tue, 24 Aug 2010 22:36:11 +0000 (22:36 +0000)]
Fix those spaces too from r71596/r71592
Sam Reed [Tue, 24 Aug 2010 22:34:44 +0000 (22:34 +0000)]
Fixup whitespace from r71592
if ( !($buf == self::$png_sig) ) { to if ( $buf != self::$png_sig ) {
Add a couple of braces
Sam Reed [Tue, 24 Aug 2010 22:06:08 +0000 (22:06 +0000)]
self::DB_ADMIN to Maintenance::DB_ADMIN for constant
Sam Reed [Tue, 24 Aug 2010 22:04:49 +0000 (22:04 +0000)]
Move unreachable $this->mConn = false in DatabaseSqlite
Sam Reed [Tue, 24 Aug 2010 22:03:18 +0000 (22:03 +0000)]
Remove some unreachable code (usually returns after throwing exceptions)
Fixup call of method after return in DatabaseMssql by using a temp
Sam Reed [Tue, 24 Aug 2010 22:00:02 +0000 (22:00 +0000)]
Add missing brace to skins/simple/rtl.css
Niklas Laxström [Tue, 24 Aug 2010 20:12:15 +0000 (20:12 +0000)]
Someone made a typo in r71576
Niklas Laxström [Tue, 24 Aug 2010 19:58:55 +0000 (19:58 +0000)]
Added a hook into MWNamespace::getCanonicalNamespaces() to provide safe way to
define new namespaces in extensions.
Without the hook the list could be initialised too early and some namespaces
would be left undefined. Was causing problems at translatewiki.net.
Greg Sabino Mullane [Tue, 24 Aug 2010 17:35:03 +0000 (17:35 +0000)]
CREATE LANGUAGE belongs as part of the installer, not here.
Greg Sabino Mullane [Tue, 24 Aug 2010 17:34:42 +0000 (17:34 +0000)]
Allow both single and double quotes for ENUM values (even though we should standardize on one or the other)
Roan Kattouw [Tue, 24 Aug 2010 16:01:52 +0000 (16:01 +0000)]
Allow class="noshiftselect" to disable the multiple-select-on-shift-click behavior for checkboxes. This is desired for forms that contain tables with multiple columns of checkboxes (CentralNotice has one of these), where this function works row-wise instead of column-wise. This is confusing and I'm too lazy to implement column-wise shift-select, so I'm just disabling shift-select altogether in CentralNotice (see followup commit).
Jeroen De Dauw [Tue, 24 Aug 2010 14:58:35 +0000 (14:58 +0000)]
Follow up to r71110, use of static var instead of global var, as suggested by Platonides
Siebrand Mazeland [Tue, 24 Aug 2010 13:59:09 +0000 (13:59 +0000)]
Fix syntax error in r71555
Siebrand Mazeland [Tue, 24 Aug 2010 13:54:07 +0000 (13:54 +0000)]
Localisation updates for extensions from translatewiki.net
* update namespace names.
Siebrand Mazeland [Tue, 24 Aug 2010 13:30:06 +0000 (13:30 +0000)]
Follow up r71553: (update magic words)
Siebrand Mazeland [Tue, 24 Aug 2010 13:14:19 +0000 (13:14 +0000)]
Localisation updates for core from translatewiki.net
* update magic words.
Siebrand Mazeland [Tue, 24 Aug 2010 12:30:07 +0000 (12:30 +0000)]
Localisation updates for core from translatewiki.net
* update special page aliases.
Tim Starling [Tue, 24 Aug 2010 08:48:46 +0000 (08:48 +0000)]
Fixes for new ImageMagick:
* (bug 24824) Support ImageMagick 6.5.6-2+ JPEG decoder size hint, to reduce memory usage when such an ImageMagick is used for scaling.
* Removed -size option since it doesn't act as a JPEG decoder size hint with recent ImageMagicks, and it may cause undesired behaviour in the future since it's documented to do something different now.
* Disable multithreaded behaviour in recent ImageMagick, to avoid a deadlock when a resource limit such as $wgMaxShellMemory is hit.
* Fixed some comments.
Replaces WMF live hack.
Siebrand Mazeland [Tue, 24 Aug 2010 06:37:29 +0000 (06:37 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-08-24 06:24 UTC)
Sam Reed [Tue, 24 Aug 2010 01:31:28 +0000 (01:31 +0000)]
Update SkinAfterContent hook to pass the current skin too
So we don't need nasty $wgTitle globals
Sam Reed [Tue, 24 Aug 2010 00:56:56 +0000 (00:56 +0000)]
* (bug 24917) Polish as fallback for Kashubia
Sam Reed [Mon, 23 Aug 2010 22:52:37 +0000 (22:52 +0000)]
arrray?
Sam Reed [Mon, 23 Aug 2010 22:18:05 +0000 (22:18 +0000)]
Remove some unneeded whitespace
Platonides [Mon, 23 Aug 2010 21:54:45 +0000 (21:54 +0000)]
Try to improve the funciton comment of getETag() per r70809 CR. Adaptation of Nikerabbit proposal.
Rotem Liss [Mon, 23 Aug 2010 21:47:26 +0000 (21:47 +0000)]
Localization update for he.