From: Brion Vibber <brion@users.mediawiki.org>
Date: Tue, 26 Aug 2008 18:51:27 +0000 (+0000)
Subject: Quick hack to fix the broken hack noted in bug 15301
X-Git-Tag: 1.31.0-rc.0~45648
X-Git-Url: http://git.cyclocoop.org/%28%28?a=commitdiff_plain;h=e394f6a2d8ff89ad8d9d68dc3aa62ed2680e84e2;p=lhc%2Fweb%2Fwiklou.git

Quick hack to fix the broken hack noted in bug 15301

Use of:
			$action_desc[0] = strtolower($action_desc[0]);
is horrible wrong for a few reasons:

1) The first-byte match fails for all non-ASCII characters -- use lcfirst()!
2) System strtolower() or lcfirst() may not work for UTF-8 or lang-specific issues properly; use $wgLang->lcfirst()
3) You shouldn't be forcing things to lowercase here anyway, you can't know it's correct gramattically.

This whole message output should be redone cleanly; either all the rights info messages should be designed to work in an inline list sentence, or they should be formatted as stand-alone text strings using a <ul> or something.
---

diff --git a/includes/OutputPage.php b/includes/OutputPage.php
index 27f36983ee..1da96b6727 100644
--- a/includes/OutputPage.php
+++ b/includes/OutputPage.php
@@ -1157,8 +1157,9 @@ class OutputPage {
 		if ($action == null) {
 			$text = wfMsgNoTrans( 'permissionserrorstext', count($errors)). "\n\n";
 		} else {
+			global $wgLang;
 			$action_desc = wfMsg( "right-$action" );
-			$action_desc[0] = strtolower($action_desc[0]);
+			$action_desc = $wgLang->lcfirst( $action_desc ); // FIXME: TERRIBLE HACK
 			$text = wfMsgNoTrans( 'permissionserrorstext-withaction', count($errors), $action_desc ) . "\n\n";
 		}