in MediaWiki 1.26, have now been hard deprecated. This affects $wgUseTidy,
$wgTidyBin, $wgTidyConf, $wgTidyOpts, $wgTidyInternal, and $wgDebugTidy. Use
$wgTidyConfig instead.
-* All Tidy configurations other than Remex have been deprecated; future parsers
- will not emit compatible output for these configurations.
+* All Tidy configurations other than Remex have been hard deprecated;
+ future parsers will not emit compatible output for these configurations.
=== Other changes in 1.32 ===
* (T198811) The following tables have had their UNIQUE indexes turned into
*/
public static function newKey( $key ) {
global $wgCommentTableSchemaMigrationStage;
- // TODO uncomment once not used in extensions
- // wfDeprecated( __METHOD__, '1.31' );
+ wfDeprecated( __METHOD__, '1.31' );
$store = new CommentStore( MediaWikiServices::getInstance()->getContentLanguage(),
$wgCommentTableSchemaMigrationStage );
$store->key = $key;
// New revision is unsaved; bail out.
// TODO in theory rendering the new revision is a meaningful thing to do
// even if it's unsaved, but a lot of untangling is required to do it safely.
+ return;
}
$out->setRevisionId( $this->mNewid );
'type' => 'float',
'label-message' => 'recentchangesdays',
'section' => 'rc/displayrc',
- 'min' => 1,
+ 'min' => 1 / 24,
'max' => ceil( $rcMaxAge / ( 3600 * 24 ) ),
'help' => $l10n->msg( 'recentchangesdays-max' )->numParams(
ceil( $rcMaxAge / ( 3600 * 24 ) ) )->escaped()
];
$defaultPreferences['rclimit'] = [
'type' => 'int',
- 'min' => 0,
+ 'min' => 1,
'max' => 1000,
'label-message' => 'recentchangescount',
'help-message' => 'prefs-help-recentchangescount',
* @deprecated since 1.32, use RemexDriver
*/
abstract class RaggettBase extends TidyDriverBase {
+
+ function __construct( $config ) {
+ parent::__construct( $config );
+
+ // All tidy modes other than remex are deprecated.
+ wfDeprecated( __METHOD__, '1.32' );
+ }
+
/**
* Generic interface for wrapping and unwrapping HTML for Dave Raggett's tidy.
*
<?php
use MediaWiki\User\UserIdentity;
+use MediaWiki\MediaWikiServices;
use Wikimedia\TestingAccessWrapper;
/**
$userIdentity->method( 'getName' )->willReturn( $user->getName() );
$userIdentity->method( 'getActorId' )->willReturn( 0 );
- list( $cFields, $cCallback ) = CommentStore::newKey( 'rev_comment' )
- ->insertWithTempTable( $this->db, '' );
+ list( $cFields, $cCallback ) = MediaWikiServices::getInstance()->getCommentStore()
+ ->insertWithTempTable( $this->db, 'rev_comment', '' );
$m = $this->makeMigration( MIGRATION_WRITE_BOTH );
list( $fields, $callback ) =
$m->getInsertValuesWithTempTable( $this->db, 'rev_user', $userIdentity );
* @return CommentStore
*/
protected function makeStoreWithKey( $stage, $key ) {
+ $this->hideDeprecated( 'CommentStore::newKey' );
$store = CommentStore::newKey( $key );
TestingAccessWrapper::newFromObject( $store )->stage = $stage;
return $store;
}
public function testNewKey() {
+ $this->hideDeprecated( 'CommentStore::newKey' );
$this->assertInstanceOf( CommentStore::class, CommentStore::newKey( 'dummy' ) );
}