* (bug 33045) Use locally-sourced spinner image for mediawiki.feedback module instead...

Switched from an <img> with a hardcoded Commons link to a <span>, a stylesheet, and a locally-hosted copy of the image.

diff --git a/resources/Resources.php b/resources/Resources.php
index 081eb97..124f460 100644 (file)
--- a/resources/Resources.php
+++ b/resources/Resources.php
@@ -554,6 +554,7 @@ return array(
        ),
        'mediawiki.feedback' => array(
                'scripts' => 'resources/mediawiki/mediawiki.feedback.js',
+               'styles' => 'resources/mediawiki/mediawiki.feedback.css',
                'dependencies' => array( 
                        'mediawiki.api.edit', 
                        'mediawiki.Title',

diff --git a/resources/mediawiki/mediawiki.feedback.css b/resources/mediawiki/mediawiki.feedback.css
new file mode 100644 (file)
index 0000000..531c51d
--- /dev/null
+++ b/resources/mediawiki/mediawiki.feedback.css
@@ -0,0 +1,6 @@
+.feedback-spinner {
+       display: inline-block;
+       background: url(mediawiki.feedback.spinner.gif);
+       width: 18px;
+       height: 18px;
+}

diff --git a/resources/mediawiki/mediawiki.feedback.js b/resources/mediawiki/mediawiki.feedback.js
index e96d8c7..9a4a729 100644 (file)
--- a/resources/mediawiki/mediawiki.feedback.js
+++ b/resources/mediawiki/mediawiki.feedback.js
@@ -106,7 +106,7 @@
                                        $( '<div class="feedback-mode feedback-submitting" style="text-align:center;margin:3em 0;"></div>' ).append(
                                                mw.msg( 'feedback-adding' ),
                                                $( '<br/>' ),
-                                               $( '<img src="//upload.wikimedia.org/wikipedia/commons/4/42/Loading.gif" />' )
+                                               $( '<span class="feedback-spinner"></span>' )
                                        ),
                                        $( '<div class="feedback-mode feedback-thanks" style="text-align:center;margin:1em"></div>' ).msg(
                                                'feedback-thanks', _this.title.getNameText(), $feedbackPageLink.clone()

diff --git a/resources/mediawiki/mediawiki.feedback.spinner.gif b/resources/mediawiki/mediawiki.feedback.spinner.gif
new file mode 100644 (file)
index 0000000..aed0ea4
Binary files /dev/null and b/resources/mediawiki/mediawiki.feedback.spinner.gif differ