LogEventsList: Remove options not used by HTMLForm
authorBartosz Dziewoński <matma.rex@gmail.com>
Wed, 18 Jul 2018 17:45:40 +0000 (19:45 +0200)
committerBartosz Dziewoński <matma.rex@gmail.com>
Wed, 18 Jul 2018 17:55:07 +0000 (19:55 +0200)
HTMLForm gets the input value from the request. The values
specified in the form descriptor were never used. (You can specify a
default value, but that uses the 'default' key anyway.)

Change-Id: I27934e1118492371e547dd5e94feb172a0510cc9

includes/logging/LogEventsList.php

index aecbce9..95439b9 100644 (file)
@@ -280,7 +280,6 @@ class LogEventsList extends ContextSource {
                        'class' => 'HTMLTitleTextField',
                        'label-message' => 'speciallogtitlelabel',
                        'name' => 'page',
-                       'value' => $title,
                        'required' => false
                ];
        }
@@ -304,16 +303,10 @@ class LogEventsList extends ContextSource {
        private function getExtraInputsDesc( $types ) {
                if ( count( $types ) == 1 ) {
                        if ( $types[0] == 'suppress' ) {
-                               $offender = $this->getRequest()->getVal( 'offender' );
-                               $user = User::newFromName( $offender, false );
-                               if ( !$user || ( $user->getId() == 0 && !IP::isIPAddress( $offender ) ) ) {
-                                       $offender = ''; // Blank field if invalid
-                               }
                                return [
                                        'type' => 'text',
                                        'label-message' => 'revdelete-offender',
                                        'name' => 'offender',
-                                       'value' => $offender,
                                ];
                        } else {
                                // Allow extensions to add their own extra inputs