Deprecate QuickTemplate::msgHtml & fix phan-taint-warning in includes/skins
authorBrian Wolff <bawolff+wn@gmail.com>
Thu, 20 Sep 2018 04:31:21 +0000 (04:31 +0000)
committerKunal Mehta <legoktm@member.fsf.org>
Sat, 22 Sep 2018 00:27:43 +0000 (17:27 -0700)
commitf05bf4054089ac5394e2fd7bc60cc356446d20a2
tree3ed8d61fc844659b9925da38c61cecfb899239ee
parentfbc4c39708641f94cbf3a20a4283fc9f448c8175
Deprecate QuickTemplate::msgHtml & fix phan-taint-warning in includes/skins

QuickTemplate::msgHtml() (And the weird override that does the
same thing a different way - BaseTemplate::msgHtml()) are inherently
unsafe as they echo out a raw html message. This is strongly
discouraged in modern code. According to codeSearch tool, nothing
uses these methods, and there is a "@private" annotation on the
QuickTemplate::msgHtml() docblock. Thus hard deprecating it.

Change-Id: I4e9e157e922a36787adef4d0bf7608605c27f0c4
RELEASE-NOTES-1.32
includes/skins/BaseTemplate.php
includes/skins/QuickTemplate.php
includes/skins/Skin.php