From: Reedy <reedy@wikimedia.org>
Date: Sat, 7 Apr 2012 19:19:28 +0000 (+0100)
Subject: Fix assignment in conditional
X-Git-Tag: 1.31.0-rc.0~23972^2
X-Git-Url: http://git.cyclocoop.org/%27.parametre_url%28%20%20%20generer_action_auteur%28%27charger_plugin%27%2C%20%27update_flux%27%29%2C%27update_flux%27%2C%20%27oui%27%29.%27?a=commitdiff_plain;h=ef73a925807679e918f3ee5f05f0048566fce218;p=lhc%2Fweb%2Fwiklou.git

Fix assignment in conditional

Change-Id: I11e280daa4df6623a03892a59f9f7236dd4c98af
---

diff --git a/includes/specials/SpecialVersion.php b/includes/specials/SpecialVersion.php
index 777af416fa..2e2b003aa6 100644
--- a/includes/specials/SpecialVersion.php
+++ b/includes/specials/SpecialVersion.php
@@ -194,12 +194,16 @@ class SpecialVersion extends SpecialPage {
 		global $wgVersion;
 		wfProfileIn( __METHOD__ );
 
-		if( $gitVersion = self::getVersionLinkedGit() ) {
+		$gitVersion = self::getVersionLinkedGit();
+		if( $gitVersion ) {
 			$v = $gitVersion;
-		} elseif( $svnVersion = self::getVersionLinkedSvn() ) {
-			$v = $svnVersion;
 		} else {
-			$v = $wgVersion; // fallback
+			$svnVersion = self::getVersionLinkedSvn();
+			if( $svnVersion ) {
+				$v = $svnVersion;
+			} else {
+				$v = $wgVersion; // fallback
+			}
 		}
 
 		wfProfileOut( __METHOD__ );
@@ -207,7 +211,7 @@ class SpecialVersion extends SpecialPage {
 	}
 
 	/**
-	 * @return string wgVersion + a link to subversion revision of svn BASE 
+	 * @return string wgVersion + a link to subversion revision of svn BASE
 	 */
 	private static function getVersionLinkedSvn() {
 		global $wgVersion, $IP;