No need to do a database query when passing an IP address to User::idFromName()

diff --git a/includes/User.php b/includes/User.php
index cfceae0..b44bd60 100644 (file)
--- a/includes/User.php
+++ b/includes/User.php
@@ -475,6 +475,11 @@ class User {
                        return null;
                }
 
+               if ( User::isIP( $name ) ) {
+                       # Cannot exist
+                       return null;
+               }
+
                if ( isset( self::$idCacheByName[$name] ) ) {
                        return self::$idCacheByName[$name];
                }