From f18bf7963e976d4a17ced142bd78ef52d742f8e7 Mon Sep 17 00:00:00 2001
From: Aaron Schulz <aschulz@wikimedia.org>
Date: Thu, 24 Sep 2015 23:55:16 -0700
Subject: [PATCH] Put InfoAction distinct user counts behind miser mode

* The random I/O due to secondary lookups causes timeouts on
  larges pages that keep showing up in the logs.

Change-Id: I9bddcd3ba9ad5ff2f26ccec4553906ecc4a8129b
---
 includes/actions/InfoAction.php | 30 +++++++++++++++++-------------
 1 file changed, 17 insertions(+), 13 deletions(-)

diff --git a/includes/actions/InfoAction.php b/includes/actions/InfoAction.php
index f3670a8600..d9324e7527 100644
--- a/includes/actions/InfoAction.php
+++ b/includes/actions/InfoAction.php
@@ -555,9 +555,11 @@ class InfoAction extends FormlessAction {
 		);
 
 		// Total number of distinct authors
-		$pageInfo['header-edits'][] = array(
-			$this->msg( 'pageinfo-authors' ), $lang->formatNum( $pageCounts['authors'] )
-		);
+		if ( $pageCounts['authors'] > 0 ) {
+			$pageInfo['header-edits'][] = array(
+				$this->msg( 'pageinfo-authors' ), $lang->formatNum( $pageCounts['authors'] )
+			);
+		}
 
 		// Recent number of edits (within past 30 days)
 		$pageInfo['header-edits'][] = array(
@@ -718,20 +720,23 @@ class InfoAction extends FormlessAction {
 		// Total number of edits
 		$edits = (int)$dbr->selectField(
 			'revision',
-			'COUNT(rev_page)',
+			'COUNT(*)',
 			array( 'rev_page' => $id ),
 			__METHOD__
 		);
 		$result['edits'] = $edits;
 
 		// Total number of distinct authors
-		$authors = (int)$dbr->selectField(
-			'revision',
-			'COUNT(DISTINCT rev_user_text)',
-			array( 'rev_page' => $id ),
-			__METHOD__
-		);
-		$result['authors'] = $authors;
+		if ( $config->get( 'MiserMode' ) ) {
+			$result['authors'] = 0;
+		} else {
+			$result['authors'] = (int)$dbr->selectField(
+				'revision',
+				'COUNT(DISTINCT rev_user_text)',
+				array( 'rev_page' => $id ),
+				__METHOD__
+			);
+		}
 
 		// "Recent" threshold defined by RCMaxAge setting
 		$threshold = $dbr->timestamp( time() - $config->get( 'RCMaxAge' ) );
@@ -749,7 +754,7 @@ class InfoAction extends FormlessAction {
 		$result['recent_edits'] = $edits;
 
 		// Recent number of distinct authors
-		$authors = (int)$dbr->selectField(
+		$result['recent_authors'] = (int)$dbr->selectField(
 			'revision',
 			'COUNT(DISTINCT rev_user_text)',
 			array(
@@ -758,7 +763,6 @@ class InfoAction extends FormlessAction {
 			),
 			__METHOD__
 		);
-		$result['recent_authors'] = $authors;
 
 		// Subpages (if enabled)
 		if ( MWNamespace::hasSubpages( $title->getNamespace() ) ) {
-- 
2.20.1