From a65b660af918ba89c7ad7a3be52db14a070df451 Mon Sep 17 00:00:00 2001 From: Thomas Gries Date: Tue, 7 Jun 2011 22:30:06 +0000 Subject: [PATCH] quick fix for bug28983 . Do not use $path in the loop. Even the remaining $e is dangerous subject to change from the require-once-loaded extensions. This is NOT A FINAL fix, just a small improvement --- includes/installer/Installer.php | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/includes/installer/Installer.php b/includes/installer/Installer.php index 6c6a99f206..5c75f327af 100644 --- a/includes/installer/Installer.php +++ b/includes/installer/Installer.php @@ -1224,7 +1224,6 @@ abstract class Installer { global $IP; $exts = $this->getVar( '_Extensions' ); $IP = $this->getVar( 'IP' ); - $path = $IP . '/extensions'; /** * We need to include DefaultSettings before including extensions to avoid @@ -1240,7 +1239,7 @@ abstract class Installer { require( "$IP/includes/DefaultSettings.php" ); foreach( $exts as $e ) { - require_once( "$path/$e/$e.php" ); + require_once( $IP . '/extensions' . "/$e/$e.php" ); } $hooksWeWant = isset( $wgHooks['LoadExtensionSchemaUpdates'] ) ? -- 2.20.1