From 9bb397bd3a27390d39ab4edf028a1d8f82380433 Mon Sep 17 00:00:00 2001 From: Rob Church Date: Sat, 15 Apr 2006 15:18:33 +0000 Subject: [PATCH] *(bug 5426) Lowercase treatment of titles in rights log leads to broken links on Special:Log -- force title text to inital-uppercase when showing rights log text. Root of the problem lies with the extension in use on Wikimedia sites, however; will poke. --- RELEASE-NOTES | 2 +- includes/LogPage.php | 7 ++++++- languages/Messages.php | 2 +- 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/RELEASE-NOTES b/RELEASE-NOTES index fec035cac3..19a9bb598a 100644 --- a/RELEASE-NOTES +++ b/RELEASE-NOTES @@ -72,7 +72,7 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN * installer: cleanly outputbuffer when dieing out * Add $wgReservedUsernames configuration directive to block account creation/use * (bug 5576) Remove debugging hack in session check - +* (bug 5426) Lowercase treatment of titles in rights log leads to broken links on Special:Log == Compatibility == diff --git a/includes/LogPage.php b/includes/LogPage.php index 432f719026..cdd7840354 100644 --- a/includes/LogPage.php +++ b/includes/LogPage.php @@ -151,7 +151,8 @@ class LogPage { * @static */ function actionText( $type, $action, $title = NULL, $skin = NULL, $params = array(), $filterWikilinks=false, $translate=false ) { - global $wgLang; + global $wgLang, $wgContLang; + wfDebug( "LogPage::actionText called with title = {$title}, action = {$action}\n" ); static $actions = array( 'block/block' => 'blocklogentry', 'block/unblock' => 'unblocklogentry', @@ -194,6 +195,10 @@ class LogPage { $titleLink .= ' (' . $skin->makeKnownLinkObj( Title::makeTitle( NS_SPECIAL, 'Contributions/' . $title->getDBkey() ), wfMsg( 'contribslink' ) ) . ')'; } break; + case 'rights': + $text = $wgContLang->ucfirst( $title->getText() ); + $titleLink = $skin->makeLinkObj( Title::makeTitle( NS_USER, $text ) ); + break; default: $titleLink = $skin->makeLinkObj( $title ); } diff --git a/languages/Messages.php b/languages/Messages.php index 639a77d7e9..63345535dc 100644 --- a/languages/Messages.php +++ b/languages/Messages.php @@ -1334,7 +1334,7 @@ Type the name of the user in the box and press the button to make the user an ad 'setstewardflag' => 'Set steward flag', 'bureaucratlog' => 'Bureaucrat_log', 'rightslogtext' => 'This is a log of changes to user rights.', -'bureaucratlogentry' => "Changed group membership for $1 from $2 to $3", +'bureaucratlogentry' => 'changed group membership for $1 from $2 to $3', 'rights' => 'Rights:', 'set_user_rights' => 'Set user rights', 'user_rights_set' => "User rights for \"$1\" updated", -- 2.20.1