Mark A. Hershberger [Fri, 29 Jan 2010 07:25:09 +0000 (07:25 +0000)]
follow up r61357
* fix up fopen warnings — I was bedazzled by phpUnit's
set_error_handler that turned warnings into exceptions and Tim set
me right.
* Use Tim's read loop
* No need for private $fh member
* Fix some minor problems with PHP versions (no "timeout" param in
pre-5.2.1, POST issue in Hardy's PHP version where timeout is null.)
* Fix how tests are run on old versions of phpUnit.
Tim Starling [Fri, 29 Jan 2010 04:29:26 +0000 (04:29 +0000)]
Fix for r61582: if $wgDebugPrintHttpHeaders is false, don't construct the header string and then throw it away, skip the whole code block and save a few microseconds.
Chad Horohoe [Fri, 29 Jan 2010 02:37:51 +0000 (02:37 +0000)]
(bug 22310) Only need to declare $join_conds once
Tim Starling [Fri, 29 Jan 2010 00:51:08 +0000 (00:51 +0000)]
Fix careless errors in r61442 and r61444.
Aryeh Gregor [Fri, 29 Jan 2010 00:02:57 +0000 (00:02 +0000)]
stylize.php and fix whitespace for JSMin.php
Two spaces were being used for indentation instead of a tab, and for
some reason stylize.php didn't fix that, but repeated
s/^\(\( \)*\) /\1\t/ worked.
Alexandre Emsenhuber [Thu, 28 Jan 2010 21:58:50 +0000 (21:58 +0000)]
Step one in fixing OutputPage's documentation:
* Groupped methods by function
* Added documentation
* Fixed some doxygen warnings
* Some little style fixes
(more to come)
Raimond Spekking [Thu, 28 Jan 2010 21:54:45 +0000 (21:54 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-01-27 21:30 UTC)
Chad Horohoe [Thu, 28 Jan 2010 19:46:12 +0000 (19:46 +0000)]
Followup r61181, put @return nothing back on history(). Some people like it.
Jure Kajzer [Thu, 28 Jan 2010 14:58:45 +0000 (14:58 +0000)]
Fixed as per Tim's comments on r61179:
* made insertOneRow and getSequenceData private
* renamed fieldInfo to fieldInfoMulti and made it private (for internal use on Oracle only)
* wrapped fieldInfoMulti in fieldInfo with error if $table parameter is an array
* reverted tableName function to only support a non-array parameter
* wrapped all tableName calls with array parameter with array_map with callback
* wrapped fieldInfo into textFieldSize function to avoid reimplementation of functionality
* fixed unnessesary multiple calls to tableName with same parameter inside a single procedure
Roan Kattouw [Thu, 28 Jan 2010 12:46:50 +0000 (12:46 +0000)]
(bug 22286) Unicode 5.1 aliases for Malayam. This was done in the Wikimedia config at first, moving it into the trunk messages file per Siebrand
Aaron Schulz [Thu, 28 Jan 2010 08:57:34 +0000 (08:57 +0000)]
* Fixed $opts['tagfilter'] emptiness check
* Doc cleanup/spacing
Sam Reed [Thu, 28 Jan 2010 07:15:49 +0000 (07:15 +0000)]
Minor followup to r61609
If we're checking the key is *, no point reusing it, as we know what it is. Simplfy bug link/reference
OverlordQ [Thu, 28 Jan 2010 06:41:38 +0000 (06:41 +0000)]
Fix documentation errors (r61324)
Sam Reed [Wed, 27 Jan 2010 22:02:49 +0000 (22:02 +0000)]
* (bug 21922) YAML output should quote asterisk when used as key
Raimond Spekking [Wed, 27 Jan 2010 19:19:12 +0000 (19:19 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-01-27 19:00 UTC)
Chad Horohoe [Wed, 27 Jan 2010 19:14:18 +0000 (19:14 +0000)]
Use isset() instead of array_key_exists()
Jack D. Pond [Wed, 27 Jan 2010 19:08:31 +0000 (19:08 +0000)]
$mDesiredDestName property changed from protected to public. Used in extensions to check/validate/process user destination names in uploads.
Aryeh Gregor [Wed, 27 Jan 2010 18:59:52 +0000 (18:59 +0000)]
Use Html::element() for Xml::submitButton()
There are a bunch of other places where we could switch to Html methods
here too. See
<http://www.mediawiki.org/wiki/Special:Code/MediaWiki/61130#c5451>.
Niklas Laxström [Wed, 27 Jan 2010 17:21:18 +0000 (17:21 +0000)]
New configuration variables $wgDebugTimestamps and $wgDebugPrintHttpHeaders for controlling debug output.
I find these useful, maybe someone else will too.
Chad Horohoe [Wed, 27 Jan 2010 17:02:48 +0000 (17:02 +0000)]
Let crazy people run updates on broken setups like 5.3.1
Platonides [Wed, 27 Jan 2010 14:39:03 +0000 (14:39 +0000)]
Revert r61572. These titles are output parameters. A reference is the only way they can work correctly
(eg. think on a hook that always does 'return $titleResult = Title::newFromText("Foo");').
Platonides [Wed, 27 Jan 2010 11:52:35 +0000 (11:52 +0000)]
Apply r61570 (Follow-up r61150: Do not pass objects as references in new hooks).
This time in the correct place.
Tim Starling [Wed, 27 Jan 2010 09:50:19 +0000 (09:50 +0000)]
No jquery.ui for now.
Mark A. Hershberger [Wed, 27 Jan 2010 07:00:07 +0000 (07:00 +0000)]
Parser tests now working under phpunit
Mark A. Hershberger [Wed, 27 Jan 2010 06:58:15 +0000 (06:58 +0000)]
Break up tests so problems are easier to track down.
Mark A. Hershberger [Wed, 27 Jan 2010 06:51:42 +0000 (06:51 +0000)]
Make the instantiation tests actually work.
Tim Starling [Wed, 27 Jan 2010 05:17:26 +0000 (05:17 +0000)]
* Removed JS2 stuff from jquery.js. If there's anything we really need from it, it can be re-added to wikibits.js, but that can wait for the extension analysis which I'm going to do next.
* Added Ryan Grove's jsmin.php and wrote a maintenance script wrapper called minify.php
* Added a makefile to rebuild skins/common
* Rebuilt jquery.min.js
Tim Starling [Wed, 27 Jan 2010 04:17:49 +0000 (04:17 +0000)]
* Moved js2stopgap.js to skins/common/jquery.js, like I said I was going to do months ago.
* Add a $modules parameter to OutputPage::includeJQuery() so that we can include jquery.ui in the main UsabilityInitiative jQuery request in a reasonably flexible way, if we need to.
* Removed $wgExtensionJavascriptLoader, added in r61137 without explanation, seems to be the usual misspelt JS2/mwEmbed rubbish that I keep deleting.
Tim Starling [Wed, 27 Jan 2010 03:19:30 +0000 (03:19 +0000)]
Removed the nasty-looking JS-based position:fixed simulation, used by the "standard" (MW 1.0) skin for non-default "floating" quickbar settings in IE 6 and below. Appears to be broken anyway and nobody cares enough to fix it. To resolve r61071.
Conrad Irwin [Wed, 27 Jan 2010 03:06:56 +0000 (03:06 +0000)]
(bug 19600) don't display searchmenu-new when user has not got permission to
create the page.
Tim Starling [Wed, 27 Jan 2010 02:41:22 +0000 (02:41 +0000)]
Revert r61528, r61527, r61526, r61525, r61519, r61515, r61053, r61052 (Parser::doQuotes() rewrite). Lots of issues to discuss, needs more review than I have time to give it pre-1.16. I'll split it out to a branch.
Chad Horohoe [Wed, 27 Jan 2010 00:11:13 +0000 (00:11 +0000)]
Fix isSyndicated() description too
Chad Horohoe [Wed, 27 Jan 2010 00:09:25 +0000 (00:09 +0000)]
Make isSyndicated() return a boolean like its name, documentation and callers suggest it should
Alexandre Emsenhuber [Tue, 26 Jan 2010 20:52:55 +0000 (20:52 +0000)]
And while I'm at it: removed unused global declarations of $wgFeedClasses
Alexandre Emsenhuber [Tue, 26 Jan 2010 20:47:34 +0000 (20:47 +0000)]
Follow-up r61021: added some documentation per Tim's request
Greg Sabino Mullane [Tue, 26 Jan 2010 20:36:22 +0000 (20:36 +0000)]
Use 'AS' for column alias
Raimond Spekking [Tue, 26 Jan 2010 19:51:57 +0000 (19:51 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-01-26 19:15 UTC)
Platonides [Tue, 26 Jan 2010 18:58:07 +0000 (18:58 +0000)]
Step 4: Profit!!
Add and use PregSplitIterator instead of a direct preg_split.
Slower, but with an upper bound on memory usage.
Platonides [Tue, 26 Jan 2010 18:56:50 +0000 (18:56 +0000)]
Step 3: Balance the quotes directly on $text
Side effect: Some ' are converted to ' on output.
Platonides [Tue, 26 Jan 2010 18:55:56 +0000 (18:55 +0000)]
Step 2: Take out countBoldAndItalic()
Platonides [Tue, 26 Jan 2010 18:55:10 +0000 (18:55 +0000)]
Step 1: Apply attachment 2 from bug 18765.
Platonides [Tue, 26 Jan 2010 16:16:00 +0000 (16:16 +0000)]
Parser documentation:
"We are not counting sequences of five apostrophes." comment is wrong.
It was added on r4578, when they stopped being counted, but since r4747 (fixing bug 40) they are counted again.
Clarify what $first variables are.
Chad Horohoe [Tue, 26 Jan 2010 13:40:00 +0000 (13:40 +0000)]
Inform user of parsekit/php -l usage, fix line breaks in output
Platonides [Tue, 26 Jan 2010 11:57:01 +0000 (11:57 +0000)]
Cosmetic changes from r61052 comments:
else if -> elseif
Space after #
Prefer !== to !=
Tim Starling [Tue, 26 Jan 2010 03:10:44 +0000 (03:10 +0000)]
Revert r61005, r61047 (show copyright message on special pages). Maybe this could be configurable and off by default, but I'd be just as happy with an idiosyncratic change like this being a local patch.
OverlordQ [Mon, 25 Jan 2010 20:39:15 +0000 (20:39 +0000)]
Fix parser test broken by r61465
Raimond Spekking [Mon, 25 Jan 2010 19:38:21 +0000 (19:38 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-01-25 19:15 UTC)
Chad Horohoe [Mon, 25 Jan 2010 13:57:51 +0000 (13:57 +0000)]
Fixme on r57980: Memcached would be bad here, rename variable with wg prefix. Fixes to UsabilityInitiative will follow
Chad Horohoe [Mon, 25 Jan 2010 13:36:58 +0000 (13:36 +0000)]
Threading info type needs a name
Chad Horohoe [Mon, 25 Jan 2010 13:04:46 +0000 (13:04 +0000)]
(bug 22233) Update mediazilla default interwiki to point to correct domain
Tim Starling [Mon, 25 Jan 2010 04:59:46 +0000 (04:59 +0000)]
Made the bug #21793 test only check for the PHP 5.3.x version of the bug, and allow the PHP 5.2.x version. There isn't actually any reported MW bug arising from the 5.2.x version at this time.
Chad Horohoe [Mon, 25 Jan 2010 03:46:31 +0000 (03:46 +0000)]
Need a newline after this error
Aryeh Gregor [Sun, 24 Jan 2010 19:43:02 +0000 (19:43 +0000)]
Use Html::linkedScript()
Follow-up to r61432. This has a simpler call interface and encapsulates
ugly $wgJsMimeType nonsense.
Raimond Spekking [Sun, 24 Jan 2010 19:16:37 +0000 (19:16 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-01-24 19:00 UTC)
Siebrand Mazeland [Sun, 24 Jan 2010 17:15:21 +0000 (17:15 +0000)]
Revert r61405. Language code is only added if the core translation is at a reasonable level.
Use something like "$wgExtraLanguageNames['ltg'] = 'Latgaļu'; # Latgalian" if you really need support for languages without a basic localisation level.
Max Semenik [Sun, 24 Jan 2010 15:44:00 +0000 (15:44 +0000)]
Parser tests:
* Now defining a message in MediaWiki: namespace with !! article works
* Started covering image blacklisting with tests, only one basic test so far.
Roan Kattouw [Sun, 24 Jan 2010 12:11:18 +0000 (12:11 +0000)]
API: Support key-params arrays in 'descriptionmsg' in meta=siteinfo&siprop=extensions
Roan Kattouw [Sun, 24 Jan 2010 10:19:16 +0000 (10:19 +0000)]
API: (bug 22248) Output extension URLs in meta=siteinfo&siprop=extensions
Roan Kattouw [Sun, 24 Jan 2010 10:10:00 +0000 (10:10 +0000)]
API: Document the behavior added in r61447
Roan Kattouw [Sun, 24 Jan 2010 10:05:19 +0000 (10:05 +0000)]
Revert r61414 per CR comment: wfTimestampNow() doesn't take a TS_* parameter
Sam Reed [Sun, 24 Jan 2010 00:14:21 +0000 (00:14 +0000)]
minor followup to r61447, moving commment
Sam Reed [Sat, 23 Jan 2010 23:32:15 +0000 (23:32 +0000)]
* (bug 22245) blfilterredirect=nonredirects in blredirect mode wrongly filtering
If filterredir == 'nonredirects', only filter if !redirect
Sam Reed [Sat, 23 Jan 2010 23:10:47 +0000 (23:10 +0000)]
Less fail for 61445
Sam Reed [Sat, 23 Jan 2010 22:58:24 +0000 (22:58 +0000)]
Properly fix r61436/r61442
Sam Reed [Sat, 23 Jan 2010 22:52:40 +0000 (22:52 +0000)]
Normalise comment usage (# --> //)
Sam Reed [Sat, 23 Jan 2010 22:47:49 +0000 (22:47 +0000)]
More of r61437 (adding/removing whitespace)
Sam Reed [Sat, 23 Jan 2010 22:43:21 +0000 (22:43 +0000)]
Followup to r61436
-rakkaus:#mediawiki-i18n- [23-Jan-2010 22:40:23] PHP Notice: Undefined property: ApiQueryAllpages::$params in /www/w/includes/api/ApiQueryAllpages.php on line 62
Sam Reed [Sat, 23 Jan 2010 22:31:37 +0000 (22:31 +0000)]
Refactor array_intersect_key from ApiResult.php to GlobalFunctions.php
Niklas Laxström [Sat, 23 Jan 2010 22:30:21 +0000 (22:30 +0000)]
Log HTTP requests similar to SQL queries and other stuff
Sam Reed [Sat, 23 Jan 2010 22:26:40 +0000 (22:26 +0000)]
Add/remove whitelines to increase readability in API code files
Sam Reed [Sat, 23 Jan 2010 21:28:27 +0000 (21:28 +0000)]
Normalise check for filterredir in Allpages to that of backlinks
Add a couple of blank lines
Sam Reed [Sat, 23 Jan 2010 21:25:25 +0000 (21:25 +0000)]
filterredir is mutually exclusive (one value)
Change 2nd if for else if in both 1st and 2nd queries
Raimond Spekking [Sat, 23 Jan 2010 20:39:00 +0000 (20:39 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-01-23 20:15 UTC)
Niklas Laxström [Sat, 23 Jan 2010 20:15:39 +0000 (20:15 +0000)]
Use Html::element instead of Xml::element
It produces nicer output and has no braindeadiness with empty contents
Niklas Laxström [Sat, 23 Jan 2010 20:11:42 +0000 (20:11 +0000)]
Part 2 at solving conflict with vector and js edit
Add OutputPage::includeJQuery() for loading the jQuery currently shipped
with core. Extension can use this function to avoid loading it multiple
times. No support for plugins etc.
Changes Translate extension to use that function, restored compatability
with 1.15 for at least this part of code.
Alexandre Emsenhuber [Sat, 23 Jan 2010 20:07:17 +0000 (20:07 +0000)]
* Document a bit
* Fix some doxygen warnings
* Use spaces instead of tabs in the middle of lines
Alexandre Emsenhuber [Sat, 23 Jan 2010 19:00:56 +0000 (19:00 +0000)]
Avoid "PHP Warning: Division by zero in maintenance/mcc.php on line 92" if there's only a single server
Sam Reed [Sat, 23 Jan 2010 18:28:49 +0000 (18:28 +0000)]
RELEASE-NOTES for r61421
Roan Kattouw [Sat, 23 Jan 2010 17:48:02 +0000 (17:48 +0000)]
API: Fix bug where deprecated boolean parameters would always trigger the deprecated warning.
Bryan Tong Minh [Sat, 23 Jan 2010 15:27:53 +0000 (15:27 +0000)]
(bug 19528) Revert 55749: "according to the XSLT 1.0 spec, the MIME type should be text/xml or application/xml. In XSLT 2.0, it is application/xslt+xml. Either way, text/xsl is wrong." The mime type text/xsl is the only one supported by all modern browsers.
Sam Reed [Sat, 23 Jan 2010 15:25:14 +0000 (15:25 +0000)]
Stylise on ApiParse.php
Alexandre Emsenhuber [Sat, 23 Jan 2010 15:24:44 +0000 (15:24 +0000)]
* $fname -> __METHOD__
* some style fixes
Roan Kattouw [Sat, 23 Jan 2010 15:09:16 +0000 (15:09 +0000)]
Fix indentation in r61407. PLEASE don't use spaces for indentation, always use tabs.
Roan Kattouw [Sat, 23 Jan 2010 15:05:24 +0000 (15:05 +0000)]
Followup to r61412: don't use time(), we have our own function for this
Chad Horohoe [Sat, 23 Jan 2010 14:25:10 +0000 (14:25 +0000)]
Typo in comment, no such thing as wfGetFile()
Sam Reed [Sat, 23 Jan 2010 12:37:03 +0000 (12:37 +0000)]
* (bug 22240) - API: include time in siteinfo
Patch by Matthew Britton
Shinjiman [Sat, 23 Jan 2010 10:21:54 +0000 (10:21 +0000)]
Localisation updates Cantonese, Chinese and Literary Chinese
Mark A. Hershberger [Sat, 23 Jan 2010 06:23:18 +0000 (06:23 +0000)]
follow up r61356 -- remove global
Mark A. Hershberger [Sat, 23 Jan 2010 05:20:31 +0000 (05:20 +0000)]
follow up r61355
Alex Z [Sat, 23 Jan 2010 02:00:38 +0000 (02:00 +0000)]
Fix for r61391, which broke user JS. Use makeTitleSafe() instead of
newFromText(), use the NS_USER constant directly.
Robert Leverington [Fri, 22 Jan 2010 23:20:35 +0000 (23:20 +0000)]
Add new ISO 639-3 language code 'ltg' (Latgalian) to Names.php.
Bryan Tong Minh [Fri, 22 Jan 2010 21:37:29 +0000 (21:37 +0000)]
Fix undefined variable
Raimond Spekking [Fri, 22 Jan 2010 21:36:23 +0000 (21:36 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-01-22 21:15 UTC)
Max Semenik [Fri, 22 Jan 2010 21:30:23 +0000 (21:30 +0000)]
Special delivery for Nikerabbit: ability to connect to a SQLite db file directly, no foreplay with global settings needed.
Niklas Laxström [Fri, 22 Jan 2010 20:39:03 +0000 (20:39 +0000)]
Wrap skin specific user js addition inside Title::exists
This should help to reduce unnecessary requests, especially where action=raw is serving
uncached 404 responses in some uncommon configurations.
Max Semenik [Fri, 22 Jan 2010 20:36:26 +0000 (20:36 +0000)]
Fixed r61214: moved MySQL munging to SearchEngine, updated calls. Can we kill $doStrip now?
Alexandre Emsenhuber [Fri, 22 Jan 2010 19:58:13 +0000 (19:58 +0000)]
Fixed some doxygen warnings
Chad Horohoe [Fri, 22 Jan 2010 19:50:37 +0000 (19:50 +0000)]
Revert part of r61382, unrelated change
Chad Horohoe [Fri, 22 Jan 2010 19:48:10 +0000 (19:48 +0000)]
Clarify parameters to wfFindFile and wfLocalFile, and return caveat to the "This always returns files" comment
Alexandre Emsenhuber [Fri, 22 Jan 2010 18:43:59 +0000 (18:43 +0000)]
* Fix E_STRICT errors about functions not having same signature
* Added missing functions that are in Title but not FakeTitle