Aaron Schulz [Thu, 10 May 2018 19:46:23 +0000 (12:46 -0700)]
resourceloader: avoid use of $.globalEval in mediawiki.js
Bug: T192623
Change-Id: Icdd5d76546a6c265a8e941c4e9b28f73bf9dd028
jenkins-bot [Fri, 11 May 2018 22:05:22 +0000 (22:05 +0000)]
Merge "Allow 'all:' on all wikis in addition to 'searchall' translation"
Translation updater bot [Fri, 11 May 2018 19:59:40 +0000 (21:59 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I51c74d19d11c6eda9fbd78aa55eeba4b3e56f1c9
Timo Tijhof [Thu, 10 May 2018 17:38:34 +0000 (18:38 +0100)]
resources: Give mediawiki.special.* files their own place in src/
Bug: T193826
Change-Id: Id25cd18079f48308f6ab42207445bbbd74ed5fda
jenkins-bot [Fri, 11 May 2018 17:18:08 +0000 (17:18 +0000)]
Merge "OOUI prefs: Use late static binding"
jenkins-bot [Fri, 11 May 2018 16:07:33 +0000 (16:07 +0000)]
Merge "build: update to grunt-contrib-watch@1.0.1 to resolve a vulnerability"
jenkins-bot [Fri, 11 May 2018 15:25:48 +0000 (15:25 +0000)]
Merge "Remove 'patrol' from $wgActionFilteredLogs"
Željko Filipin [Fri, 11 May 2018 14:30:32 +0000 (16:30 +0200)]
build: update to grunt-contrib-watch@1.0.1 to resolve a vulnerability
Recommended by `npm audit`.
Moves us from
21 vulnerabilities ... 12 Low | 5 Moderate | 4 High
to
20 vulnerabilities ... 11 Low | 5 Moderate | 4 High
Bug: T194280
Change-Id: I9d6d2fed4ca3d4c43d9b5085873210493081f7e0
David Causse [Fri, 11 May 2018 13:04:49 +0000 (15:04 +0200)]
Allow 'all:' on all wikis in addition to 'searchall' translation
This allows to have a common syntax useable everywhere.
Bug: T165110
Change-Id: If71fe5df045fb754925946088f8f793197bc8301
Ed Sanders [Fri, 11 May 2018 08:55:59 +0000 (09:55 +0100)]
OOUI prefs: Use late static binding
Allow sub-classes to disable OOUI for now (e.g. GlobalPrefs).
Change-Id: Ic3ff878b5f0ba7ec4162fab09fe1b9e10a820095
Bartosz Dziewoński [Tue, 8 May 2018 11:43:10 +0000 (13:43 +0200)]
IcuCollation: Use codepoint as tiebreaker when getting first-letters
This prevents unexpected cuneiform digits from acting as headings for
2 and 3 on category pages.
Bug: T187645
Change-Id: I0424a24769899cb23b28704f97e1002fa44999fd
jenkins-bot [Thu, 10 May 2018 23:18:46 +0000 (23:18 +0000)]
Merge "docs: Rename README to README.md"
jenkins-bot [Thu, 10 May 2018 22:26:06 +0000 (22:26 +0000)]
Merge "rdbms: use ILoadBalancer in more LBFactory comments"
jenkins-bot [Thu, 10 May 2018 20:23:43 +0000 (20:23 +0000)]
Merge "resourceloader: Remove use of $.isPlainObject() from mw.Map#set()"
Timo Tijhof [Mon, 7 May 2018 22:34:20 +0000 (23:34 +0100)]
resourceloader: Remove use of $.isPlainObject() from mw.Map#set()
Look for typeof 'object' instead. The set() method has good test
coverage which uncovered a few cases that were previously only
working implicitly due to isPlainObject.
* Test case `mw.config.set( [], 'value' )`
This is invalid because `key` must be a string. This was previously
rejected because while array is an object, it isn't a plain object.
This commit intends to remove this distinction and allow any object
to be used with the set(Object) signature. However, we should still
reject set(non-string, string) no matter what kind of object is passed.
Changing from isPlainObject to 'is an object' made this case
wrongly pass instead of fail (because arrays are objects). Fix that,
as well as any other case of non-string as key, by making the code
explicitly reject non-string keys when two arguments are given.
Added test case for `mw.config.set( {}, value ) === false` that did
not pass without the changes in src/.
* Missing `> 1` check in global #set(). The check for arguments.length
was asserting truthiness (non-zero) rather than >1 (2 or more).
This was causing things like `mw.config.set('key')` to throw
"ReferenceError: value not defined" when the underlying mw.Map
is global. The normal #set() method for maps other than mw.config,
was already fine.
Fixed a bug in mediawiki.language.init that was revealed by this.
The bug was not happening previously because when an object
was passed, the second parameter was ignored.
Bug: T192623
Change-Id: Ib53647b324fe3d31e3389ed9aa14a08280d9c830
L10n-bot [Thu, 10 May 2018 20:03:34 +0000 (20:03 +0000)]
Merge "Localisation updates from https://translatewiki.net."
Translation updater bot [Thu, 10 May 2018 20:03:24 +0000 (22:03 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I6b9a40e5d652ca8ff935546721309e07b2f7dd0b
Bartosz Dziewoński [Mon, 7 May 2018 18:48:01 +0000 (20:48 +0200)]
LogPager/LogEventsList: Correct docs about $pattern parameter
$pattern is a boolean, it is documented as "Do a prefix search rather
than an exact title match". However, its type was incorrectly
documented to be a string, and the default value was '' instead of
false (which was harmless, as it is correctly treated as a boolean
value everywhere).
Change-Id: Id093d12891a231d5934f9908e619065afff7380e
jenkins-bot [Thu, 10 May 2018 19:34:14 +0000 (19:34 +0000)]
Merge "mediawiki.skinning: Only apply tright/tleft margins to frame/thumb"
jenkins-bot [Thu, 10 May 2018 19:07:18 +0000 (19:07 +0000)]
Merge "rdbms: fix callback stage errors in LBFactory::commitMasterChanges"
Arlo Breault [Thu, 3 May 2018 17:07:39 +0000 (13:07 -0400)]
mediawiki.skinning: Only apply tright/tleft margins to frame/thumb
The other formats should correspond to the margins for
floatright/floatleft.
Bug: T193695
Change-Id: I19ff964bcac486e8d45e7deab40f9220295bf9f6
jenkins-bot [Thu, 10 May 2018 18:28:49 +0000 (18:28 +0000)]
Merge "build: Update Karma to v2.0.2"
jenkins-bot [Thu, 10 May 2018 16:48:11 +0000 (16:48 +0000)]
Merge "Set the package type to 'mediawiki-core'"
jenkins-bot [Thu, 10 May 2018 15:59:02 +0000 (15:59 +0000)]
Merge "Create update SPARQL for category changes"
Željko Filipin [Thu, 10 May 2018 15:04:32 +0000 (17:04 +0200)]
build: Update Karma to v2.0.2
The current version has a couple of dependencies with high severity
vulnerabilities.
Bug: T194280
Change-Id: I3f9f36a6a5c2ba1716b91d14e59bc60f9e0ff513
Timo Tijhof [Thu, 10 May 2018 14:56:39 +0000 (15:56 +0100)]
docs: Rename README to README.md
The only wikitext-speficic syntax in here is the title.
Renaming this to Markdown has various benefits:
* Makes the README render properly on Gitiles, Doxygen, and Diffusion.
The current README is not renderable in Gitiles or Doxygen.
* More familiar to new contributors in open-source.
* Consistent with other documentation content we maintain within Git,
including all PHP and JS documentation, which via JSDoc/JSDuck/Doxygen
have all their descriptions parsed in Markdown.
* Rich previews and syntax highlighting in many text editors
and Git viewers.
Change-Id: I5bade76528fa3d870334d960c39db009644bb58f
jenkins-bot [Thu, 10 May 2018 14:36:33 +0000 (14:36 +0000)]
Merge "build: Update Karma's qunit from 2.5.0 to 2.6.0"
Timo Tijhof [Thu, 10 May 2018 13:12:17 +0000 (14:12 +0100)]
build: Update Karma's qunit from 2.5.0 to 2.6.0
Follows-up
065b21b4bd which updated the copy of QUnit used
on Special:JavaScriptTest.
Change-Id: I24b17c9c266f58d48caa9c3392496c469b3ddba0
Željko Filipin [Thu, 10 May 2018 12:13:45 +0000 (14:13 +0200)]
Fix a critical NPM package vulnerability
NPM v6 audits packages during installation. This is the only critical vulnerability.
Bug: T194280
Change-Id: I5fe35067919ad67b9781701136e290eda17c3afa
Aaron Schulz [Thu, 10 May 2018 04:14:40 +0000 (21:14 -0700)]
rdbms: fix callback stage errors in LBFactory::commitMasterChanges
Just like
082ed053b6 fixed pre-commit callback errors when new instances
of LoadBalancer are made during that step, do the same for post-commit
callbacks.
Bug: T194308
Change-Id: Ie79e0f22b3aced425cf067d0df6b67e368223e6c
Aaron Schulz [Thu, 10 May 2018 04:25:38 +0000 (21:25 -0700)]
rdbms: use ILoadBalancer in more LBFactory comments
Change-Id: I4fdf7f77df266e8a025930f01760b797c996bc69
Derk-Jan Hartman [Tue, 8 May 2018 20:46:56 +0000 (22:46 +0200)]
makeCollapsible: fix state of nested collapsibles
When collapsing or expanding an element which has nested other
collapsibles, the labels of all nested toggles were updating to the
value of the parent, while their state was not.
Apply to the specific toggle only, just as the classes are applied to
just the specific toggle.
Bug: T168689
Change-Id: I1c3c29dc9ca4ccbf8da83796e56964a7a6d58a81
jenkins-bot [Wed, 9 May 2018 23:45:02 +0000 (23:45 +0000)]
Merge "resources: Move the remaining src/mediawiki/ files"
Timo Tijhof [Wed, 9 May 2018 20:36:06 +0000 (21:36 +0100)]
resources: Move the remaining src/mediawiki/ files
Single-file modules to src/, the remaining as sub directories.
A few highlights:
* mediawiki.Upload.BookletLayout. (stylesheet: no image references)
* mediawiki.feedback - Also move the image to its own images/ subdir.
* mediawiki.searchSuggest. (stylesheet: no image references)
* mediawiki.toc. (stylesheet: no image references)
Also updated any other references to 'src/mediawiki/' that I could find
in core:
* Fixed references in docs/uidesign/*.html
* Remove redundant exclude from jsduck.json.
After this, there are 4 files remaining in src/mediawiki,
which are the 4 files used by the actual 'mediawiki' base module.
Bug: T193826
Change-Id: I8058652892a78b3f5976397bd850741dd5c92427
jenkins-bot [Wed, 9 May 2018 22:36:44 +0000 (22:36 +0000)]
Merge "rdbms: rename onTransactionIdle() to onTransactionCommitOrIdle()"
Timo Tijhof [Fri, 4 May 2018 00:23:39 +0000 (01:23 +0100)]
skins: Update core skins to queue modules via getDefaultModules()
Following I3404c1c2a7e, update the core skins to use
getDefaultModules() instead of the now-deprecated setupSkinUserCss().
Change-Id: I48b76938f46c1b6b683b618e7571e6fc6876cc52
jenkins-bot [Wed, 9 May 2018 22:07:46 +0000 (22:07 +0000)]
Merge "rdbms: fix LBFactory::commitAll() round handling"
Aaron Schulz [Wed, 9 May 2018 21:44:34 +0000 (14:44 -0700)]
rdbms: fix LBFactory::commitAll() round handling
This avoids "Transaction round stage must be approved (not cursory)".
Bug: T194308
Change-Id: I9dbfe9cede02b1b1904c1d5e5a9802306c2492a2
jenkins-bot [Wed, 9 May 2018 21:25:43 +0000 (21:25 +0000)]
Merge "mediawiki.htmlform: Move files to their own module directory"
Aaron Schulz [Wed, 9 May 2018 02:28:39 +0000 (19:28 -0700)]
rdbms: rename onTransactionIdle() to onTransactionCommitOrIdle()
This is clearer and is consistent with onTransactionPreCommitOrIdle()
Change-Id: I3a34a0e9adea69ec55ed6ddfef47703e31e7c3b5
jenkins-bot [Wed, 9 May 2018 21:00:52 +0000 (21:00 +0000)]
Merge "Add default edit rate limit of 90 edits/minute for all users"
Timo Tijhof [Wed, 9 May 2018 19:10:05 +0000 (20:10 +0100)]
mediawiki.htmlform: Move files to their own module directory
* mediawiki.htmlform.styles:
- mediawiki/htmlform/styles.css
- mediawiki/htmlform/images/*
Only contains two images, only used by this module.
* mediawiki.htmlform.checker.js.
* mediawiki.htmlform.ooui: Only Element.js.
* mediawiki.htmlform.ooui.styles.less.
* mediawiki.htmlform: Other files from mediawiki/htmlform.
Bug: T193826
Change-Id: I5c057c758933e905d5c7940ade5bf43282088159
Brian Wolff [Wed, 9 May 2018 20:43:51 +0000 (20:43 +0000)]
Add default edit rate limit of 90 edits/minute for all users
Previously there was no rate limit at all if you were autoconfirmed.
This initial setting is set on the high end of things, we may
adjust later. See also T192668, T194204.
Change-Id: I7cb002900bae2da3f4f4758671186659c1720e1d
Amir Sarabadani [Tue, 8 May 2018 21:11:51 +0000 (23:11 +0200)]
Remove 'patrol' from $wgActionFilteredLogs
We disabled logging autopatrol actions and we are deleting them.
Thus having patrol subtypes filters in Special:Log doesn't make
sense anymore.
Bug: T194213
Change-Id: I421ee54040cd2b64e53f1e68016c74a163d89ed3
jenkins-bot [Wed, 9 May 2018 20:17:26 +0000 (20:17 +0000)]
Merge "Remove width restriction on gadget labels"
jenkins-bot [Wed, 9 May 2018 20:17:23 +0000 (20:17 +0000)]
Merge "mediawiki.page.gallery.styles: Move files to src/"
Translation updater bot [Wed, 9 May 2018 20:16:02 +0000 (22:16 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I7ca3a4f519cab7221f8e37c50baf2f6e666fa70e
jenkins-bot [Wed, 9 May 2018 20:00:14 +0000 (20:00 +0000)]
Merge "resourceloader: Remove elaborate dom-based console shim"
Ed Sanders [Mon, 23 Apr 2018 19:14:31 +0000 (20:14 +0100)]
Remove width restriction on gadget labels
Bug: T181733
Change-Id: Ia4bb7f49f89dbd62a21dd125e6a209a4f176844d
Timo Tijhof [Wed, 9 May 2018 19:18:28 +0000 (20:18 +0100)]
mediawiki.page.gallery.styles: Move files to src/
The two CSS files belonging to this module are the last ones
remaining in src/mediawiki/page. Move them to their own directory
in src/ instead. The stylesheets don't reference any images.
Bug: T193826
Change-Id: Ic07bbd5b60668a437177b389aa8fee861eb11892
Timo Tijhof [Wed, 9 May 2018 17:40:57 +0000 (18:40 +0100)]
resources: Move more various single-file mediawiki.* modules to src/
* Reduce clutter in src/mediawiki/.
* Make these files and modules easier to discover and associate.
Follows-up I677edac3b5e, which only moved simple cases where no
related modules existed.
This commit also moves files for modules that have some related
multi-file modules. As well as files that previously did not
strictly have their path match directly to their module name.
For example:
- 'mediawiki.checkboxtoggle.css' to 'mediawiki.checkboxtoggle.styles.css',
because its module name is 'mediawiki.checkboxtoggle.styles'.
- 'mediawiki/page/gallery-slideshow.js' to 'mediawiki.page.gallery.slideshow.js',
because its module name uses a dot, not a dash.
- 'mediawiki/page/watch.js' to 'mediawiki.page.watch.ajax.js',
because its module name also includes 'ajax'. This also makes it matches
the way "mediawiki.page.patrol.ajax" files were already named.
Ideas for later:
- Consider merging 'mediawiki.ForeignApi' and 'mediawiki.ForeignApi.core.'.
- Consider merging 'mediawiki.page.ready' and 'mediawiki.page.startup'.
Bug: T193826
Change-Id: I9564b05df305b7d217c9a03b80ce92476279e5c8
jenkins-bot [Wed, 9 May 2018 19:13:55 +0000 (19:13 +0000)]
Merge "resources: Move various single-file mediawiki.* modules to src/"
jenkins-bot [Wed, 9 May 2018 19:13:51 +0000 (19:13 +0000)]
Merge "build: Convert jsduck.json whitelist to blacklist"
jenkins-bot [Wed, 9 May 2018 18:52:42 +0000 (18:52 +0000)]
Merge "Introduce change_tag_def table"
Timo Tijhof [Wed, 9 May 2018 17:40:57 +0000 (18:40 +0100)]
resources: Move various single-file mediawiki.* modules to src/
This moves all files belonging to a 'mediawiki.*' module containing
only a single JavaScript file with no references to other files.
* Reduce clutter in src/mediawiki/.
* Make these files and modules easier to discover and associate.
Bug: T193826
Change-Id: I677edac3b5e9d02208c87164382c97035409df63
Timo Tijhof [Wed, 9 May 2018 17:55:20 +0000 (18:55 +0100)]
build: Convert jsduck.json whitelist to blacklist
This will make it a lot easier to move files from src/mediawiki/
to src/ without having to enumerate each file because previously
it was included by "src/mediawiki" entirely, but we can't include
"src/" entirely because of the implicitly excluded files.
Bug: T193826
Change-Id: Ib1b1a2e851d2cb8f1426a0d16343adcd6344a14f
jenkins-bot [Wed, 9 May 2018 18:14:07 +0000 (18:14 +0000)]
Merge "mediawiki.notification: Move files to their own directory"
jenkins-bot [Wed, 9 May 2018 18:14:03 +0000 (18:14 +0000)]
Merge "Don't initialize MediaWikiServices before extensions have been loaded"
jenkins-bot [Wed, 9 May 2018 18:14:00 +0000 (18:14 +0000)]
Merge "Update OOUI to v0.27.0"
jenkins-bot [Wed, 9 May 2018 17:42:41 +0000 (17:42 +0000)]
Merge "jquery.tablesorter: Move files to their own directory"
jenkins-bot [Wed, 9 May 2018 17:42:38 +0000 (17:42 +0000)]
Merge "mediawiki.messagePoster: Move WikitextMessagePoster.js to its own directory"
Timo Tijhof [Wed, 9 May 2018 17:27:44 +0000 (18:27 +0100)]
resourceloader: Remove elaborate dom-based console shim
This was a hack loosely inspired by Firebug Lite, that essentially
created a footer toolbar like the one from "mediawiki.debug", and
write console messages to it, if the browser doesn't have a console
natively.
We don't currently support any browsers in JS-mode that don't have
a console feature of some kind.
I'm keeping the file for now, because it is still useful for
mw.log (not to be confused with mw.log.warn or mw.log.error) to
not do anything in production mode by default. This because there
can be significant overhead from writing to real console object,
regardless of the fact that it isn't visible in browsers by default.
Test Plan:
* Both before and after this commit,
- On a normal page view, `mw.log("msg")` does nothing when run
from the browser console.
- On a page with ?debug=true, `mw.log("msg")` acts
like `console.log("msg")` would.
Bug: T192623
Change-Id: Ifc8dd91f473c9235e1d4e27c202c97802530a272
Timo Tijhof [Wed, 9 May 2018 17:01:59 +0000 (18:01 +0100)]
mediawiki.notification: Move files to their own directory
* Reduce clutter in src/mediawiki/.
* Make it easier to see from the repo structure which files
belong to this module, and which files not. For example,
'mediawiki.notification.convertmessagebox' and 'mediawiki.notify' are
logically related, but not actually part of this 4-file module.
Bug: T193826
Change-Id: I274323dffa8af1d046beb21d88f633f432a6ebbc
jenkins-bot [Wed, 9 May 2018 17:28:00 +0000 (17:28 +0000)]
Merge "Add equals() to UserIdentity"
Volker E [Wed, 9 May 2018 01:38:43 +0000 (18:38 -0700)]
Update OOUI to v0.27.0
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.27.0
Depends-on: I40dc6a2441fcd37e785f11b7a5e2f5da932e94df
Change-Id: I2acf232fd172d176b305d65d88db5b7bbfe34b88
Timo Tijhof [Wed, 9 May 2018 17:12:15 +0000 (18:12 +0100)]
jquery.tablesorter: Move files to their own directory
* Reduce clutter in src/jquery/.
* Make it easier to see which files belong to which module, especially
src/jquery/images/ which was confusingly shared between multiple modules.
This also helps emphasize that while jquery.tablesorter.less is included,
jquery.tablesorter.styles.less is not.
Also follows-up
8cdfcc5fd, which placed its style-module definition among
the 'mediawiki.*' modules instead of near the 'jquery.*' modules.
Change-Id: Ib639de5df323a36982ecdd89158a939beaaa2dd3
Timo Tijhof [Fri, 4 May 2018 02:12:18 +0000 (03:12 +0100)]
mediawiki.messagePoster: Move WikitextMessagePoster.js to its own directory
It was currently in the directory for 'mediawiki.messagePoster', but this
file actually belongs to a different module.
Bug: T193826
Change-Id: Ia51d2a373173c1bc7fe78196dbef89089c51ac86
jenkins-bot [Wed, 9 May 2018 16:50:55 +0000 (16:50 +0000)]
Merge "resourceloader: Remove AJAX call from addScript() in mediawiki.js"
Timo Tijhof [Wed, 2 May 2018 17:48:24 +0000 (18:48 +0100)]
selenium: Initial version of wdio-mediawiki package
This is new package will be reusable by other repositories for
their browser tests, without having to reference the internal
selenium/pageobjects/ directory from MediaWiki core.
In addition to not requiring direct imports, it will also avoid
problems in the future by allowing the package to be versioned
and iterated upon without forcing an atomic global upgrade
(or broken master builds), everytime we change something.
See wdio-mediawiki/README for details.
Within MediaWiki core itself, the package is used using the
'file' specifier in its package.json, so that we always test
and develop using its working copy, which makes drafting and
testing changes easier.
Also misc changes to make wdio.conf easier to understand.
Bug: T193088
Change-Id: I547a7899e7a97693a93567dd763784e637433d55
Timo Tijhof [Wed, 2 May 2018 22:47:16 +0000 (23:47 +0100)]
selenium: Create local ./log directory if needed
Without this, the tests sometimes fail like this:
> Error: ENOENT: no such file or directory, open './log/should-be-creatable.png'
> at screenshot() - saveScreenshot.js:52:17
> at saveScreenshot("./log/should-be-creatable.png")
This seems to race with the junit plugin, which uses mkdirp to
create it if missing, but the screenshot handling is separate
from that. WebdriverIO's own screenshot handling also does this
so it makes sense for ours to do that, too.
I considered trying to re-use WebdriverIO's save mechanism,
directly but it's not publicly exposed and only used for the
crash scenario, so for now we'll have to keep our own.
Also:
* Add to gitignore.
* Update default to use __dirname instead of './' because the
latter will somtimes be mediawiki/ and sometimes be selenium/
depending on whether you run all tests or some tests.
* Remove trailing slash from default logPath, and instead add the
slash in filePath.
Reason:
- The LOG_DIR used by Jenkins doesn't end in a slash either
(currently not failing because we no longer use that job,
and let quibble run the tests instead, which doesn't set
the LOG_DIR).
- The WDIO docs and example also use screenshotPath without
trailing slash.
- Without this, setting LOG_DIR=/tmp/something results in
filenames like /tmp/somethingexample.png.
Bug: T193088
Change-Id: I6550f9315bae89f96a791f7ae8cc2fbec5ee8dd5
jenkins-bot [Wed, 9 May 2018 13:27:08 +0000 (13:27 +0000)]
Merge "[MCR] Introduce RevisionSlotsUpdate."
jenkins-bot [Wed, 9 May 2018 12:01:56 +0000 (12:01 +0000)]
Merge "search: Add result ranking in MySQL"
Fomafix [Wed, 21 Mar 2018 19:11:05 +0000 (20:11 +0100)]
Names.php: Add missing LTR markers after closing parentheses
Currently some language autonyms with parentheses have misaligned
parentheses on RTL environment on some browser. To reproduce open
index.php?title=Special:Preferences&uselang=en-rtl
Google Chrome is affected. Mozilla Firefox is not affected.
This changes fixes this problem like at the other autonyms with
parentheses.
Change-Id: Ie01116821b067017434681ea995e97ada8ff0a6d
jenkins-bot [Wed, 9 May 2018 04:36:45 +0000 (04:36 +0000)]
Merge "Change language name of ko-kp to 조선말"
Aaron Schulz [Tue, 8 May 2018 21:58:01 +0000 (14:58 -0700)]
resourceloader: Remove AJAX call from addScript() in mediawiki.js
Bug: T192623
Change-Id: If38376cb987c273b9991129df8f9a2ae04cfa4ed
Aaron Schulz [Tue, 8 May 2018 21:39:29 +0000 (14:39 -0700)]
resourceloader: Move always() call to addScript() in mediawiki.js
Bug: T192623
Change-Id: Ic0134baf0b501354c8713c7dad6a2e5b7f185793
jenkins-bot [Tue, 8 May 2018 21:42:44 +0000 (21:42 +0000)]
Merge "resourceloader: Avoid jQuery usage in queueModuleScript"
jenkins-bot [Tue, 8 May 2018 21:38:59 +0000 (21:38 +0000)]
Merge "Preserve 'ooui' query string when overriding"
jenkins-bot [Tue, 8 May 2018 21:32:01 +0000 (21:32 +0000)]
Merge "Special:Preferences: Create flag to enable OOjs UI"
Aaron Schulz [Tue, 8 May 2018 10:44:33 +0000 (03:44 -0700)]
resourceloader: Avoid jQuery usage in queueModuleScript
Bug: T192623
Change-Id: I46db7883c309cdec3722dd2d6169cf239bb113fb
Ed Sanders [Thu, 3 May 2018 13:17:41 +0000 (14:17 +0100)]
Preserve 'ooui' query string when overriding
Change-Id: I32df23b427f18e6275beaa6cc10cd58dc3b6eb36
Translation updater bot [Tue, 8 May 2018 19:58:14 +0000 (21:58 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I9929e2ade53186340619aeceece3e1eed6166985
jenkins-bot [Tue, 8 May 2018 19:26:04 +0000 (19:26 +0000)]
Merge "BotPasswords: Indicate when a password needs reset"
jenkins-bot [Tue, 8 May 2018 19:21:24 +0000 (19:21 +0000)]
Merge "Fall back to default language when no i18n'ed licenses available"
Amir Sarabadani [Fri, 4 May 2018 17:29:53 +0000 (19:29 +0200)]
Introduce change_tag_def table
Table defining tag names for IDs. Also stores hit counts to avoid expensive queries on change_tag
See T185355 for more information
Bug: T193867
Bug: T185355
Change-Id: I4fd943589b3ed304471304c8beda15327a8edbcf
jenkins-bot [Tue, 8 May 2018 15:46:14 +0000 (15:46 +0000)]
Merge "tidy: Remove obsolete Depurate and Balancer drivers"
Kunal Mehta [Mon, 7 May 2018 08:34:13 +0000 (01:34 -0700)]
tidy: Remove obsolete Depurate and Balancer drivers
The Html5Depurate driver was intended to be used with an external Java
service, but it never gained traction due to deployment concerns.
The Html5Internal (Balancer) driver was originally intended for use with
the balanced templates proposal and could also handle tidying. But it was
tightly coupled to MediaWiki, so part of it was used as the basis of the
RemexHtml library. Remex most likely can also implement the balanced
templates proposal, so there isn't any reason to keep the Balancer code
around anymore,
Change-Id: I8542d69e9cdbf0e2fb7ebbb919933a64c1b8c293
jenkins-bot [Tue, 8 May 2018 15:26:29 +0000 (15:26 +0000)]
Merge "jquery.makeCollapsible: Fix typo in documentation"
jenkins-bot [Tue, 8 May 2018 15:16:43 +0000 (15:16 +0000)]
Merge "selenium: Minor clean-up in preparation for packaging"
Timo Tijhof [Wed, 2 May 2018 03:48:36 +0000 (04:48 +0100)]
selenium: Minor clean-up in preparation for packaging
This is functionally a no-op, purely refactoring (mostly style).
* Consistently require packages at the top of a file.
(e.g. MWBot in edit.page.js).
* Remove unused .call(this) from mwbot interaction closures,
which didn't use 'this'.
* Use Node.js regular Promise chaining with then(), instead of
complex bluebird.coroutine generator function yields, which
are intended to emulate async-await, but the syntax is quite
error-prone for inexperienced developers and hard to debug.
Once we require Node 7+ for the selenium tests, we can use
async-await here natively, but until then, might as well use
regular then() syntax, which we already use elsewhere in the
tests, and is also what MWBot documentation uses.
* Also applied some minor whitespace changes for consistency
among these files and other MediaWiki JS. E.g. no empty line
before the first statement of a function. Add a new line between
different methods, and between the end of a class and the
export statement.
* Remove 'use strict' from test files. The patterns that would expose
the bad non-strict behaviour are mostly already forbidden by ESLint,
and the run-time optimisation to disable non-strict can't be noticed
in tests (more useful in prod where e.g. the same process would run
a function 1 million times). Main reason here is to keep things
simple for new-comers and reduce boilerplate, given that these tests
will mainly be worked on by browser-JS developers, not Node.js devs,
and we don't currently use strict mode in our front-end code, either.
* Remove unused bluebird dependency.
Bug: T193088
Change-Id: I59f9211299e8e884c28c7733bcee3b7b28542610
Gergő Tisza [Tue, 8 May 2018 14:31:03 +0000 (16:31 +0200)]
Add equals() to UserIdentity
Change-Id: Ia2f33d551e96bd6f58ba9414049449282575a63b
Bartosz Dziewoński [Tue, 8 May 2018 14:17:41 +0000 (16:17 +0200)]
jquery.makeCollapsible: Fix typo in documentation
Change-Id: Iaf53f0e460bc8684f0925c2f3963d988f8624aa4
daniel [Fri, 30 Mar 2018 11:29:33 +0000 (13:29 +0200)]
[MCR] Introduce RevisionSlotsUpdate.
The RevisionSlotsUpdate interface represents a change to a pages slots,
as applied by an edit.
This also introduces RevisionSlots::hasSameContent and pulls up
getTouchedSlots() and getInheritedSlots() from MutableRevisionStore
to RevisionStore, in preparation of using these classes in the
refactoring of WikiPage::doEditContent and friends.
Bug: T174038
Change-Id: Idb0ef885b343a76137b640fdfc1bf36104b00895
jenkins-bot [Tue, 8 May 2018 00:36:06 +0000 (00:36 +0000)]
Merge "HTMLTitleTextField: Allow this field to not be required"
jenkins-bot [Mon, 7 May 2018 22:41:26 +0000 (22:41 +0000)]
Merge "RELEASE-NOTES-1.32: Follow-up
f1d0d364c4d, explain this is alignment not quality loss"
jenkins-bot [Mon, 7 May 2018 22:33:03 +0000 (22:33 +0000)]
Merge "mediawiki.util: Drop updateTooltipAccessKeys(), deprecated since 1.24"
James D. Forrester [Mon, 7 May 2018 19:36:20 +0000 (12:36 -0700)]
RELEASE-NOTES-1.32: Follow-up
f1d0d364c4d, explain this is alignment not quality loss
Change-Id: I03f6db941516a74c1f16aeb8158a6445ebc7b5a9
jenkins-bot [Mon, 7 May 2018 22:24:42 +0000 (22:24 +0000)]
Merge "mediawiki.util: Drop escapeId(), deprecated since 1.30 and unused"
jenkins-bot [Mon, 7 May 2018 22:23:38 +0000 (22:23 +0000)]
Merge "RELEASE-NOTES-1.32: Some cleanup"
jenkins-bot [Mon, 7 May 2018 22:03:33 +0000 (22:03 +0000)]
Merge "Use BlockListPager::getLimitSelectList() in Special:BlockList and Special:AutoblockList"