From: Tim Starling <tstarling@users.mediawiki.org>
Date: Fri, 23 Jul 2010 05:11:18 +0000 (+0000)
Subject: Fixed inappropriate conversion of strpos() result to boolean, causing the first cooki... 
X-Git-Tag: 1.31.0-rc.0~35997
X-Git-Url: http://git.cyclocoop.org/%27.%28%24current%20%3E%202?a=commitdiff_plain;h=a4ce030e411ea3140f86be5de652bc4eb39c5646;p=lhc%2Fweb%2Fwiklou.git

Fixed inappropriate conversion of strpos() result to boolean, causing the first cookie in the header to not be recognised as a cache-varying cookie
---

diff --git a/includes/OutputPage.php b/includes/OutputPage.php
index d5a54021b9..7654025e0e 100644
--- a/includes/OutputPage.php
+++ b/includes/OutputPage.php
@@ -1275,7 +1275,7 @@ class OutputPage {
 		$cvCookies = $this->getCacheVaryCookies();
 		foreach ( $cvCookies as $cookieName ) {
 			# Check for a simple string match, like the way squid does it
-			if ( strpos( $cookieHeader, $cookieName ) ) {
+			if ( strpos( $cookieHeader, $cookieName ) !== false ) {
 				wfDebug( __METHOD__ . ": found $cookieName\n" );
 				return true;
 			}