From: Alexandre Emsenhuber <ialex@users.mediawiki.org>
Date: Sun, 12 Sep 2010 16:48:03 +0000 (+0000)
Subject: Let's just kill $wgUpdates since OpenID was converted in r72798.
X-Git-Tag: 1.31.0-rc.0~34974
X-Git-Url: http://git.cyclocoop.org/%27.%28%24current%20%3E%202?a=commitdiff_plain;h=49b841a1a1ac2b0196f960b911a1d8aebe4020d0;p=lhc%2Fweb%2Fwiklou.git

Let's just kill $wgUpdates since OpenID was converted in r72798.

I hope I was the only one that has the idea to use $wgUpdates in an extension :)
---

diff --git a/includes/installer/DatabaseUpdater.php b/includes/installer/DatabaseUpdater.php
index 9b16b24057..14954cb756 100644
--- a/includes/installer/DatabaseUpdater.php
+++ b/includes/installer/DatabaseUpdater.php
@@ -54,12 +54,9 @@ abstract class DatabaseUpdater {
 	 * something much nicer
 	 */
 	private function initOldGlobals() {
-		global $wgUpdates, $wgExtNewTables, $wgExtNewFields, $wgExtPGNewFields,
+		global $wgExtNewTables, $wgExtNewFields, $wgExtPGNewFields,
 			$wgExtPGAlteredFields, $wgExtNewIndexes, $wgExtModifiedFields;
 
-		// Deprecated. Do not use, ever.
-		$wgUpdates = array();
-
 		# For extensions only, should be populated via hooks
 		# $wgDBtype should be checked to specifiy the proper file
 		$wgExtNewTables = array(); // table, dir
@@ -197,14 +194,14 @@ abstract class DatabaseUpdater {
 	}
 
 	/**
-	 * Before 1.17, we used to handle updates via stuff like $wgUpdates,
+	 * Before 1.17, we used to handle updates via stuff like
 	 * $wgExtNewTables/Fields/Indexes. This is nasty :) We refactored a lot
 	 * of this in 1.17 but we want to remain back-compatible for awhile. So
 	 * load up these old global-based things into our update list.
 	 */
 	protected function getOldGlobalUpdates() {
-		global $wgUpdates, $wgExtNewFields, $wgExtNewTables,
-			$wgExtModifiedFields, $wgExtNewIndexes, $wgSharedDB, $wgSharedTables;
+		global $wgExtNewFields, $wgExtNewTables, $wgExtModifiedFields,
+			$wgExtNewIndexes, $wgSharedDB, $wgSharedTables;
 
 		$doUser = $this->shared ?
 			$wgSharedDB && in_array( 'user', $wgSharedTables ) :
@@ -212,12 +209,6 @@ abstract class DatabaseUpdater {
 
 		$updates = array();
 
-		if( isset( $wgUpdates[ $this->db->getType() ] ) ) {
-			foreach( $wgUpdates[ $this->db->getType() ] as $upd ) {
-				$updates[] = $upd;
-			}
-		}
-
 		foreach ( $wgExtNewTables as $tableRecord ) {
 			$updates[] = array(
 				'addTable', $tableRecord[0], $tableRecord[1], true