Merge "Improved vague/incomplete $1 thumb.php error messages"
authorjenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Sat, 18 Jan 2014 02:58:00 +0000 (02:58 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Sat, 18 Jan 2014 02:58:00 +0000 (02:58 +0000)
includes/media/Bitmap.php

index 1be04a7..7f108c8 100644 (file)
@@ -187,7 +187,9 @@ class BitmapHandler extends ImageHandler {
                                        wfHostname(), $image->getName() ) );
 
                        return new MediaTransformError( 'thumbnail_error',
-                               $scalerParams['clientWidth'], $scalerParams['clientHeight'] );
+                               $scalerParams['clientWidth'], $scalerParams['clientHeight'],
+                               wfMessage( 'filemissing' )->text()
+                       );
                }
 
                # Try a hook
@@ -227,7 +229,9 @@ class BitmapHandler extends ImageHandler {
                } elseif ( $removed ) {
                        # Thumbnail was zero-byte and had to be removed
                        return new MediaTransformError( 'thumbnail_error',
-                               $scalerParams['clientWidth'], $scalerParams['clientHeight'] );
+                               $scalerParams['clientWidth'], $scalerParams['clientHeight'],
+                               wfMessage( 'unknown-error' )->text()
+                       );
                } elseif ( $mto ) {
                        return $mto;
                } else {