From: Platonides <platonides@users.mediawiki.org>
Date: Tue, 7 Dec 2010 20:40:15 +0000 (+0000)
Subject: Remove the $wgCaches[CACHE_DB] = false; line added in r74552.
X-Git-Tag: 1.31.0-rc.0~33466
X-Git-Url: http://git.cyclocoop.org/%27-%20%20.%20url_absolue%28find_in_path%28%27spip_style.css%27%29%29%20%20%20.%20url_absolue%28find_in_path%28%27prive/spip_style.css%27%29%29%20.%20%27?a=commitdiff_plain;h=ac9bd01ecb765b6dc1f5e1ac139f572409255a29;p=lhc%2Fweb%2Fwiklou.git

Remove the $wgCaches[CACHE_DB] = false; line added in r74552.
It produces an strange failure when going out of ParserTest::setUp() scope.
(eg. $parserMemc becoming back false instead of a FakeMemcached, related to
using a reference in $wgMemc = &wfGetMainCache() )

Can be checked when running phpunit.php includes/ParserOptionsTest.php
See https://bugzilla.wikimedia.org/show_bug.cgi?id=26244#c4

No errors found in sqlite without it.
---

diff --git a/maintenance/tests/phpunit/phpunit.php b/maintenance/tests/phpunit/phpunit.php
index 744f3d0b79..94d4ebd2d6 100755
--- a/maintenance/tests/phpunit/phpunit.php
+++ b/maintenance/tests/phpunit/phpunit.php
@@ -20,9 +20,6 @@ require_once( "$IP/maintenance/commandLine.inc" );
 // Assume UTC for testing purposes
 $wgLocaltimezone = 'UTC';
 
-// To prevent tests from failing with SQLite, we need to turn database caching off
-$wgCaches[CACHE_DB] = false;
-
 require_once( 'PHPUnit/Runner/Version.php' );
 if( version_compare( PHPUnit_Runner_Version::id(), '3.5.0', '>=' ) ) {
 	# PHPUnit 3.5.0 introduced a nice autoloader based on class name