Merge "registration: Remove unused variable"
authorjenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Fri, 29 May 2015 15:24:51 +0000 (15:24 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Fri, 29 May 2015 15:24:51 +0000 (15:24 +0000)
1  2 
includes/registration/ExtensionRegistry.php

   */
  class ExtensionRegistry {
  
 +      /**
 +       * Version of the highest supported manifest version
 +       */
 +      const MANIFEST_VERSION = 1;
 +
 +      /**
 +       * Version of the oldest supported manifest version
 +       */
 +      const OLDEST_MANIFEST_VERSION = 1;
 +
        /**
         * @var BagOStuff
         */
         * @throws Exception
         */
        public function readFromQueue( array $queue ) {
-               $data = array( 'globals' => array( 'wgAutoloadClasses' => array() ) );
                $autoloadClasses = array();
                $processor = new ExtensionProcessor();
                foreach ( $queue as $path => $mtime ) {
                        if ( !is_array( $info ) ) {
                                throw new Exception( "$path is not a valid JSON file." );
                        }
 +                      if ( !isset( $info['manifest_version' ] ) ) {
 +                              // For backwards-compatability, assume a version of 1
 +                              $info['manifest_version'] = 1;
 +                      }
 +                      $version = $info['manifest_version'];
 +                      if ( $version < self::OLDEST_MANIFEST_VERSION || $version > self::MANIFEST_VERSION ) {
 +                              throw new Exception( "$path: unsupported manifest_version: {$version}" );
 +                      }
                        $autoload = $this->processAutoLoader( dirname( $path ), $info );
                        // Set up the autoloader now so custom processors will work
                        $GLOBALS['wgAutoloadClasses'] += $autoload;
                        $autoloadClasses += $autoload;
 -                      $processor->extractInfo( $path, $info );
 +                      $processor->extractInfo( $path, $info, $version );
                }
                $data = $processor->getExtractedInfo();
                // Need to set this so we can += to it later