From: Volker E <volker.e@wikimedia.org>
Date: Sat, 18 Feb 2017 12:38:36 +0000 (-0800)
Subject: build: Enable use of stylelint-config-wikimedia and make pass
X-Git-Tag: 1.31.0-rc.0~4047^2~2
X-Git-Url: http://git.cyclocoop.org/%27%20.%20url_absolue%28%24favicon%29%20.%20?a=commitdiff_plain;h=5e589de4aabe8b5592de79989a461f68a2feb20a;p=lhc%2Fweb%2Fwiklou.git

build: Enable use of stylelint-config-wikimedia and make pass

Enabling stylelint-config-wikimedia for Grunt stylelint,
which was already introduced in 3bf6f429295e, but has not yet
been actively used to enforce Wikimedia CSS Coding Standards.
For this first patch nullifying several options, which will be enabled
in follow-up patches in order to be easier reviewable.

Change-Id: I3859e04797203a64d82206a379dbb320e5e113d5
---

diff --git a/.stylelintrc b/.stylelintrc
index 62dbeb69ed..b7e81d0ca9 100644
--- a/.stylelintrc
+++ b/.stylelintrc
@@ -1,26 +1,23 @@
 {
+	"extends": "stylelint-config-wikimedia",
 	"rules": {
-		"color-hex-case": [ "lower" ],
-		"color-hex-length": [ "short" ],
-		"color-named": [ "never" ],
-		"color-no-invalid-hex": true,
+		"declaration-block-no-duplicate-properties": null,
+		"declaration-no-important": null,
 
-		"declaration-bang-space-after": [ "never" ],
-		"declaration-bang-space-before": [ "always" ],
-		"declaration-colon-space-after": [ "always" ],
-		"declaration-colon-space-before": [ "never" ],
+		"indentation": null,
 
-		"font-family-name-quotes": [ "always-unless-keyword" ],
-		"font-weight-notation": [ "named-where-possible" ],
+		"no-descending-specificity": null,
+		"no-duplicate-selectors": null,
 
-		"function-calc-no-unspaced-operator": true,
-		"function-comma-newline-after": "never-multi-line",
-		"function-comma-newline-before": "never-multi-line",
-		"function-comma-space-after": [ "always" ],
-		"function-comma-space-before": [ "never" ],
-		"function-parentheses-newline-inside": [ "never-multi-line" ],
-		"function-parentheses-space-inside": [ "always" ],
-		"function-url-quotes": [ "never" ],
-		"function-whitespace-after": [ "always" ],
+		"number-leading-zero": null,
+
+		"selector-list-comma-newline-after": null,
+		"selector-no-id": null,
+		"selector-pseudo-class-parentheses-space-inside": null,
+		"selector-pseudo-element-colon-notation": null,
+
+		"string-quotes": null,
+
+		"value-keyword-case": null
 	}
 }
diff --git a/Gruntfile.js b/Gruntfile.js
index 5f6d584239..191286ad7a 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -58,7 +58,7 @@ module.exports = function ( grunt ) {
 			options: {
 				syntax: 'less'
 			},
-			src: '{resources/src/**,mw-config/**}/*.{css,less}'
+			src: '{resources/src,mw-config}/**/*.{css,less}'
 		},
 		watch: {
 			files: [
diff --git a/resources/src/jquery/jquery.arrowSteps.css b/resources/src/jquery/jquery.arrowSteps.css
index d24fcc950e..92c6c43c97 100644
--- a/resources/src/jquery/jquery.arrowSteps.css
+++ b/resources/src/jquery/jquery.arrowSteps.css
@@ -7,9 +7,9 @@
 
 .arrowSteps li {
 	float: left;
-	padding: 0px;
-	margin: 0px;
-	border: 0 none;
+	padding: 0;
+	margin: 0;
+	border: 0;
 }
 
 .arrowSteps li div {
diff --git a/resources/src/jquery/jquery.suggestions.css b/resources/src/jquery/jquery.suggestions.css
index f6b4fd188c..c32f25aa02 100644
--- a/resources/src/jquery/jquery.suggestions.css
+++ b/resources/src/jquery/jquery.suggestions.css
@@ -6,7 +6,7 @@
 	top: 0;
 	left: 0;
 	width: 0;
-	border: none;
+	border: 0;
 	z-index: 1099;
 	padding: 0;
 	margin: -1px 0 0 0;
diff --git a/resources/src/mediawiki.action/mediawiki.action.view.filepage.css b/resources/src/mediawiki.action/mediawiki.action.view.filepage.css
index 1f0365eced..85e5c2661a 100644
--- a/resources/src/mediawiki.action/mediawiki.action.view.filepage.css
+++ b/resources/src/mediawiki.action/mediawiki.action.view.filepage.css
@@ -93,7 +93,7 @@
 }
 
 .mw_metadata {
-	border: none;
+	border: 0;
 	border-collapse: collapse;
 }
 
diff --git a/resources/src/mediawiki.legacy/commonPrint.css b/resources/src/mediawiki.legacy/commonPrint.css
index ec94df34e4..99accf4d90 100644
--- a/resources/src/mediawiki.legacy/commonPrint.css
+++ b/resources/src/mediawiki.legacy/commonPrint.css
@@ -258,7 +258,7 @@ html .thumbimage {
 }
 
 html .thumbcaption {
-	border: none;
+	border: 0;
 	text-align: left;
 	line-height: 1.4em;
 	padding: 3px;
diff --git a/resources/src/mediawiki.legacy/oldshared.css b/resources/src/mediawiki.legacy/oldshared.css
index 4daf77f262..c36ddd977d 100644
--- a/resources/src/mediawiki.legacy/oldshared.css
+++ b/resources/src/mediawiki.legacy/oldshared.css
@@ -100,7 +100,7 @@ html .thumbimage {
 }
 
 html .thumbcaption {
-	border: none;
+	border: 0;
 	line-height: 1.4em;
 	padding: 3px;
 	font-size: 94%;
@@ -158,7 +158,7 @@ img.thumbborder {
 }
 
 img {
-	border: none;
+	border: 0;
 }
 
 #toc,
@@ -193,7 +193,7 @@ table.toc td {
 #toc h2,
 .toc h2 {
 	display: inline;
-	border: none;
+	border: 0;
 	padding: 0;
 	font-size: 100%;
 	font-weight: bold;
@@ -308,9 +308,7 @@ span.comment {
 }
 
 .editExternally {
-	border-style: solid;
-	border-width: 1px;
-	border-color: #808080;
+	border: 1px solid #808080;
 	background: #fff;
 	padding: 3px;
 	margin-top: 0.5em;
@@ -348,7 +346,7 @@ table.mw_metadata td {
 }
 
 table.mw_metadata {
-	border: none;
+	border: 0;
 	border-collapse: collapse;
 }
 
@@ -369,8 +367,7 @@ table.mw_metadata td {
 
 table.mw_metadata td.spacer {
 	background: inherit;
-	border-top: none;
-	border-bottom: none;
+	border-width: 0 1px;
 }
 
 .visualClear {
@@ -399,14 +396,14 @@ table.mw_metadata td.spacer {
 }
 
 div.multipageimagenavbox {
-	border: solid 1px #c0c0c0;
+	border: 1px solid #c0c0c0;
 	padding: 4px;
 	margin: 1em;
 	background: #f0f0f0;
 }
 
 div.multipageimagenavbox div.thumb {
-	border: none;
+	border: 0;
 	margin-left: 2em;
 	margin-right: 2em;
 }
diff --git a/resources/src/mediawiki.legacy/shared.css b/resources/src/mediawiki.legacy/shared.css
index 7919dc4002..a9cd9477a7 100644
--- a/resources/src/mediawiki.legacy/shared.css
+++ b/resources/src/mediawiki.legacy/shared.css
@@ -86,7 +86,7 @@ abbr[title],
 @supports (text-decoration: underline dotted) {
 	abbr[title],
 	.explain[title] {
-		border-bottom: none;
+		border-bottom: 0;
 		text-decoration: underline dotted;
 	}
 }
@@ -271,7 +271,7 @@ input#wpSummary:active {
 
 .catlinks li:first-child {
 	padding-left: 0.25em;
-	border-left: none;
+	border-left: 0;
 }
 
 /* (bug 5346) make category redirects italic */
@@ -433,7 +433,7 @@ table.wikitable > caption {
 	font-weight: bold;
 	display: inline;
 	margin: 0 .5em 0 0;
-	border: none;
+	border: 0;
 }
 
 .errorbox {
diff --git a/resources/src/mediawiki.less/mediawiki.mixins.animation.less b/resources/src/mediawiki.less/mediawiki.mixins.animation.less
index fd615b7a6b..651a018cd6 100644
--- a/resources/src/mediawiki.less/mediawiki.mixins.animation.less
+++ b/resources/src/mediawiki.less/mediawiki.mixins.animation.less
@@ -9,4 +9,4 @@
 	-webkit-transform: rotate( @deg );
 	-moz-transform: rotate( @deg );
 	transform: rotate( @deg );
-}
\ No newline at end of file
+}
diff --git a/resources/src/mediawiki.less/mediawiki.mixins.less b/resources/src/mediawiki.less/mediawiki.mixins.less
index f21de4beca..da35ac2d58 100644
--- a/resources/src/mediawiki.less/mediawiki.mixins.less
+++ b/resources/src/mediawiki.less/mediawiki.mixins.less
@@ -123,7 +123,6 @@
 	order: @order;
 }
 
-
 // Screen Reader Helper Mixin
 .mixin-screen-reader-text() {
 	display: block;
diff --git a/resources/src/mediawiki.skinning/content.css b/resources/src/mediawiki.skinning/content.css
index 87e209e20c..2cf2cb7a45 100644
--- a/resources/src/mediawiki.skinning/content.css
+++ b/resources/src/mediawiki.skinning/content.css
@@ -55,7 +55,7 @@ table.toc td {
 #toc h2,
 .toc h2 {
 	display: inline;
-	border: none;
+	border: 0;
 	padding: 0;
 	font-size: 100%;
 	font-weight: bold;
@@ -161,7 +161,7 @@ html .thumbimage {
 }
 
 html .thumbcaption {
-	border: none;
+	border: 0;
 	line-height: 1.4em;
 	padding: 3px;
 	font-size: 94%;
diff --git a/resources/src/mediawiki.skinning/content.parsoid.less b/resources/src/mediawiki.skinning/content.parsoid.less
index 346771f3f5..9014e7c86a 100644
--- a/resources/src/mediawiki.skinning/content.parsoid.less
+++ b/resources/src/mediawiki.skinning/content.parsoid.less
@@ -132,4 +132,6 @@ figure[typeof~='mw:Image/Frame'] > *:first-child > img,
 
 /* Hide the caption for frameless and plain floated images */
 figure[typeof~="mw:Image/Frameless"] > figcaption,
-figure[typeof~="mw:Image"] > figcaption { display: none }
+figure[typeof~="mw:Image"] > figcaption {
+	display: none;
+}
diff --git a/resources/src/mediawiki.skinning/elements.css b/resources/src/mediawiki.skinning/elements.css
index 7d096f96ff..8776c07f93 100644
--- a/resources/src/mediawiki.skinning/elements.css
+++ b/resources/src/mediawiki.skinning/elements.css
@@ -82,7 +82,7 @@ a.new:visited, #p-personal a.new:visited {
 
 /* Inline Elements */
 img {
-	border: none;
+	border: 0;
 	vertical-align: middle;
 }
 
@@ -123,7 +123,7 @@ h3,
 h4,
 h5,
 h6 {
-	border-bottom: none;
+	border-bottom: 0;
 	font-weight: bold;
 }
 
@@ -243,7 +243,7 @@ legend {
 }
 
 form {
-	border: none;
+	border: 0;
 	margin: 0;
 }
 
diff --git a/resources/src/mediawiki.skinning/interface.css b/resources/src/mediawiki.skinning/interface.css
index d3f188a24a..f223e2abfd 100644
--- a/resources/src/mediawiki.skinning/interface.css
+++ b/resources/src/mediawiki.skinning/interface.css
@@ -23,7 +23,7 @@ textarea {
 .editOptions {
 	background-color: #f8f9fa;
 	border: 1px solid #c8ccd1;
-	border-top: none;
+	border-top: 0;
 	padding: 1em 1em 1.5em 1em;
 	margin-bottom: 2em;
 }
diff --git a/resources/src/mediawiki.special/mediawiki.special.apisandbox.css b/resources/src/mediawiki.special/mediawiki.special.apisandbox.css
index 59a03f3117..7f54b904bc 100644
--- a/resources/src/mediawiki.special/mediawiki.special.apisandbox.css
+++ b/resources/src/mediawiki.special/mediawiki.special.apisandbox.css
@@ -43,7 +43,7 @@
 }
 
 .mw-apisandbox-help-field:last-child {
-	border-bottom: none;
+	border-bottom: 0;
 }
 
 .mw-apisandbox-optionalWidget {
diff --git a/resources/src/mediawiki.special/mediawiki.special.search.interwikiwidget.styles.less b/resources/src/mediawiki.special/mediawiki.special.search.interwikiwidget.styles.less
index 9ee1b0bd38..7147f04fff 100644
--- a/resources/src/mediawiki.special/mediawiki.special.search.interwikiwidget.styles.less
+++ b/resources/src/mediawiki.special/mediawiki.special.search.interwikiwidget.styles.less
@@ -37,8 +37,12 @@
 	height: 0;
 }
 
-* html .interwiki-result             { zoom: 1; } /* IE6 */
-*:first-child+html .iw-resultset { zoom: 1; } /* IE7 */
+* html .interwiki-result { /* IE6 */
+    zoom: 1;
+}
+*:first-child + html .iw-resultset { /* IE7 */
+    zoom: 1;
+}
 
 /* padding each .iw-resultset section seperately.
 This allows us greater flexibility in the design.
@@ -48,10 +52,7 @@ header and footer. */
 .iw-result__title,
 .iw-result__content,
 .iw-result__footer {
-    padding-left: 0.85em;
-    padding-right: 0.85em;
-    padding-top: 0.25em;
-    padding-bottom: 0.25em;
+    padding: 0.25em 0.85em;
 }
 
 /* definition titles appear inline,
@@ -197,7 +198,7 @@ span the interwiki results across the bottom of the page.
 }
 
 /* mobile */
-@media only screen and ( max-width:768px ) {
+@media only screen and ( max-width: 768px ) {
     #mw-interwiki-results {
         width: 100%;
     }
@@ -212,8 +213,8 @@ span the interwiki results across the bottom of the page.
 
 }
 
-@media only screen and ( max-width:600px ) {
-        .iw-resultset {
+@media only screen and ( max-width: 600px ) {
+    .iw-resultset {
         width: 100% !important;
         margin-left: 0 !important;
         margin-right: 0 !important;
diff --git a/resources/src/mediawiki.ui/components/anchors.less b/resources/src/mediawiki.ui/components/anchors.less
index ff38d0df20..6397c735e7 100644
--- a/resources/src/mediawiki.ui/components/anchors.less
+++ b/resources/src/mediawiki.ui/components/anchors.less
@@ -29,7 +29,6 @@ The anchor base type can be applied to `a` elements when a basic context styling
 having to assign it as a button type. `.mw-ui-anchor` only changes the text color, and should not be used in combination
 with other base classes, such as `.mw-ui-button`.
 
-
 Markup:
 <a href="#" class="mw-ui-anchor mw-ui-progressive">Progressive</a>
 <a href="#" class="mw-ui-anchor mw-ui-destructive">Destructive</a>
diff --git a/resources/src/mediawiki.ui/components/icons.less b/resources/src/mediawiki.ui/components/icons.less
index 0035601697..efb04ae983 100644
--- a/resources/src/mediawiki.ui/components/icons.less
+++ b/resources/src/mediawiki.ui/components/icons.less
@@ -90,4 +90,4 @@
 	&.mw-ui-icon-small:before {
 		background-size: 66.67% auto; // 66.67% of 24px equals 16px
 	}
-}
\ No newline at end of file
+}
diff --git a/resources/src/mediawiki.ui/components/text.less b/resources/src/mediawiki.ui/components/text.less
index 30593bfe68..c0684d908a 100644
--- a/resources/src/mediawiki.ui/components/text.less
+++ b/resources/src/mediawiki.ui/components/text.less
@@ -33,4 +33,4 @@ Styleguide 6.1.
 	&.mw-ui-destructive {
 		color: @colorDestructive;
 	}
-}
\ No newline at end of file
+}
diff --git a/resources/src/mediawiki.widgets.datetime/CalendarWidget.less b/resources/src/mediawiki.widgets.datetime/CalendarWidget.less
index 77f87f7d80..1fb234edc0 100644
--- a/resources/src/mediawiki.widgets.datetime/CalendarWidget.less
+++ b/resources/src/mediawiki.widgets.datetime/CalendarWidget.less
@@ -51,7 +51,7 @@
 
 			.oo-ui-buttonElement-button {
 				width: 100%;
-				border: 1px dotted rgba( 255, 255, 255, 0.0 );
+				border: 1px dotted rgba( 255, 255, 255, 0 );
 				.oo-ui-box-sizing( border-box );
 			}
 
diff --git a/resources/src/mediawiki.widgets.datetime/DateTimeInputWidget.less b/resources/src/mediawiki.widgets.datetime/DateTimeInputWidget.less
index 84788d2a2f..183694f231 100644
--- a/resources/src/mediawiki.widgets.datetime/DateTimeInputWidget.less
+++ b/resources/src/mediawiki.widgets.datetime/DateTimeInputWidget.less
@@ -92,7 +92,7 @@
 		font-family: inherit;
 		background-color: transparent;
 		color: inherit;
-		border: none;
+		border: 0;
 		box-shadow: none;
 		text-align: center;
 		vertical-align: middle;
diff --git a/resources/src/mediawiki.widgets/mw.widgets.CalendarWidget.less b/resources/src/mediawiki.widgets/mw.widgets.CalendarWidget.less
index 2fe5d3d2db..aa5c60a0e9 100644
--- a/resources/src/mediawiki.widgets/mw.widgets.CalendarWidget.less
+++ b/resources/src/mediawiki.widgets/mw.widgets.CalendarWidget.less
@@ -26,10 +26,10 @@
 .mw-widget-calendarWidget-header .mw-widget-calendarWidget-labelButton {
 	margin: 0 auto;
 	display: block;
-	width: @calendarWidth - 2*3em;
+	width: @calendarWidth - 2 * 3em;
 
 	.oo-ui-buttonElement-button {
-		width: @calendarWidth - 2*3em;
+		width: @calendarWidth - 2 * 3em;
 		text-align: center;
 	}
 }
diff --git a/resources/src/mediawiki.widgets/mw.widgets.StashedFileWidget.less b/resources/src/mediawiki.widgets/mw.widgets.StashedFileWidget.less
index ecfc880e56..f70c03d1ca 100644
--- a/resources/src/mediawiki.widgets/mw.widgets.StashedFileWidget.less
+++ b/resources/src/mediawiki.widgets/mw.widgets.StashedFileWidget.less
@@ -124,7 +124,7 @@
 	}
 
 	.mw-widgets-stashedFileWidget-info {
-		border: none;
+		border: 0;
 		background: none;
 		display: block;
 		height: 100%;
@@ -147,7 +147,6 @@
 	}
 }
 
-
 .mw-widgets-stashedFileWidget-empty {
 	.mw-widgets-stashedFileWidget-thumbnail-container {
 		text-align: center;
diff --git a/resources/src/mediawiki/mediawiki.ForeignStructuredUpload.BookletLayout.less b/resources/src/mediawiki/mediawiki.ForeignStructuredUpload.BookletLayout.less
index 0021caf7c4..877c99b1e0 100644
--- a/resources/src/mediawiki/mediawiki.ForeignStructuredUpload.BookletLayout.less
+++ b/resources/src/mediawiki/mediawiki.ForeignStructuredUpload.BookletLayout.less
@@ -16,4 +16,4 @@
 			color: #555;
 		}
 	}
-}
\ No newline at end of file
+}
diff --git a/resources/src/mediawiki/mediawiki.Upload.BookletLayout.css b/resources/src/mediawiki/mediawiki.Upload.BookletLayout.css
index d64a6b4681..72ce9f0b32 100644
--- a/resources/src/mediawiki/mediawiki.Upload.BookletLayout.css
+++ b/resources/src/mediawiki/mediawiki.Upload.BookletLayout.css
@@ -31,4 +31,4 @@
 
 .mw-upload-bookletLayout-filePreview .oo-ui-progressBarWidget-bar {
 	height: 0.5em;
-}
\ No newline at end of file
+}
diff --git a/resources/src/mediawiki/mediawiki.apihelp.css b/resources/src/mediawiki/mediawiki.apihelp.css
index 365e988e84..25ab2d0e7b 100644
--- a/resources/src/mediawiki/mediawiki.apihelp.css
+++ b/resources/src/mediawiki/mediawiki.apihelp.css
@@ -68,7 +68,7 @@ div.apihelp-linktrail {
 }
 
 .apihelp-parameters dt:after {
-	content: ':\A0'
+	content: ':\A0';
 }
 
 .apihelp-parameters dd {
diff --git a/resources/src/mediawiki/mediawiki.debug.less b/resources/src/mediawiki/mediawiki.debug.less
index 3cca6ebdc1..e1c8406555 100644
--- a/resources/src/mediawiki/mediawiki.debug.less
+++ b/resources/src/mediawiki/mediawiki.debug.less
@@ -8,7 +8,7 @@
 		padding: 0;
 		margin: 0;
 		background: none;
-		border: none;
+		border: 0;
 	}
 
 	table {
diff --git a/resources/src/mediawiki/mediawiki.diff.styles.css b/resources/src/mediawiki/mediawiki.diff.styles.css
index 327c9c8dd0..af9eb36044 100644
--- a/resources/src/mediawiki/mediawiki.diff.styles.css
+++ b/resources/src/mediawiki/mediawiki.diff.styles.css
@@ -2,7 +2,7 @@
  * Diff rendering
  */
 table.diff {
-	border: none;
+	border: 0;
 	border-spacing: 4px;
 	margin: 0;
 	width: 100%;
diff --git a/resources/src/mediawiki/page/gallery.css b/resources/src/mediawiki/page/gallery.css
index 1c1bb5da1b..31def27b2a 100644
--- a/resources/src/mediawiki/page/gallery.css
+++ b/resources/src/mediawiki/page/gallery.css
@@ -58,7 +58,7 @@ div.gallerytext {
 /* new gallery stuff */
 ul.mw-gallery-nolines li.gallerybox div.thumb {
 	background-color: transparent;
-	border: none;
+	border: 0;
 }
 
 ul.mw-gallery-nolines li.gallerybox div.gallerytext {
@@ -71,7 +71,7 @@ ul.mw-gallery-packed li.gallerybox div.thumb,
 ul.mw-gallery-packed-overlay li.gallerybox div.thumb,
 ul.mw-gallery-packed-hover li.gallerybox div.thumb {
 	background-color: transparent;
-	border: none;
+	border: 0;
 }
 
 ul.mw-gallery-packed li.gallerybox div.thumb img,
@@ -168,7 +168,7 @@ ul.gallery.mw-gallery-slideshow .mw-gallery-slideshow-buttons .oo-ui-buttonEleme
 }
 
 ul.mw-gallery-slideshow li.gallerybox div.thumb {
-	border: none;
+	border: 0;
 	background: transparent;
 }