From fb10a65d1286ae5455a5a2ddf202e05d87757ae6 Mon Sep 17 00:00:00 2001 From: Timo Tijhof Date: Wed, 16 Jul 2014 04:10:57 +0200 Subject: [PATCH] mw.loader: Optimise away duplicate else branches in getMarker() Change-Id: I2ea541c16befd3ea7ff2d23c6e059ac66d8ebb88 --- resources/src/mediawiki/mediawiki.js | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/resources/src/mediawiki/mediawiki.js b/resources/src/mediawiki/mediawiki.js index 9061acdf4f..b22e24019e 100644 --- a/resources/src/mediawiki/mediawiki.js +++ b/resources/src/mediawiki/mediawiki.js @@ -652,18 +652,14 @@ /* Private methods */ function getMarker() { - // Cached ? - if ( $marker ) { - return $marker; - } - - $marker = $( 'meta[name="ResourceLoaderDynamicStyles"]' ); - if ( $marker.length ) { - return $marker; + // Cached + if ( !$marker ) { + $marker = $( 'meta[name="ResourceLoaderDynamicStyles"]' ); + if ( !$marker.length ) { + mw.log( 'No found, inserting dynamically' ); + $marker = $( '' ).attr( 'name', 'ResourceLoaderDynamicStyles' ).appendTo( 'head' ); + } } - mw.log( 'getMarker> No found, inserting dynamically.' ); - $marker = $( '' ).attr( 'name', 'ResourceLoaderDynamicStyles' ).appendTo( 'head' ); - return $marker; } -- 2.20.1