From cb92c72c63274b332dc81edf473b1b3979ab4bdf Mon Sep 17 00:00:00 2001 From: Stephane Bisson Date: Thu, 4 Jan 2018 15:49:15 -0500 Subject: [PATCH] [BREAKING CHANGE] Rename TitleWidget#getTitle to TitleWidget#getMWTitle Rename TitleWidget#getTitle so it won't clash with TitledElement#getTitle Bug: T184181 Change-Id: I97ff46d8ca60f260af2a0b12e6c053aa91c777d1 --- .../src/mediawiki.widgets/mw.widgets.TitleInputWidget.js | 2 +- resources/src/mediawiki.widgets/mw.widgets.TitleWidget.js | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/resources/src/mediawiki.widgets/mw.widgets.TitleInputWidget.js b/resources/src/mediawiki.widgets/mw.widgets.TitleInputWidget.js index a78ad82b4a..98d07f3bb7 100644 --- a/resources/src/mediawiki.widgets/mw.widgets.TitleInputWidget.js +++ b/resources/src/mediawiki.widgets/mw.widgets.TitleInputWidget.js @@ -131,7 +131,7 @@ value = mw.widgets.TitleInputWidget.parent.prototype.cleanUpValue.call( this, value ); return $.trimByteLength( this.value, value, this.maxLength, function ( value ) { - var title = widget.getTitle( value ); + var title = widget.getMWTitle( value ); return title ? title.getMain() : value; } ).newVal; }; diff --git a/resources/src/mediawiki.widgets/mw.widgets.TitleWidget.js b/resources/src/mediawiki.widgets/mw.widgets.TitleWidget.js index 5670ce42df..0c6385b33e 100644 --- a/resources/src/mediawiki.widgets/mw.widgets.TitleWidget.js +++ b/resources/src/mediawiki.widgets/mw.widgets.TitleWidget.js @@ -355,7 +355,7 @@ * @param {string} [value] Value to get a title for * @return {mw.Title|null} Title object, or null if value is invalid */ - mw.widgets.TitleWidget.prototype.getTitle = function ( value ) { + mw.widgets.TitleWidget.prototype.getMWTitle = function ( value ) { var title = value !== undefined ? value : this.getQueryValue(), // mw.Title doesn't handle null well titleObj = mw.Title.newFromText( title, this.namespace !== null ? this.namespace : undefined ); @@ -369,7 +369,7 @@ * @return {boolean} The query is valid */ mw.widgets.TitleWidget.prototype.isQueryValid = function () { - return this.validateTitle ? !!this.getTitle() : true; + return this.validateTitle ? !!this.getMWTitle() : true; }; }( jQuery, mediaWiki ) ); -- 2.20.1