From 8ed6eed7a7ea9f5e4c55f859e7f2513997b2acde Mon Sep 17 00:00:00 2001 From: =?utf8?q?Mat=C4=9Bj=20Such=C3=A1nek?= Date: Fri, 29 Jun 2018 22:53:11 +0200 Subject: [PATCH] WikiPage: Do not set "undid revision ID" for rollbacks It causes them to be tagged with the "mw-undo" tag, in addition to the "mw-rollback" tag they already have. Bug: T190374 Change-Id: Ia447a107f0844cfef4a51a72fdec7aeea0480c70 --- includes/page/WikiPage.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/page/WikiPage.php b/includes/page/WikiPage.php index ad3c8c592b..c25ff357c9 100644 --- a/includes/page/WikiPage.php +++ b/includes/page/WikiPage.php @@ -2959,7 +2959,7 @@ class WikiPage implements Page, IDBAccessObject { } $updater->setOriginalRevisionId( $target->getId() ); - $updater->setUndidRevisionId( $current->getId() ); + // Do not call setUndidRevisionId(), that causes an extra "mw-undo" tag to be added (T190374) $updater->addTags( $tags ); // TODO: this logic should not be in the storage layer, it's here for compatibility -- 2.20.1