From 7a44c515808307150ea57c5f007ba48677132c47 Mon Sep 17 00:00:00 2001 From: Brad Jorsch Date: Wed, 20 Sep 2017 15:29:54 -0400 Subject: [PATCH] Fix warning in DifferenceEngine Make sure that the ar_namespace and ar_text fields are selected from the database. Change-Id: Ic2e8f99f43025510c14e0a8ff2b708b378cf7ef3 --- includes/diff/DifferenceEngine.php | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/includes/diff/DifferenceEngine.php b/includes/diff/DifferenceEngine.php index ed8cbb4ca3..a9d6ad69d4 100644 --- a/includes/diff/DifferenceEngine.php +++ b/includes/diff/DifferenceEngine.php @@ -182,7 +182,10 @@ class DifferenceEngine extends ContextSource { if ( $this->getUser()->isAllowed( 'deletedhistory' ) ) { $dbr = wfGetDB( DB_REPLICA ); $row = $dbr->selectRow( 'archive', - Revision::selectArchiveFields(), + array_merge( + Revision::selectArchiveFields(), + [ 'ar_namespace', 'ar_title' ] + ), [ 'ar_rev_id' => $id ], __METHOD__ ); if ( $row ) { -- 2.20.1