From 6205c06ebed0965fe7e097fb795f7600a0d2e93c Mon Sep 17 00:00:00 2001 From: =?utf8?q?Bartosz=20Dziewo=C5=84ski?= Date: Wed, 18 Jul 2018 19:45:40 +0200 Subject: [PATCH] LogEventsList: Remove options not used by HTMLForm HTMLForm gets the input value from the request. The values specified in the form descriptor were never used. (You can specify a default value, but that uses the 'default' key anyway.) Change-Id: I27934e1118492371e547dd5e94feb172a0510cc9 --- includes/logging/LogEventsList.php | 7 ------- 1 file changed, 7 deletions(-) diff --git a/includes/logging/LogEventsList.php b/includes/logging/LogEventsList.php index aecbce9870..95439b9c77 100644 --- a/includes/logging/LogEventsList.php +++ b/includes/logging/LogEventsList.php @@ -280,7 +280,6 @@ class LogEventsList extends ContextSource { 'class' => 'HTMLTitleTextField', 'label-message' => 'speciallogtitlelabel', 'name' => 'page', - 'value' => $title, 'required' => false ]; } @@ -304,16 +303,10 @@ class LogEventsList extends ContextSource { private function getExtraInputsDesc( $types ) { if ( count( $types ) == 1 ) { if ( $types[0] == 'suppress' ) { - $offender = $this->getRequest()->getVal( 'offender' ); - $user = User::newFromName( $offender, false ); - if ( !$user || ( $user->getId() == 0 && !IP::isIPAddress( $offender ) ) ) { - $offender = ''; // Blank field if invalid - } return [ 'type' => 'text', 'label-message' => 'revdelete-offender', 'name' => 'offender', - 'value' => $offender, ]; } else { // Allow extensions to add their own extra inputs -- 2.20.1